linux-stable.git/drivers/w1, branch linux-3.14.y

w1: fix w1_send_slave dropping a slave id

2014-05-06T14:59:26+00:00

commit 6b355b33a64fd6d8ead2b838ec16fb9b551f71e8 upstream.

Previous logic,
if (avail > 8) {
	store slave;
	return;
}
send data; clear;

The logic error is, if there isn't space send the buffer and clear,
but the slave wasn't added to the now empty buffer loosing that slave
id.  It also should have been "if (avail >= 8)" because when it is 8,
there is space.

Instead, if there isn't space send and clear the buffer, then there is
always space for the slave id.

Signed-off-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

drivers/w1/masters/w1-gpio.c: add strong pullup emulation

2014-01-24T00:37:04+00:00

Strong pullup is emulated by driving pin logic high after write command
when using tri-state push-pull GPIO.

Signed-off-by: Evgeny Boger 
Cc: Greg KH 
Acked-by: David Fries 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

w1: mxc_w1: Check the clk_prepare_enable() return value

2013-12-09T06:41:48+00:00

Signed-off-by: Alexander Shiyan 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: mxc_w1: Add warning for base frequency calculation

2013-12-09T06:41:48+00:00

Base frequency should be as close as possible to 1 MHz. This patch
adds warnings when clock is unreliable, according to i.MX datasheet.

Signed-off-by: Alexander Shiyan 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-12-09T06:41:48+00:00

Private field "clkdiv" is not used outside "probe", so there are
no reason to keep it in driver.

Signed-off-by: Alexander Shiyan 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

drivers/w1/masters/w1-gpio.c: use dev_get_platdata()

2013-11-15T00:32:21+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.  This is a cosmetic change to make
the code simpler and enhance the readability.

Signed-off-by: Jingoo Han 
Acked-by: Evgeniy Polyakov 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers: w1: make w1_slave::flags long to avoid memory corruption

2013-11-13T03:09:35+00:00

On architectures where long is more then 32 bits, modifying a 32-bit field
with set_bit (and other atomic bit operations) may cause bytes following
the field to by modified.

Because the endianness of the bits within a field is the native endianness
of the CPU[1], on big-endian machines, bit number zero is in the last byte
of the field.

Therefore, `set_bit(0, ptr)' on a 64-bit big-endian machine is roughly
equivalent to `((char *)ptr)[7] |= 1', and since w1 driver uses a 32-bit
field for holding the flags, this causes bytes beyond the field to be
modified.

[1] From Documentation/atomic_ops.txt:

    Native atomic bit operations are defined to operate on objects
    aligned to the size of an "unsigned long" C data type, and are
    least of that size.  The endianness of the bits within each
    "unsigned long" are the native endianness of the cpu.

Signed-off-by: Michal Nazarewicz 
Cc: Evgeniy Polyakov 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/w1/masters/ds1wm.cuse dev_get_platdata()

2013-11-13T03:09:35+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.  This is a cosmetic change to make
the code simpler and enhance the readability.

Signed-off-by: Jingoo Han 
Acked-by: Evgeniy Polyakov 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

w1-gpio: Use devm_* functions

2013-10-29T23:58:18+00:00

Signed-off-by: Markus Pargmann 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman

w1-gpio: Detect of_gpio_error for first gpio

2013-10-29T23:58:18+00:00

The first DT gpio is necessary for this driver, but errors returned for
of_get_gpio are ignored.

This patch adds a return value check for the first of_get_gpio.

Signed-off-by: Markus Pargmann 
Acked-by: Evgeniy Polyakov 
Signed-off-by: Greg Kroah-Hartman