linux-stable.git/drivers/vme, branch linux-3.10.y

vme: Fix wrong pointer utilization in ca91cx42_slave_get

2017-06-20T12:04:07+00:00

commit c8a6a09c1c617402cc9254b2bc8da359a0347d75 upstream.

In ca91cx42_slave_get function, the value pointed by vme_base pointer is
set through:

*vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);

So it must be dereferenced to be used in calculation of pci_base:

*pci_base = (dma_addr_t)*vme_base + pci_offset;

This bug was caught thanks to the following gcc warning:

drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:
drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
*pci_base = (dma_addr_t)vme_base + pci_offset;

Signed-off-by: Augusto Mecking Caringi 
Acked-By: Martyn Welch 
Signed-off-by: Jiri Slaby 
Signed-off-by: Willy Tarreau

VME: Correct read/write alignment algorithm

2014-02-22T20:41:28+00:00

commit f0342e66b397947ed8c3eef8c37b5ca2d5b1bb50 upstream.

In order to ensure the correct width cycles on the VME bus, the VME bridge
drivers implement an algorithm to utilise the largest possible width reads and
writes whilst maintaining natural alignment constraints. The algorithm
currently looks at the start address rather than the current read/write address
when determining whether a 16-bit width cycle is required to get to 32-bit
alignment.  This results in incorrect alignment,

Reported-by: Jim Strouth 
Tested-by: Jim Strouth 
Signed-off-by: Martyn Welch 
Signed-off-by: Greg Kroah-Hartman

vme: add missing put_device() after device_register() fails

2013-02-14T17:24:14+00:00

put_device() must be called after device_register() fails,
since device_register() always initializes the refcount
on the device structure.

Signed-off-by: Emilio G. Cota 
Signed-off-by: Greg Kroah-Hartman

vme: vme_tsi148.c: use module_pci_driver to simplify the code

2012-10-25T19:02:11+00:00

Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

vme: vme_ca91cx42.c: use module_pci_driver to simplify the code

2012-10-25T19:02:10+00:00

Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

vme: vme_vmivme7805.c: use module_pci_driver to simplify the code

2012-10-25T19:02:10+00:00

Use the module_pci_driver() macro to make the code simpler
by eliminating module_init and module_exit calls.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

vme: vme_ca91cx42.c: use list_for_each_safe() when delete list items

2012-09-06T20:29:11+00:00

Since we will be removing items off the list using list_del() we need
to use a safer version of the list_for_each() macro aptly named
list_for_each_safe(). We should use the safe macro if the loop
involves deletions of items.

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

vme: vme_tsi148.c: fix to use list_for_each_safe() when delete list items

2012-09-06T20:29:11+00:00

Since we will be removing items off the list using list_del() we need
to use a safer version of the list_for_each() macro aptly named
list_for_each_safe().

Signed-off-by: Wei Yongjun 
Signed-off-by: Greg Kroah-Hartman

VME: Prevent D16 cycles being split into 8-bit blocks

2012-07-19T22:39:39+00:00

The memcpy_fromio() and memcpy_toio() functions use the __memcpy() function,
at least on x86. This function carries out transfers smaller than 32 bits as
multiple 8 bit transfers, causing a single (aligned) 16 bit transfer to be
split into 2 8 bit transfers which may not be supported by the target VME
device.

The commit 53059aa05988761a738fa8bc082bbf3c5d4462d1 fixed this for the
ca91cx42, however this was not fixed for the tsi148 at the time. This patch
uses the same algorithm to fix the tsi148.

Reported-by: Daniel Lambert 
Signed-off-by: Martyn Welch 
Signed-off-by: Greg Kroah-Hartman

VME: Move API documentation to Documentation folder

2012-05-08T23:01:34+00:00

The documentation for the VME device driver API is currently in
drivers/vme/vme_api.txt, move this to Documentation/vme_api.txt

Signed-of-by: Martyn Welch 
Acked-by: Rob Landley 

Signed-off-by: Greg Kroah-Hartman