linux-stable.git/drivers/virtio/virtio.c, branch linux-3.18.y

virtio: release virtio index when fail to device_register

2017-12-16T09:32:26+00:00

commit e60ea67bb60459b95a50a156296041a13e0e380e upstream.

index can be reused by other virtio device.

Signed-off-by: weiping zhang 
Reviewed-by: Cornelia Huck 
Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Greg Kroah-Hartman

virtio: defer config changed notifications

2014-10-14T23:54:56+00:00

Defer config changed notifications that arrive during
probe/scan/freeze/restore.

This will allow drivers to set DRIVER_OK earlier, without worrying about
racing with config change interrupts.

This change will also benefit old hypervisors (before 2009)
that send interrupts without checking DRIVER_OK: previously,
the callback could race with driver-specific initialization.

This will also help simplify drivers.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Signed-off-by: Rusty Russell  (cosmetic changes)

virtio-pci: move freeze/restore to virtio core

2014-10-14T23:54:55+00:00

This is in preparation to extending config changed event handling
in core.
Wrapping these in an API also seems to make for a cleaner code.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Signed-off-by: Rusty Russell

virtio: unify config_changed handling

2014-10-14T23:54:54+00:00

Replace duplicated code in all transports with a single wrapper in
virtio.c.

The only functional change is in virtio_mmio.c: if a buggy device sends
us an interrupt before driver is set, we previously returned IRQ_NONE,
now we return IRQ_HANDLED.

As this must not happen in practice, this does not look like a big deal.

See also commit 3fff0179e33cd7d0a688dab65700c46ad089e934
	virtio-pci: do not oops on config change if driver not loaded.
for the original motivation behind the driver check.

Signed-off-by: Michael S. Tsirkin 
Reviewed-by: Cornelia Huck 
Signed-off-by: Rusty Russell

virtio: convert bus code to use dev_groups

2013-10-17T01:40:57+00:00

The dev_attrs field of struct bus_type is going away soon, dev_groups
should be used instead.  This converts the virtio bus code to use the
correct field.

Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Cc: 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'virtio-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux

2012-12-20T16:37:05+00:00

Pull virtio update from Rusty Russell:
 "Some nice cleanups, and even a patch my wife did as a "live" demo for
  Latinoware 2012.

  There's a slightly non-trivial merge in virtio-net, as we cleaned up
  the virtio add_buf interface while DaveM accepted the mq virtio-net
  patches."

* tag 'virtio-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux: (27 commits)
  virtio_console: Add support for remoteproc serial
  virtio_console: Merge struct buffer_token into struct port_buffer
  virtio: add drv_to_virtio to make code clearly
  virtio: use dev_to_virtio wrapper in virtio
  virtio-mmio: Fix irq parsing in command line parameter
  virtio_console: Free buffers from out-queue upon close
  virtio: Convert dev_printk(KERN_ to dev_(
  virtio_console: Use kmalloc instead of kzalloc
  virtio_console: Free buffer if splice fails
  virtio: tools: make it clear that virtqueue_add_buf() no longer returns > 0
  virtio: scsi: make it clear that virtqueue_add_buf() no longer returns > 0
  virtio: rpmsg: make it clear that virtqueue_add_buf() no longer returns > 0
  virtio: net: make it clear that virtqueue_add_buf() no longer returns > 0
  virtio: console: make it clear that virtqueue_add_buf() no longer returns > 0
  virtio: make virtqueue_add_buf() returning 0 on success, not capacity.
  virtio: console: don't rely on virtqueue_add_buf() returning capacity.
  virtio_net: don't rely on virtqueue_add_buf() returning capacity.
  virtio-net: remove unused skb_vnet_hdr->num_sg field
  virtio-net: correct capacity math on ring full
  virtio: move queue_index and num_free fields into core struct virtqueue.
  ...

virtio: add drv_to_virtio to make code clearly

2012-12-18T04:50:43+00:00

Add drv_to_virtio wrapper to get virtio_driver from device_driver.

Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Signed-off-by: Wanlong Gao 
Signed-off-by: Rusty Russell

virtio: use dev_to_virtio wrapper in virtio

2012-12-18T04:50:42+00:00

Use dev_to_virtio wrapper in virtio to make code clearly.

Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Signed-off-by: Wanlong Gao 
Signed-off-by: Rusty Russell

virtio: Don't access index after unregister.

2012-11-09T04:24:24+00:00

Virtio wants to release used indices after the corresponding
virtio device has been unregistered. However, virtio does not
hold an extra reference, giving up its last reference with
device_unregister(), making accessing dev->index afterwards
invalid.

I actually saw problems when testing my (not-yet-merged)
virtio-ccw code:

- device_add virtio-net,id=xxx
-> creates device virtio with n>0

- device_del xxx
-> deletes virtio, but calls ida_simple_remove with an
   index of 0

- device_add virtio-net,id=xxx
-> tries to add virtio0, which is still in use...

So let's save the index we want to release before calling
device_unregister().

Signed-off-by: Cornelia Huck 
Acked-by: Sjur Brændeland 
Cc: stable@kernel.org
Signed-off-by: Rusty Russell

virtio: don't crash when device is buggy

2012-09-28T05:35:16+00:00

Because of a sanity check in virtio_dev_remove, a buggy device can crash
kernel.  And in case of rproc it's userspace so it's not a good idea.
We are unloading a driver so how bad can it be?
Be less aggressive in handling this error: if it's a driver bug,
warning once should be enough.

Signed-off-by: Michael S. Tsirkin 
Signed-off-by: Rusty Russell