linux-stable.git/drivers/video/fbdev/ssd1307fb.c, branch linux-5.2.y

video: ssd1307fb: Start page range at page_offset

2019-10-07T16:58:32+00:00

[ Upstream commit dd9782834dd9dde3624ff1acea8859f3d3e792d4 ]

The page_offset was only applied to the end of the page range. This caused
the display updates to cause a scrolling effect on the display because the
amount of data written to the display did not match the range display
expected.

Fixes: 301bc0675b67 ("video: ssd1307fb: Make use of horizontal addressing mode")
Signed-off-by: Marko Kohtala 
Cc: Mark Rutland 
Cc: Rob Herring 
Cc: Daniel Vetter 
Cc: David Airlie 
Cc: Michal Vokáč 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Link: https://patchwork.freedesktop.org/patch/msgid/20190618074111.9309-4-marko.kohtala@okoko.fi
Signed-off-by: Sasha Levin

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 71

2019-05-24T15:36:47+00:00

Based on 1 normalized pattern(s):

  licensed under the gplv2 or later

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 5 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Richard Fontana 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190520071859.659568621@linutronix.de
Signed-off-by: Greg Kroah-Hartman

video: ssd1307fb: Do not hard code active-low reset sequence

2019-02-08T18:24:48+00:00

The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.

Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.

Reviewed-by: Rob Herring 
Reviewed-by: Alexandre Belloni 
Cc: Shawn Guo 
Cc: Fabio Estevam 
Cc: Maxime Ripard ,
Signed-off-by: Michal Vokáč 
Signed-off-by: Bartlomiej Zolnierkiewicz

Revert "video: ssd1307fb: Do not hard code active-low reset sequence"

2018-10-09T13:18:42+00:00

This reverts commit 9827f26374fb85e1811f2adbcc25c8a3992dbe7f.

On 10/09/2018 02:20 AM, Shawn Guo wrote:

> Well, it means the change breaks the ABI between kernel and device tree,
> e.g. the new kernel will not work with existing/installed DTBs.

Revert the change until DTB compatibility issue is resolved.

Signed-off-by: Bartlomiej Zolnierkiewicz

video: ssd1307fb: Do not hard code active-low reset sequence

2018-10-08T10:57:37+00:00

The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.

Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.

Signed-off-by: Michal Vokáč 
Cc: Shawn Guo 
Cc: Rob Herring 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ssd1307fb: Use gpiod_set_value_cansleep() for reset

2018-10-08T10:57:36+00:00

The reset signal can be produced by GPIO expander that can sleep.
In that case the probe function fails. Allow using GPIO expanders for
the reset signal by using the non-atomic gpiod_set_value_cansleep()
function.

Signed-off-by: Michal Vokáč 
Reviewed-by: Fabio Estevam 
Cc: Shawn Guo 
Cc: Rob Herring 
Signed-off-by: Bartlomiej Zolnierkiewicz

video: ssd1307fb: Improve a size determination in ssd1307fb_probe()

2018-03-28T14:34:28+00:00

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Cc: Arnd Bergmann 
Cc: Bastian Stender 
Cc: Jyri Sarha 
Cc: Tomi Valkeinen 
Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev/ssd1307fb: fix optional VBAT support

2017-04-07T15:28:23+00:00

SSD1306 needs VBAT when it is wired in charge pump configuration only.
Other controllers of the SSD1307 family do not need it at all. This was
introduced by commit ba14301e0356 ("fbdev/ssd1307fb: add support to
enable VBAT").

Without VBAT configuration the driver now fails with:

	failed to get VBAT regulator: -19

This is caused by misinterpretation of devm_regulator_get_optional
which "returns a struct regulator corresponding to the regulator
producer or IS_ERR() condition".

Handle -ENODEV without bailing out and making VBAT support really
optional.

Signed-off-by: Bastian Stender 
Cc: Tomi Valkeinen 
Cc: Jyri Sarha 
Cc: Roger Quadros 
[b.zolnierkie: minor fixups]
Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev: ssd1307fb: include linux/gpio/consumer.h

2017-02-20T12:51:07+00:00

Changing this driver to the gpiod API requires the use of the
new-style header, depending on the configuration:

drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe':
drivers/video/fbdev/ssd1307fb.c:569:15: error: implicit declaration of function 'devm_gpiod_get_optional';did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
drivers/video/fbdev/ssd1307fb.c:570:11: error: 'GPIOD_OUT_LOW' undeclared (first use in this function)

Fixes: 72db33355c14 ("fbdev: ssd1307fb: Start to use gpiod API for reset gpio")
Cc: Tomi Valkeinen 
Cc: Jyri Sarha 
Cc: LABBE Corentin 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev/ssd1307fb: clear screen in probe

2017-02-08T15:44:00+00:00

SSD1306 does not clear the panel's framebuffer automatically, even if a
HW reset happens, so we need to do that at probe time before enabling
the panel.

Cc: Rob Herring 
Cc: Maxime Ripard 
Cc: Benoît Cousson 
Signed-off-by: Tomi Valkeinen 
Signed-off-by: Jyri Sarha 
Signed-off-by: Bartlomiej Zolnierkiewicz