linux-stable.git/drivers/video/fbdev/sis, branch v6.0

fbdev: Move fbdev drivers from strlcpy to strscpy

2022-08-24T20:06:15+00:00

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang 
Signed-off-by: Helge Deller

fbdev: sisfb: Clean up some inconsistent indenting

2022-08-24T19:47:08+00:00

No functional modification involved.

drivers/video/fbdev/sis/sis_main.c:6165 sisfb_probe() warn: inconsistent indenting.
drivers/video/fbdev/sis/sis_main.c:4266 sisfb_post_300_rwtest() warn: inconsistent indenting.
drivers/video/fbdev/sis/sis_main.c:2388 SISDoSense() warn: inconsistent indenting.
drivers/video/fbdev/sis/sis_main.c:2531 SiS_Sense30x() warn: inconsistent indenting.
drivers/video/fbdev/sis/sis_main.c:2382 SISDoSense() warn: inconsistent indenting.
drivers/video/fbdev/sis/sis_main.c:2250 sisfb_sense_crt1() warn: inconsistent indenting.
drivers/video/fbdev/sis/sis_main.c:672 sisfb_validate_mode() warn: inconsistent indenting.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1934
Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Signed-off-by: Helge Deller

video: fbdev: sis: fix typos in SiS_GetModeID()

2022-07-26T07:16:38+00:00

The second operand of a '&&' operator has no impact on expression
result for cases 400 and 512 in SiS_GetModeID().

Judging by the logic and the names of the variables, in both cases a
typo was made.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Rustam Subkhankulov 
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Helge Deller

video: fbdev: sis: fix potential NULL dereference in sisfb_post_sis300()

2022-04-04T06:55:23+00:00

Do no access bios[] if it's NULL.

Signed-off-by: Haowen Bai 
Signed-off-by: Helge Deller

video: fbdev: sis: use swap() to make code cleaner

2022-01-29T21:24:25+00:00

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot 
Signed-off-by: David Yang 
Signed-off-by: Yang Guang 
Signed-off-by: Helge Deller

video: fbdev: sis: Drop useless call to SiS_GetResInfo()

2020-12-08T17:36:52+00:00

Coverity reported:

    Useless call (USELESS_CALL) side_effect_free: Calling
     SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its
    return value, which is ignored.

And this is correct - so drop the call.

Signed-off-by: Sam Ravnborg 
Reported-by: Colin Ian King 
Addresses-Coverity: ("Useless call")
Acked-by: Thomas Zimmermann 
Cc: Colin Ian King 
Cc: Thomas Winischhofer 
Link: https://patchwork.freedesktop.org/patch/msgid/20201206190247.1861316-14-sam@ravnborg.org

video: fbdev: sis: Fix set but not used warnings in sis_main

2020-11-30T19:04:17+00:00

Fix warnings by dropping unused variable and the
unused assignments.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Cc: Thomas Winischhofer 
Cc: Lee Jones 
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-11-sam@ravnborg.org

video: fbdev: sis: Fix set but not used warnings in init.c

2020-11-30T19:04:08+00:00

Fix "set but not used" warnings by removing the code the assign the
variables and the definition of the variables.
A register read is kept as it may have unknown side-effects.

This removes a lot of unused code - which is always a good thing to do.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Cc: Thomas Winischhofer 
Cc: Lee Jones 
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-10-sam@ravnborg.org

video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay

2020-11-30T19:02:50+00:00

Fix W=1 warning by commenting unused SiS_TVDelay* variables.

The SiS_TVDelay* variables seem to contain some magic numbers
so looks like data worth keeping around but not as code we build.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Cc: Thomas Winischhofer 
Cc: Lee Jones 
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-9-sam@ravnborg.org

video: fbdev: sis: Fix defined but not used warnings

2020-11-30T18:29:40+00:00

init.h defines static symbols, so it should only be included
once. Drop the include from sis.h as it is not needed.
This fixes a lot of warnings seen with a W=1 build.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Cc: Thomas Winischhofer 
Cc: Lee Jones 
Link: https://patchwork.freedesktop.org/patch/msgid/20201128224114.1033617-8-sam@ravnborg.org