linux-stable.git/drivers/video/backlight, branch linux-4.5.y

backlight: pwm_bl: Free PWM requested by legacy API on error path

2016-01-11T10:45:24+00:00

If pwm is requested by legacy pwm_request() and if the following
backlight_device_register() call fails, add pwm_free() clean-up.

Signed-off-by: Vladimir Zapolskiy 
Signed-off-by: Lee Jones

backlight: adp8860: Fix another uninitialized variable use

2016-01-11T07:58:43+00:00

A recent patch I did fixed two potential uses of uninitialized
variables in the adp8870 and adp8860 drivers. Unfortunately,
I missed another one:

drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show':
drivers/video/backlight/adp8860_bl.c:570:11: warning: 'reg_val' may be used uninitialized in this function

This does the same change as before in one additional function,
and also changes the check for the return value in a way that
avoids another false positive warning with a similar message.

Signed-off-by: Arnd Bergmann 
Fixes: 6be3a5a9cd91 ("backlight: adp88x0: Fix uninitialized variable use")
Acked-by: Michael Hennerich 
Acked-by: Jingoo Han 
Signed-off-by: Lee Jones

backlight: gpio-backlight: Use default-on on GPIO request

2016-01-11T07:58:35+00:00

There are situations where the backlight should be on at boot time
(e.g. if the boot loader already turned the display on). The DT
bindings specify the "default-on" property for that purpose.
Currently, the initial state of the GPIO at request time is always
set to logical off (high or low depending on whether it is an
active high or low GPIO). Since the GPIO is requested as an output,
the GPIO will be driven low for a short period of time, which leads
to a flickering display in the above use-case.

Initialize the GPIO depending on the default-on property to be
logical on or off.

Signed-off-by: Stefan Agner 
Signed-off-by: Lee Jones

backlight: pwm_bl: Fix broken PWM backlight for non-dt platforms

2016-01-11T06:36:43+00:00

Commit ee65ad0e2a9e ("backlight: pwm_bl: Avoid backlight flicker when
probed from DT") tries to dereference the device of_node pointer
unconditionally, causing a NULL pointer dereference on non-dt platforms.
Fix it by replacing the phandle variable with a node variable and
by checking that for NULL before dereferencing it.

Reported-by: Robert Jarzmik 
Signed-off-by: Philipp Zabel 
Acked-by: Thierry Reding 
Tested-by: Robert Jarzmik 
Signed-off-by: Lee Jones

backlight: tps65217_bl: Add MODULE_DEVICE_TABLE

2016-01-11T06:36:35+00:00

The device table is required to load modules based on modaliases.

Signed-off-by: Enric Balletbo i Serra 
Signed-off-by: Lee Jones

backlight: pwm_bl: Avoid backlight flicker when probed from DT

2016-01-11T05:56:22+00:00

If the driver is probed from the device tree, and there is a phandle
property set on it, and the enable GPIO is already configured as output,
and the backlight is currently disabled, keep it disabled.
If all these conditions are met, assume there will be some other driver
that can enable the backlight at the appropriate time.

Signed-off-by: Philipp Zabel 
Reviewed-by: Christian Gmeiner 
Tested-by: Heiko Stuebner 
Signed-off-by: Lee Jones

backlight: adp88x0: Fix uninitialized variable use

2016-01-11T05:56:12+00:00

gcc correctly warns about both the adp8860 and adp8870 backlight
drivers using an uninitialized variable in their error handling
path:

drivers/video/backlight/adp8870_bl.c: In function 'adp8870_bl_ambient_light_zone_store':
drivers/video/backlight/adp8870_bl.c:811:11: warning: 'reg_val' may be used uninitialized in this function

This changes the code to only write back the data if it was
correctly read to start with.

As a side-note, the drivers are mostly identical, so I think they
should really be merged into one file to avoid having to fix every
bug twice.

Signed-off-by: Arnd Bergmann 
Acked-by: Michael Hennerich 
Signed-off-by: Lee Jones

Merge tag 'backlight-for-linus-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight

2015-11-06T18:53:48+00:00

Pull backlight updates from Lee Jones:
 "New Device Support
   - None

  New Functionality:
   - None

  Core Frameworks:
   - Reject legacy PWM request for device defined in DT

  Fix-ups:
   - Remove unnecessary MODULE_ALIAS(); adp8860_bl, adp8870_bl
   - Simplify code: pm8941-wled
   - Supply default-brightness logic; pm8941-wled

  Bug Fixes:
   - Clean up OF node; 88pm860x_bl
   - Ensure struct is zeroed; lp855x_bl"

* tag 'backlight-for-linus-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight:
  backlight: pm8941-wled: Add default-brightness property
  backlight: pm8941-wled: Fix ptr_ret.cocci warnings
  backlight: pwm: Reject legacy PWM request for device defined in DT
  backlight: 88pm860x_bl: Add missing of_node_put
  backlight: adp8870: Remove unnecessary MODULE_ALIAS()
  backlight: adp8860: Remove unnecessary MODULE_ALIAS()
  backlight: lp855x: Make sure props struct is zeroed

backlight: pm8941-wled: Add default-brightness property

2015-10-30T18:47:51+00:00

Default the brightness to 2048 and add possibility to override this in
device tree.

Suggested-by: Rob Clark 
Signed-off-by: Bjorn Andersson 
Acked-by: Rob Herring 
Signed-off-by: Lee Jones

spi: Drop owner assignment from spi_drivers

2015-10-28T01:30:17+00:00

An spi_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Andrew F. Davis 
Acked-by: Jonathan Cameron 
Signed-off-by: Mark Brown