linux-stable.git/drivers/vfio, branch v5.10.7

vfio/pci/nvlink2: Do not attempt NPU2 setup on POWER8NVL NPU

2020-12-30T10:54:03+00:00

commit d22f9a6c92de96304c81792942ae7c306f08ac77 upstream.

We execute certain NPU2 setup code (such as mapping an LPID to a device
in NPU2) unconditionally if an Nvlink bridge is detected. However this
cannot succeed on POWER8NVL machines as the init helpers return an error
other than ENODEV which means the device is there is and setup failed so
vfio_pci_enable() fails and pass through is not possible.

This changes the two NPU2 related init helpers to return -ENODEV if
there is no "memory-region" device tree property as this is
the distinction between NPU and NPU2.

Tested on
- POWER9 pvr=004e1201, Ubuntu 19.04 host, Ubuntu 18.04 vm,
  NVIDIA GV100 10de:1db1 driver 418.39
- POWER8 pvr=004c0100, RHEL 7.6 host, Ubuntu 16.10 vm,
  NVIDIA P100 10de:15f9 driver 396.47

Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver")
Cc: stable@vger.kernel.org # 5.0
Signed-off-by: Alexey Kardashevskiy 
Signed-off-by: Alex Williamson 
Signed-off-by: Greg Kroah-Hartman

vfio/pci: Move dummy_resources_list init in vfio_pci_probe()

2020-12-30T10:54:03+00:00

commit 16b8fe4caf499ae8e12d2ab1b1324497e36a7b83 upstream.

In case an error occurs in vfio_pci_enable() before the call to
vfio_pci_probe_mmaps(), vfio_pci_disable() will  try to iterate
on an uninitialized list and cause a kernel panic.

Lets move to the initialization to vfio_pci_probe() to fix the
issue.

Signed-off-by: Eric Auger 
Fixes: 05f0c03fbac1 ("vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive")
CC: Stable  # v4.7+
Signed-off-by: Alex Williamson 
Signed-off-by: Greg Kroah-Hartman

vfio-pci: Use io_remap_pfn_range() for PCI IO memory

2020-12-30T10:53:31+00:00

[ Upstream commit 7b06a56d468b756ad6bb43ac21b11e474ebc54a0 ]

commit f8f6ae5d077a ("mm: always have io_remap_pfn_range() set
pgprot_decrypted()") allows drivers using mmap to put PCI memory mapped
BAR space into userspace to work correctly on AMD SME systems that default
to all memory encrypted.

Since vfio_pci_mmap_fault() is working with PCI memory mapped BAR space it
should be calling io_remap_pfn_range() otherwise it will not work on SME
systems.

Fixes: 11c4cd07ba11 ("vfio-pci: Fault mmaps to enable vma tracking")
Signed-off-by: Jason Gunthorpe 
Acked-by: Peter Xu 
Tested-by: Tom Lendacky 
Signed-off-by: Alex Williamson 
Signed-off-by: Sasha Levin

vfio/pci: Bypass IGD init in case of -ENODEV

2020-11-03T18:07:40+00:00

Bypass the IGD initialization when -ENODEV returns,
that should be the case if opregion is not available for IGD
or within discrete graphics device's option ROM,
or host/lpc bridge is not found.

Then use of -ENODEV here means no special device resources found
which needs special care for VFIO, but we still allow other normal
device resource access.

Cc: Zhenyu Wang 
Cc: Xiong Zhang 
Cc: Hang Yuan 
Cc: Stuart Summers 
Signed-off-by: Fred Gao 
Signed-off-by: Alex Williamson

vfio: platform: fix reference leak in vfio_platform_open

2020-11-03T18:07:40+00:00

pm_runtime_get_sync() will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put will result in
reference leak in vfio_platform_open, so we should fix it.

Signed-off-by: Zhang Qilong 
Acked-by: Eric Auger 
Signed-off-by: Alex Williamson

vfio/pci: Implement ioeventfd thread handler for contended memory lock

2020-11-03T18:07:40+00:00

The ioeventfd is called under spinlock with interrupts disabled,
therefore if the memory lock is contended defer code that might
sleep to a thread context.

Fixes: bc93b9ae0151 ("vfio-pci: Avoid recursive read-lock usage")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=209253#c1
Reported-by: Ian Pilcher 
Tested-by: Ian Pilcher 
Tested-by: Justin Gatzen 
Signed-off-by: Alex Williamson

vfio/fsl-mc: Make vfio_fsl_mc_irqs_allocate static

2020-11-03T18:07:40+00:00

Fixed compiler warning:
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:16:5: warning: no previous
prototype for function 'vfio_fsl_mc_irqs_allocate' [-Wmissing-prototypes]
       ^
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:16:1: note: declare 'static'
if the function is not intended to be used outside of this translation unit
int vfio_fsl_mc_irqs_allocate(struct vfio_fsl_mc_device *vdev)

Reported-by: kernel test robot 
Signed-off-by: Diana Craciun 
Signed-off-by: Alex Williamson

vfio/fsl-mc: prevent underflow in vfio_fsl_mc_mmap()

2020-11-03T18:07:19+00:00

My static analsysis tool complains that the "index" can be negative.
There are some checks in do_mmap() which try to prevent underflows but
I don't know if they are sufficient for this situation.  Either way,
making "index" unsigned is harmless so let's do it just to be safe.

Fixes: 67247289688d ("vfio/fsl-mc: Allow userspace to MMAP fsl-mc device MMIO regions")
Signed-off-by: Dan Carpenter 
Acked-by: Diana Craciun 
Signed-off-by: Alex Williamson

vfio/fsl-mc: return -EFAULT if copy_to_user() fails

2020-11-02T22:00:06+00:00

The copy_to_user() function returns the number of bytes remaining to be
copied, but this code should return -EFAULT.

Fixes: df747bcd5b21 ("vfio/fsl-mc: Implement VFIO_DEVICE_GET_REGION_INFO ioctl call")
Signed-off-by: Dan Carpenter 
Acked-by: Diana Craciun 
Signed-off-by: Alex Williamson

vfio/type1: Use the new helper to find vfio_group

2020-11-02T21:58:29+00:00

When attaching a new group to the container, let's use the new helper
vfio_iommu_find_iommu_group() to check if it's already attached. There
is no functional change.

Also take this chance to add a missing blank line.

Signed-off-by: Zenghui Yu 
Signed-off-by: Alex Williamson