linux-stable.git/drivers/vfio/mdev/mdev_sysfs.c, branch linux-6.3.y

vfio/mdev: Use sysfs_emit() to instead of sprintf()

2023-01-30T19:16:13+00:00

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Bo Liu 
Reviewed-by: Jason Gunthorpe 
Link: https://lore.kernel.org/r/20230129084117.2384-1-liubo03@inspur.com
Signed-off-by: Alex Williamson

vfio/mdev: add mdev available instance checking to the core

2022-10-04T18:06:58+00:00

Many of the mdev drivers use a simple counter for keeping track of the
available instances. Move this code to the core code and store the counter
in the mdev_parent. Implement it using correct locking, fixing mdpy.

Drivers just provide the value in the mdev_driver at registration time
and the core code takes care of maintaining it and exposing the value in
sysfs.

[hch: count instances per-parent instead of per-type, use an atomic_t
 to avoid taking mdev_list_lock in the show method]

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-15-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the description sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just emits a string, simply add a method to the mdev_driver
to return it and provide a standard sysfs show function.

Remove the now unused types_attrs field in struct mdev_driver and the
support code for it.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Link: https://lore.kernel.org/r/20220923092652.100656-14-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the available_instance sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just print a number, simply add a method to the mdev_driver
to return it and provide a standard sysfs show function.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-13-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the name sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just emits a static string, simply add a field to the
mdev_type for the driver to fill out or fall back to the sysfs name and
provide a standard sysfs show function.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-12-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: consolidate all the device_api sysfs into the core code

2022-10-04T18:06:58+00:00

Every driver just emits a static string, simply feed it through the ops
and provide a standard sysfs show function.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-11-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: simplify mdev_type handling

2022-10-04T18:06:58+00:00

Instead of abusing struct attribute_group to control initialization of
struct mdev_type, just define the actual attributes in the mdev_driver,
allocate the mdev_type structures in the caller and pass them to
mdev_register_parent.

This allows the caller to use container_of to get at the containing
structure and thus significantly simplify the code.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-6-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: embedd struct mdev_parent in the parent data structure

2022-10-04T18:06:58+00:00

Simplify mdev_{un}register_device by requiring the caller to pass in
a structure allocate as part of the parent device structure.  This
removes the need for a list of parents and the separate mdev_parent
refcount as we can simplify rely on the reference to the parent device.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Reviewed-by: Eric Farman 
Link: https://lore.kernel.org/r/20220923092652.100656-5-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: make mdev.h standalone includable

2022-10-04T18:06:58+00:00

Include  and  so that users of this headers
don't need to do that and remove those includes that aren't needed
any more.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Eric Farman 
Reviewed-by: Jason Gunthorpe 
Reviewed-by: Tony Krowiak 
Reviewed-by: Kevin Tian 
Reviewed-by: Kirti Wankhede 
Link: https://lore.kernel.org/r/20220923092652.100656-4-hch@lst.de
Signed-off-by: Alex Williamson

vfio/mdev: Use the driver core to create the 'remove' file

2022-04-21T11:36:56+00:00

The device creator is supposed to use the dev.groups value to add sysfs
files before device_add is called, not call sysfs_create_files() after
device_add() returns. This creates a race with uevent delivery where the
extra attribute will not be visible.

This was being done because the groups had been co-opted by the mdev
driver, now that prior patches have moved the driver's groups to the
struct device_driver the dev.group is properly free for use here.

Signed-off-by: Jason Gunthorpe 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Zhi Wang 
Link: http://patchwork.freedesktop.org/patch/msgid/20220411141403.86980-34-hch@lst.de
Reviewed-by: Kirti Wankhede 
Reviewed-by: Zhi Wang