linux-stable.git/drivers/usb/usbip, branch v4.7

usbip: rate limit get_frame_number message

2016-06-18T01:00:46+00:00

It's annoying to constantly see the same "Not yet implemented" message
over and over with nothing able to be done about it, so rate limit it
for now to keep user's logs "clean".

Reported-by: Lars Täuber 
Tested-by: Lars Täuber 
Signed-off-by: Greg Kroah-Hartman

usb: usbip: Avoid NULL pointer dereference in case of error

2016-04-29T22:31:30+00:00

One line above we have checked that udc is NULL so we shouldn't
dereference it while printing error message.

Reported-by: Dan Carpenter 
Signed-off-by: Krzysztof Opasiak 
Signed-off-by: Greg Kroah-Hartman

usbip: vudc: make dev_desc attribute binary

2016-04-29T22:31:30+00:00

We read a struct usb_device_descriptor from it, so make it an actual
binary attribute.

Signed-off-by: Igor Kotrasinski 
Signed-off-by: Krzysztof Opasiak 
Tested-by: Krzysztof Opasiak 
Signed-off-by: Greg Kroah-Hartman

usbip: vudc: fix Kconfig dependencies

2016-04-28T19:28:08+00:00

With the addition of VUDC, the USBIP stack can now be used on
configurations without USB host support, but trying to build
it with USB gadget support disabled fails with

drivers/usb/built-in.o: In function `vep_dequeue':
vudc_main.c:(.text+0xa6ddc): undefined reference to `usb_gadget_giveback_request'
drivers/usb/built-in.o: In function `nuke':
vudc_main.c:(.text+0xa6ea8): undefined reference to `usb_gadget_giveback_request'
drivers/usb/built-in.o: In function `vudc_device_reset':
vudc_main.c:(.text+0xa720c): undefined reference to `usb_gadget_udc_reset'
drivers/usb/built-in.o: In function `vudc_probe':

This addresses both issues, by changing the dependency for USBIP_CORE
to USB_COMMON, and adding additional dependencies on USB or USB_GADGET
for the individual portions as needed.

Signed-off-by: Arnd Bergmann 
Fixes: 9360575c5837 ("usbip: vudc: Add vudc to Kconfig")
Signed-off-by: Greg Kroah-Hartman

usbip: safe completion against unbind operation

2016-04-28T19:28:08+00:00

This patch adds a code fragment to ignore completing URBs in closing
connection.

Regarding this patch, 2 execution contexts are related.

1) stub_tx.c: stub_complete() which is called from USB core
1-1) add to unlink list and free URB or
1-2) move to tx list

2) stub_dev.c: stub_shutdown_connection() which is invoked by unbind
operation through sysfs.
2-1) stop TX/RX threads
2-2) close TCP connection and set ud.tcp_socket to NULL
2-3) cleanup pending URBs by stub_device_cleanup_urbs(sdev)
2-4) free unlink list (no lock)

In the race condition, URBs which will be cleared in 2-3) may be
handled in 1).
In case 1-1), it will not be transferred bcause tx threads are stooped
in 2-1).
In case 1-2), may be freed in 2-4).

With this patch, after 2-2), completing URBs in 1) will not be handled
and cleared in 2-3).

The kernel log with this patch is as below.

kernel: usbip_core: usbip_kernel_unlink:792: shutting down tcp_socket
ef61d980
kernel: usbip-host 1-3: free sdev f5df6180
kernel: usbip-host 1-3: free urb f5df6700
kernel: usbip-host 1-3: Enter
kernel: usbip_core: usbip_stop_eh:132: usbip_eh waiting completion 5
kernel: usbip_host: stub_complete:71: complete! status 0
kernel: usbip_host: stub_complete:102: ignore urb for closed connection
e725fc00 (*)
kernel: usbip_host: stub_complete:71: complete! status -2
kernel: usbip-host 1-3: stopped by a call to usb_kill_urb() because of
cleaning up a virtual connection
kernel: usbip-host 1-3: free urb e725fc00 (**)
kernel: usbip-host 1-3: free urb e725e000
kernel: usbip_host: stub_complete:71: complete! status -2
kernel: usbip-host 1-3: stopped by a call to usb_kill_urb() because of
cleaning up a virtual connection
kernel: usbip-host 1-3: free urb e725f800
kernel: usbip_host: stub_complete:71: complete! status -2
kernel: usbip-host 1-3: stopped by a call to usb_kill_urb() because of
cleaning up a virtual connection
kernel: usbip-host 1-3: free urb e725e800
kernel: usbip_host: stub_complete:71: complete! status -2
kernel: usbip-host 1-3: stopped by a call to usb_kill_urb() because of
cleaning up a virtual connection
kernel: usbip-host 1-3: device reset
kernel: usbip-host 1-3: lock for reset
kernel: usbip_host: store_match_busid:178: del busid 1-3
kernel: uvcvideo: Found UVC 1.00 device Venus USB2.0 Camera (056e:700a)
kernel: input: Venus USB2.0 Camera as
/devices/pci0000:00/0000:00:1a.7/usb1/1-3/1-3:1.0/input/input22

(*) skipped with this patch in completion
(**) released in 2-3

Signed-off-by: Greg Kroah-Hartman

usb: usbip: vudc: Rename find_endpoint() to vudc_find_endpoint()

2016-04-28T19:28:08+00:00

As find_endpoint() is a global funcion rename it to vudc_find_endpoint()
to clearly mark where does it come from.

Signed-off-by: Krzysztof Opasiak 
Signed-off-by: Greg Kroah-Hartman

usbip: fix NULL pointer dereference on errors

2016-04-28T19:28:08+00:00

Fix NULL pointer dereference and obsolete comments forgotten when
usbip server was converted from an interface driver to a device driver.

Signed-off-by: Alexander Popov 
Signed-off-by: Greg Kroah-Hartman

usb: usbip: vudc: Fix WARN_ON() usage pattern

2016-04-28T19:28:08+00:00

Fix WARN_ON() macro usage as suggested by Felipe.
Instead of using:
if (cond) {
   WARN_ON(1);
   do_stuff();
}

Use a better pattern with WARN_ON() placed in if condition:

if (WARN_ON(cond))
   do_stuff();

Signed-off-by: Krzysztof Opasiak 
Signed-off-by: Greg Kroah-Hartman

usbip: vudc: Add vudc to Kconfig

2016-04-26T22:19:50+00:00

Add the driver to Kconfig to make it visible in menuconfig
and allow people to compile it.

This commit is a result of cooperation between Samsung R&D Institute
Poland and Open Operating Systems Student Society at University
of Warsaw (O2S3@UW) consisting of:

    Igor Kotrasinski 
    Karol Kosik 
    Ewelina Kosmider <3w3lfin@gmail.com>
    Dawid Lazarczyk 
    Piotr Szulc 

Tutor and project owner:
    Krzysztof Opasiak 

Signed-off-by: Igor Kotrasinski 
Signed-off-by: Krzysztof Opasiak 
Signed-off-by: Greg Kroah-Hartman

usbip: vudc: Add SysFS infrastructure for VUDC

2016-04-26T22:19:50+00:00

Add sysfs attributes to allow controlling vudc from usbip tools.

dev_desc - device descriptor of current gadget. This is required to
	 be consisten with current usbip protocol and allow to list
	 exportable devices on given machine.

usbip_sockfd - allows to pass socket to kernel to start usbip transfer.

usbip_status - currnent status of device

This commit is a result of cooperation between Samsung R&D Institute
Poland and Open Operating Systems Student Society at University
of Warsaw (O2S3@UW) consisting of:

    Igor Kotrasinski 
    Karol Kosik 
    Ewelina Kosmider <3w3lfin@gmail.com>
    Dawid Lazarczyk 
    Piotr Szulc 

Tutor and project owner:
    Krzysztof Opasiak 

Signed-off-by: Igor Kotrasinski 
Signed-off-by: Karol Kosik 
[Various bug fixes, improvements and commit msg update]
Signed-off-by: Krzysztof Opasiak 
Signed-off-by: Greg Kroah-Hartman