linux-stable.git/drivers/usb/storage, branch v3.16.2

uas: Limit qdepth to 32 when connected over usb-2

2014-09-05T23:36:24+00:00

commit e2875c33787ebda21aeecc1a9d3ff52b3aa413ec upstream.

Some jmicron uas chipsets act up (they disconnect from the bus) when sending
more then 32 commands to them at once.

Rather then building an ever growing list with usb-id based quirks for
devices using this chipset, simply reduce the qdepth to 32 when connected
over usb-2. 32 should be plenty to keep things close to maximum
possible throughput on usb-2.

Tested-and-reported-by: Laszlo T. 
Signed-off-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

usb-storage/SCSI: Add broken_fua blacklist flag

2014-07-01T05:47:18+00:00

Some buggy JMicron USB-ATA bridges don't know how to translate the FUA
bit in READs or WRITEs.  This patch adds an entry in unusual_devs.h
and a blacklist flag to tell the sd driver not to use FUA.

Signed-off-by: Alan Stern 
Reported-by: Michael Büsch 
Tested-by: Michael Büsch 
Acked-by: James Bottomley 
CC: Matthew Dharm 
CC: 
Signed-off-by: Greg Kroah-Hartman

USB: storage: ene_ub6250: Use kmemdup instead of kmalloc + memcpy

2014-05-27T23:23:44+00:00

This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci

Signed-off-by: Benoit Taine 
Signed-off-by: Greg Kroah-Hartman

USB: Nokia 5300 should be treated as unusual dev

2014-05-03T23:41:07+00:00

Signed-off-by: Daniele Forsi 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: Nokia 305 should be treated as unusual dev

2014-05-03T23:41:07+00:00

Signed-off-by: Victor A. Santos 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

usb: storage: shuttle_usbat: fix discs being detected twice

2014-05-03T22:04:28+00:00

Even if the USB-to-ATAPI converter supported multiple LUNs, this
driver would always detect the same physical device or media because
it doesn't use srb->device->lun in any way.
Tested with an Hewlett-Packard CD-Writer Plus 8200e.

Signed-off-by: Daniele Forsi 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

uas: fix deadlocky memory allocations

2014-04-16T21:04:59+00:00

There are also two allocations with GFP_KERNEL in the pre-/post_reset
code paths. That is no good because that is a part of the SCSI error handler.

Signed-off-by: Oliver Neukum 
Reviewed-by: Hans de Goede 
Acked-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

uas: fix error handling during scsi_scan()

2014-04-16T21:04:59+00:00

intfdata is set only after scsi_scan(). uas_pre_reset() however
needs intfdata to be valid and will follow the NULL pointer
killing khubd. intfdata must be preemptively set before the
host is registered and undone in the error case.

Signed-off-by: Oliver Neukum 
Reviewed-by: Hans de Goede 
Acked-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

uas: fix GFP_NOIO under spinlock

2014-04-16T21:04:59+00:00

Quote Dan:

The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
where possible" from Nov 7, 2013, leads to the following static
checker warning:

        drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
        error: scheduling with locks held: 'spin_lock:lock'

Some other allocations under spinlock are not caught.
The fix essentially reverts e36e64930cffd94e1c37fdb82f35989384aa946b

Signed-off-by: Oliver Neukum 
Reported-by: Dan Carpenter 
Reviewed-by: Hans de Goede 
Acked-by: Hans de Goede 
Signed-off-by: Greg Kroah-Hartman

storage: accept some UAS devices if streams are unavailable

2014-03-04T23:41:09+00:00

On some older XHCIs streams are not supported and the UAS driver
will fail at probe time. For those devices storage should try
to bind to UAS devices.
This patch adds a flag for stream support to HCDs and evaluates
it.

[Note: Sarah fixed a bug where the USB 2.0 root hub, not USB 3.0 root
hub would get marked as being able to support streams.]

Signed-off-by: Oliver Neukum 
Signed-off-by: Sarah Sharp 
Acked-by: Hans de Goede