linux-stable.git/drivers/usb/storage/usb.c, branch linux-3.7.y

USB: storage: Define a new macro for USB storage match rules

2013-02-11T17:04:45+00:00

commit 07c7be3d87e5cdaf5f94c271c516456364ef286c upstream.

1. Define a new macro for USB storage match rules:
    matching with Vendor ID and interface descriptors.

Signed-off-by: fangxiaozhi 
Signed-off-by: Greg Kroah-Hartman

usb: remove libusual

2012-09-06T00:21:36+00:00

The "Low Performance USB Block driver" has been removed which a user of
libusual. Now we have only the usb-storage driver as the only driver in
tree. This makes libusual needless.
This patch removes libusal, fixes up all users. The usual-table is now
linked into usb-storage.
usb_usual.h remains in public include directory because some staging
users seem to need it.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Greg Kroah-Hartman

[SCSI] usb-storage: add support for write cache quirk

2012-07-20T07:59:00+00:00

Add support for write cache quirk on usb hdd. scsi driver will be set to wce
by detecting write cache quirk in quirk list when plugging usb hdd.

Signed-off-by: Namjae Jeon 
Signed-off-by: Pankaj Kumar 
Signed-off-by: Amit Sahrawat 
Acked-by: Alan Stern 
Signed-off-by: James Bottomley

USB: storage: fixed keyword related space issues.

2012-05-17T16:48:29+00:00

Fixed keyword related space issues found by
checkpatch.pl tool in drivers/usb/storage/usb.c

Signed-off-by: Jeffrin Jose 
Signed-off-by: Greg Kroah-Hartman

USB: storage: fixed several trailing white spaces issues.

2012-05-17T16:48:29+00:00

Fixed several trailing white spaces issues found
by checkpatch.pl tool in drivers/usb/storage/usb.c

Signed-off-by: Jeffrin Jose 
Signed-off-by: Greg Kroah-Hartman

USB: storage: fixed C99 comment issue.

2012-05-17T16:48:29+00:00

Fixed C99 comment issue in drivers/usb/storage/usb.c
found using checkpatch.pl tool.

Signed-off-by: Jeffrin Jose 
Signed-off-by: Greg Kroah-Hartman

usb: storage: fix lockdep warning inside usb_stor_pre_reset(v2)

2012-04-06T20:54:00+00:00

This patch fixes one lockdep warning[1] inside usb_stor_pre_reset.

If the current configuration includes multiple mass storage interfaces,
the 'AA' lockdep warning will be triggered since the lock class of
'us->dev_mutex' is acquired two times in .reset path. It isn't
a real deadlock, so just take the lockdep_set_class annotation to
remove the warning.

[1], lockdep warning log
:[ INFO: possible recursive locking detected ]
:3.3.0-0.rc5.git3.1.fc17.x86_64 #1 Tainted: G        W
:---------------------------------------------
:usb-storage/14846 is trying to acquire lock:
: (&(us->dev_mutex)){+.+.+.}, at: [] usb_stor_pre_reset+0x1c/0x20 [usb_storage]
:but task is already holding lock:
: (&(us->dev_mutex)){+.+.+.}, at: [] usb_stor_pre_reset+0x1c/0x20 [usb_storage]
:other info that might help us debug this:
: Possible unsafe locking scenario:
:       CPU0
:       ----
:  lock(&(us->dev_mutex));
:  lock(&(us->dev_mutex));
: *** DEADLOCK ***
: May be due to missing lock nesting notation
:2 locks held by usb-storage/14846:
: #0:  (&__lockdep_no_validate__){......}, at: [] usb_lock_device_for_reset+0x95/0x100
: #1:  (&(us->dev_mutex)){+.+.+.}, at: [] usb_stor_pre_reset+0x1c/0x20 [usb_storage]
:stack backtrace:
:Pid: 14846, comm: usb-storage Tainted: G        W 3.3.0-0.rc5.git3.1.fc17.x86_64 #1
:Call Trace:
: [] __lock_acquire+0x168f/0x1bb0
: [] ? native_sched_clock+0x13/0x80
: [] ? sched_clock+0x9/0x10
: [] ? sched_clock+0x9/0x10
: [] ? sched_clock_local+0x25/0xa0
: [] lock_acquire+0xa1/0x1e0
: [] ? usb_stor_pre_reset+0x1c/0x20 [usb_storage]
: [] mutex_lock_nested+0x76/0x3a0
: [] ? usb_stor_pre_reset+0x1c/0x20 [usb_storage]
: [] ? usb_stor_pre_reset+0x1c/0x20 [usb_storage]
: [] usb_stor_pre_reset+0x1c/0x20 [usb_storage]
: [] usb_reset_device+0x7d/0x190
: [] usb_stor_port_reset+0x7c/0x80 [usb_storage]
: [] usb_stor_invoke_transport+0x94/0x560 [usb_storage]
: [] ? mark_held_locks+0xb2/0x130
: [] ? _raw_spin_unlock_irq+0x30/0x50
: [] usb_stor_transparent_scsi_command+0xe/0x10 [usb_storage]
: [] usb_stor_control_thread+0x173/0x280 [usb_storage]
: [] ? fill_inquiry_response+0x20/0x20 [usb_storage]
: [] kthread+0xb7/0xc0
: [] kernel_thread_helper+0x4/0x10
: [] ? retint_restore_args+0x13/0x13
: [] ? kthread_worker_fn+0x1a0/0x1a0
: [] ? gs_change+0x13/0x13

Reported-By: Dave Jones 
Signed-off-by: Ming Lei 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'usb-3.3-rc4' into usb-next

2012-02-23T16:21:03+00:00

This is to pull in the xhci changes and the other fixes and device id
updates that were done in Linus's tree.

Signed-off-by: Greg Kroah-Hartman

usb-storage: fix freezing of the scanning thread

2012-02-22T00:29:15+00:00

This patch (as1521b) fixes the interaction between usb-storage's
scanning thread and the freezer.  The current implementation has a
race: If the device is unplugged shortly after being plugged in and
just as a system sleep begins, the scanning thread may get frozen
before the khubd task.  Khubd won't be able to freeze until the
disconnect processing is complete, and the disconnect processing can't
proceed until the scanning thread finishes, so the sleep transition
will fail.

The implementation in the 3.2 kernel suffers from an additional
problem.  There the scanning thread calls set_freezable_with_signal(),
and the signals sent by the freezer will mess up the thread's I/O
delays, which are all interruptible.

The solution to both problems is the same: Replace the kernel thread
used for scanning with a delayed-work routine on the system freezable
work queue.  Freezable work queues have the nice property that you can
cancel a work item even while the work queue is frozen, and no signals
are needed.

The 3.2 version of this patch solves the problem in Bugzilla #42730.

Signed-off-by: Alan Stern 
Acked-by: Seth Forshee 
CC: stable 
Signed-off-by: Greg Kroah-Hartman

usb: Re-enable usb-storage support dynamic id

2012-01-24T22:31:04+00:00

Enable usb-storage support dynamic id again by using a fixed id entry
that describes a device using the Bulk-Only transport with the
Transparent SCSI protocol.

Signed-off-by: Huajun Li 
Reviewed-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman