linux-stable.git/drivers/usb/serial/visor.c, branch linux-3.10.y

USB: visor: fix null-deref at probe

2016-02-19T22:22:40+00:00

commit cac9b50b0d75a1d50d6c056ff65c005f3224c8e0 upstream.

Fix null-pointer dereference at probe should a (malicious) Treo device
lack the expected endpoints.

Specifically, the Treo port-setup hack was dereferencing the bulk-in and
interrupt-in urbs without first making sure they had been allocated by
core.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: visor: fix crash on detecting device without write_urbs

2016-02-19T22:22:40+00:00

commit cb3232138e37129e88240a98a1d2aba2187ff57c upstream.

The visor driver crashes in clie_5_attach() when a specially crafted USB
device without bulk-out endpoint is detected. This fix adds a check that
the device has proper configuration expected by the driver.

Reported-by: Ralf Spenneberg 
Signed-off-by: Vladis Dronov 
Fixes: cfb8da8f69b8 ("USB: visor: fix initialisation of UX50/TH55 devices")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: visor: Match I330 phone more precisely

2015-06-06T06:19:56+00:00

commit 82ee3aeb9295c5fc37fd2ddf20f13ac2b40ec97d upstream.

Samsung has just released a portable USB3 SSD, coming in a very small
and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
already used by the Palm Visor driver for the Samsung I330 phone cradle.
Having pl2303 or visor pick up this device ID results in conflicts with
the usb-storage driver, which handles the newly released portable USB3
SSD.

To work around this conflict, I've dug up a mailing list post [1] from a
long time ago, in which a user posts the full USB descriptor
information. The most specific value in this appears to be the interface
class, which has value 255 (0xff). Since usb-storage requires an
interface class of 0x8, I believe it's correct to disambiguate the two
devices by matching on 0xff inside visor.

[1] http://permalink.gmane.org/gmane.linux.usb.user/4264

Signed-off-by: Jason A. Donenfeld 
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: visor: fix initialisation of Treo/Kyocera devices

2013-05-29T01:47:45+00:00

Fix regression introduced by commit 214916f2e ("USB: visor: reimplement
using generic framework") which broke initialisation of Treo/Kyocera
devices that re-mapped bulk-in endpoints.

Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: fix Treo/Kyocera interrrupt-in urb context

2013-05-29T01:47:45+00:00

The first and second interrupt-in urbs are swapped for some Treo/Kyocera
devices, but the urb context was never updated with the new port.

Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: visor: always disable uart on close

2013-03-25T20:54:32+00:00

Always try to disable the uart on close.

Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: Serial: visor.c: remove debug module parameter

2012-09-18T09:16:28+00:00

Now that all usb-serial modules are only using dev_dbg()
the debug module parameter does not do anything at all, so
remove it to reduce any confusion if someone were to try to
use it.

CC: Rusty Russell 
CC: Alan Stern 
CC: Mauro Carvalho Chehab 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove debug parameter from usb_serial_debug_data()

2012-09-18T08:58:57+00:00

We should use dev_dbg() for usb_serial_debug_data() like all of the rest
of the usb-serial drivers use, so remove the debug parameter as it's not
needed.

Signed-off-by: Greg Kroah-Hartman

USB: serial: rework usb_serial_register/deregister_drivers()

2012-05-08T22:46:14+00:00

This reworks the usb_serial_register_drivers() and
usb_serial_deregister_drivers() to not need a pointer to a struct
usb_driver anymore.  The usb_driver structure is now created dynamically
and registered and unregistered as needed.

This saves lines of code in each usb-serial driver.  All in-kernel users
of these functions were also fixed up at this time.  The pl2303 driver
was tested that everything worked properly.

Thanks for the idea to do this from Alan Stern.

Cc: Adhir Ramjiawan 
Cc: Alan Stern 
Cc: Al Borchers 
Cc: Aleksey Babahin 
Cc: Andrew Morton 
Cc: Andrew Worsley 
Cc: Bart Hartgers 
Cc: Bill Pemberton 
Cc: Dan Carpenter 
Cc: Dan Williams 
Cc: Donald Lee 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Gary Brubaker 
Cc: Jesper Juhl 
Cc: Jiri Kosina 
Cc: Johan Hovold 
Cc: Julia Lawall 
Cc: Kautuk Consul 
Cc: Kuninori Morimoto 
Cc: Lonnie Mendez 
Cc: Matthias Bruestle and Harald Welte 
Cc: Matthias Urlichs 
Cc: Mauro Carvalho Chehab 
Cc: Michal Sroczynski 
Cc: "Michał Wróbel" 
Cc: Oliver Neukum 
Cc: Paul Gortmaker 
Cc: Peter Berger 
Cc: Preston Fick 
Cc: "Rafael J. Wysocki" 
Cc: Rigbert Hamisch 
Cc: Rusty Russell 
Cc: Simon Arlott 
Cc: Support Department 
Cc: Thomas Tuttle 
Cc: Uwe Bonnes 
Cc: Wang YanQing 
Cc: William Greathouse 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove usb_serial_disconnect call in all drivers

2012-05-07T21:02:13+00:00

This is now set by the usb-serial core, no need for the driver to
individually set it.

Thanks to Alan Stern for the idea to get rid of it.

Cc: William Greathouse 
Cc: Matthias Bruestle and Harald Welte 
Cc: Lonnie Mendez 
Cc: Peter Berger 
Cc: Al Borchers 
Cc: Gary Brubaker 
Cc: Oliver Neukum 
Cc: Matthias Urlichs 
Cc: Support Department 
Cc: Rusty Russell 
Cc: Alan Stern 
Cc: Mauro Carvalho Chehab 
Cc: Kautuk Consul 
Cc: Bill Pemberton 
Cc: Paul Gortmaker 
Cc: Bart Hartgers 
Cc: Johan Hovold 
Cc: Preston Fick 
Cc: Uwe Bonnes 
Cc: Simon Arlott 
Cc: Andrew Worsley 
Cc: "Michał Wróbel" 
Cc: Andrew Morton 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Aleksey Babahin 
Cc: Dan Carpenter 
Cc: Jiri Kosina 
Cc: Donald Lee 
Cc: Julia Lawall 
Cc: Michal Sroczynski 
Cc: Wang YanQing 
Cc: Dan Williams 
Cc: Thomas Tuttle 
Cc: Rigbert Hamisch 
Cc: "Rafael J. Wysocki" 
Cc: Kuninori Morimoto 
Cc: Jesper Juhl 
Cc: Adhir Ramjiawan 
Signed-off-by: Greg Kroah-Hartman