linux-stable.git/drivers/usb/serial/ipw.c, branch v3.6

usb: usb_wwan: replace release and disconnect with a port_remove hook

2012-08-10T18:51:43+00:00

Doing port specific cleanup in the .port_remove hook is a
lot simpler and safer than doing it in the USB driver
.release or .disconnect methods. The removal of the port
from the usb-serial bus will happen before the USB driver
cleanup, so we must be careful about accessing port specific
driver data from any USB driver functions.

This problem surfaced after the commit

 0998d0631 device-core: Ensure drvdata = NULL when no driver is bound

which turned the previous unsafe access into a reliable NULL
pointer dereference.

Fixes the following Oops:

[  243.148471] BUG: unable to handle kernel NULL pointer dereference at           (null)
[  243.148508] IP: [] stop_read_write_urbs+0x37/0x80 [usb_wwan]
[  243.148556] PGD 79d60067 PUD 79d61067 PMD 0
[  243.148590] Oops: 0000 [#1] SMP
[  243.148617] Modules linked in: sr_mod cdrom qmi_wwan usbnet option cdc_wdm usb_wwan usbserial usb_storage uas fuse af_packet ip6table_filter ip6_tables iptable_filter ip_tables x_tables tun edd
cpufreq_conservative cpufreq_userspace cpufreq_powersave snd_pcm_oss snd_mixer_oss acpi_cpufreq snd_seq mperf snd_seq_device coretemp arc4 sg hp_wmi sparse_keymap uvcvideo videobuf2_core
videodev videobuf2_vmalloc videobuf2_memops rtl8192ce rtl8192c_common rtlwifi joydev pcspkr microcode mac80211 i2c_i801 lpc_ich r8169 snd_hda_codec_idt cfg80211 snd_hda_intel snd_hda_codec rfkill
snd_hwdep snd_pcm wmi snd_timer ac snd soundcore snd_page_alloc battery uhci_hcd i915 drm_kms_helper drm i2c_algo_bit ehci_hcd thermal usbcore video usb_common button processor thermal_sys
[  243.149007] CPU 1
[  243.149027] Pid: 135, comm: khubd Not tainted 3.5.0-rc7-next-20120720-1-vanilla #1 Hewlett-Packard HP Mini 110-3700                /1584
[  243.149072] RIP: 0010:[]  [] stop_read_write_urbs+0x37/0x80 [usb_wwan]
[  243.149118] RSP: 0018:ffff880037e75b30  EFLAGS: 00010286
[  243.149133] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff88005912aa28
[  243.149150] RDX: ffff88005e95f028 RSI: 0000000000000000 RDI: ffff88005f7c1a10
[  243.149166] RBP: ffff880037e75b60 R08: 0000000000000000 R09: ffffffff812cea90
[  243.149182] R10: 0000000000000000 R11: 0000000000000001 R12: ffff88006539b440
[  243.149198] R13: ffff88006539b440 R14: 0000000000000000 R15: 0000000000000000
[  243.149216] FS:  0000000000000000(0000) GS:ffff88007ee80000(0000) knlGS:0000000000000000
[  243.149233] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[  243.149248] CR2: 0000000000000000 CR3: 0000000079fe0000 CR4: 00000000000007e0
[  243.149264] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  243.149280] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[  243.149298] Process khubd (pid: 135, threadinfo ffff880037e74000, task ffff880037d40600)
[  243.149313] Stack:
[  243.149323]  ffff880037e75b40 ffff88006539b440 ffff8800799bc830 ffff88005f7c1800
[  243.149348]  0000000000000001 ffff88006539b448 ffff880037e75b70 ffffffffa04685e9
[  243.149371]  ffff880037e75bc0 ffffffffa0473765 ffff880037354988 ffff88007b594800
[  243.149395] Call Trace:
[  243.149419]  [] usb_wwan_disconnect+0x9/0x10 [usb_wwan]
[  243.149447]  [] usb_serial_disconnect+0xd5/0x120 [usbserial]
[  243.149511]  [] usb_unbind_interface+0x58/0x1a0 [usbcore]
[  243.149545]  [] __device_release_driver+0x77/0xe0
[  243.149567]  [] device_release_driver+0x27/0x40
[  243.149587]  [] bus_remove_device+0xdf/0x150
[  243.149608]  [] device_del+0x118/0x1a0
[  243.149661]  [] usb_disable_device+0xb0/0x280 [usbcore]
[  243.149718]  [] usb_disconnect+0x9d/0x140 [usbcore]
[  243.149770]  [] hub_port_connect_change+0xad/0x8a0 [usbcore]
[  243.149825]  [] ? usb_control_msg+0xe5/0x110 [usbcore]
[  243.149878]  [] hub_events+0x473/0x760 [usbcore]
[  243.149931]  [] hub_thread+0x35/0x1d0 [usbcore]
[  243.149955]  [] ? add_wait_queue+0x60/0x60
[  243.150004]  [] ? hub_events+0x760/0x760 [usbcore]
[  243.150026]  [] kthread+0x8e/0xa0
[  243.150047]  [] kernel_thread_helper+0x4/0x10
[  243.150068]  [] ? flush_kthread_work+0x120/0x120
[  243.150088]  [] ? gs_change+0xb/0xb
[  243.150101] Code: fd 41 54 53 48 83 ec 08 80 7f 1a 00 74 57 49 89 fc 31 db 90 49 8b 7c 24 20 45 31 f6 48 81 c7 10 02 00 00 e8 bc 64 f3 e0 49 89 c7 <4b> 8b 3c 37 49 83 c6 08 e8 4c a5 bd ff 49 83 fe 20
75 ed 45 30
[  243.150257] RIP  [] stop_read_write_urbs+0x37/0x80 [usb_wwan]
[  243.150282]  RSP 
[  243.150294] CR2: 0000000000000000
[  243.177170] ---[ end trace fba433d9015ffb8c ]---

Reported-by: Dan Carpenter 
Reported-by: Thomas Schäfer 
Suggested-by: Alan Stern 
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: serial: rework usb_serial_register/deregister_drivers()

2012-05-08T22:46:14+00:00

This reworks the usb_serial_register_drivers() and
usb_serial_deregister_drivers() to not need a pointer to a struct
usb_driver anymore.  The usb_driver structure is now created dynamically
and registered and unregistered as needed.

This saves lines of code in each usb-serial driver.  All in-kernel users
of these functions were also fixed up at this time.  The pl2303 driver
was tested that everything worked properly.

Thanks for the idea to do this from Alan Stern.

Cc: Adhir Ramjiawan 
Cc: Alan Stern 
Cc: Al Borchers 
Cc: Aleksey Babahin 
Cc: Andrew Morton 
Cc: Andrew Worsley 
Cc: Bart Hartgers 
Cc: Bill Pemberton 
Cc: Dan Carpenter 
Cc: Dan Williams 
Cc: Donald Lee 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Gary Brubaker 
Cc: Jesper Juhl 
Cc: Jiri Kosina 
Cc: Johan Hovold 
Cc: Julia Lawall 
Cc: Kautuk Consul 
Cc: Kuninori Morimoto 
Cc: Lonnie Mendez 
Cc: Matthias Bruestle and Harald Welte 
Cc: Matthias Urlichs 
Cc: Mauro Carvalho Chehab 
Cc: Michal Sroczynski 
Cc: "Michał Wróbel" 
Cc: Oliver Neukum 
Cc: Paul Gortmaker 
Cc: Peter Berger 
Cc: Preston Fick 
Cc: "Rafael J. Wysocki" 
Cc: Rigbert Hamisch 
Cc: Rusty Russell 
Cc: Simon Arlott 
Cc: Support Department 
Cc: Thomas Tuttle 
Cc: Uwe Bonnes 
Cc: Wang YanQing 
Cc: William Greathouse 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove usb_serial_disconnect call in all drivers

2012-05-07T21:02:13+00:00

This is now set by the usb-serial core, no need for the driver to
individually set it.

Thanks to Alan Stern for the idea to get rid of it.

Cc: William Greathouse 
Cc: Matthias Bruestle and Harald Welte 
Cc: Lonnie Mendez 
Cc: Peter Berger 
Cc: Al Borchers 
Cc: Gary Brubaker 
Cc: Oliver Neukum 
Cc: Matthias Urlichs 
Cc: Support Department 
Cc: Rusty Russell 
Cc: Alan Stern 
Cc: Mauro Carvalho Chehab 
Cc: Kautuk Consul 
Cc: Bill Pemberton 
Cc: Paul Gortmaker 
Cc: Bart Hartgers 
Cc: Johan Hovold 
Cc: Preston Fick 
Cc: Uwe Bonnes 
Cc: Simon Arlott 
Cc: Andrew Worsley 
Cc: "Michał Wróbel" 
Cc: Andrew Morton 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Aleksey Babahin 
Cc: Dan Carpenter 
Cc: Jiri Kosina 
Cc: Donald Lee 
Cc: Julia Lawall 
Cc: Michal Sroczynski 
Cc: Wang YanQing 
Cc: Dan Williams 
Cc: Thomas Tuttle 
Cc: Rigbert Hamisch 
Cc: "Rafael J. Wysocki" 
Cc: Kuninori Morimoto 
Cc: Jesper Juhl 
Cc: Adhir Ramjiawan 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove usb_serial_probe call in all drivers

2012-05-07T20:48:33+00:00

This is now set by the usb-serial core, no need for the driver to
individually set it.

Thanks to Alan Stern for the idea to get rid of it.

Cc: William Greathouse 
Cc: Matthias Bruestle and Harald Welte 
Cc: Lonnie Mendez 
Cc: Peter Berger 
Cc: Al Borchers 
Cc: Gary Brubaker 
Cc: Oliver Neukum 
Cc: Matthias Urlichs 
Cc: Support Department 
Cc: Rusty Russell 
Cc: Alan Stern 
Cc: Mauro Carvalho Chehab 
Cc: Kautuk Consul 
Cc: Bill Pemberton 
Cc: Paul Gortmaker 
Cc: Bart Hartgers 
Cc: Johan Hovold 
Cc: Preston Fick 
Cc: Uwe Bonnes 
Cc: Simon Arlott 
Cc: Andrew Worsley 
Cc: "Michał Wróbel" 
Cc: Andrew Morton 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Aleksey Babahin 
Cc: Dan Carpenter 
Cc: Jiri Kosina 
Cc: Donald Lee 
Cc: Julia Lawall 
Cc: Michal Sroczynski 
Cc: Wang YanQing 
Cc: Dan Williams 
Cc: Thomas Tuttle 
Cc: Rigbert Hamisch 
Cc: "Rafael J. Wysocki" 
Cc: Kuninori Morimoto 
Cc: Jesper Juhl 
Cc: Adhir Ramjiawan 
Signed-off-by: Greg Kroah-Hartman

USB: ipw.c: remove dbg() tracing calls

2012-05-03T23:44:17+00:00

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Rusty Russell 
CC: Oliver Neukum 
CC: Alan Stern 
CC: Mauro Carvalho Chehab 
Signed-off-by: Greg Kroah-Hartman

USB: serial: ipw.c: use module_usb_serial_driver

2012-02-28T21:11:56+00:00

This converts the ipw.c driver to use the module_usb_serial_driver() call
instead of having to have a module_init/module_exit function, saving a lot
of duplicated code.

CC: Rusty Russell 
CC: Oliver Neukum 
CC: Alan Stern 
CC: Mauro Carvalho Chehab 
Signed-off-by: Greg Kroah-Hartman

usb-serial: use new registration API in [i-j]* drivers

2012-02-24T20:39:18+00:00

This patch (as1525) modifies the following usb-serial drivers to
utilize the new usb_serial_{de}register_drivers() routines:

	io_edgeport, io_ti, ipaq, ipw, ir-usb, and iuu_phoenix.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

module_param: make bool parameters really bool (drivers & misc)

2012-01-12T23:02:20+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Acked-by: Mauro Carvalho Chehab 
Signed-off-by: Rusty Russell

USB: ipw: convert to usb-wwan framework

2011-08-22T22:21:16+00:00

From 2d487c10136f76cf3705881d34868e8592839cfe Mon Sep 17 00:00:00 2001
From: Oliver Neukum 
Date: Tue, 12 Jul 2011 15:36:51 +0200
Subject: [PATCH] USB: ipw: convert to usb-wwan framework

This patch allows the ipw driver to use the multibuffer
infrastructure of usb-wwan. This improves speed.

Signed-off-by: Oliver Neukum
Tested-by: Michal Hybner 
Signed-off-by: Greg Kroah-Hartman

USB: ipw: reimplement using generic framework

2010-05-20T20:21:46+00:00

Compile-only tested.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman