linux-stable.git/drivers/usb/serial/generic.c, branch v3.5

USB: serial-generic: use a single set of device IDs

2012-06-13T21:01:56+00:00

The usb-serial-generic driver uses different device IDs for its USB
matching and its serial matching.  This can lead to problems: The
driver can end up getting bound to a USB interface without being
allowed to bind to the corresponding serial port.

This patch (as1557) fixes the problem by using the same device ID
table (the one that can be altered by the "vendor=" and "product="
module parameters) for both purposes.  The unused table is removed.
Now the driver will bind only to the intended devices.

Signed-off-by: Alan Stern 
CC: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: generic.c: remove dbg() usage

2012-05-15T23:27:18+00:00

dbg() is a usb-serial specific macro.  This patch converts
the generic.c driver to use dev_dbg() instead to tie into the
dynamic debug infrastructure.

Signed-off-by: Greg Kroah-Hartman

USB: serial: rework usb_serial_register/deregister_drivers()

2012-05-08T22:46:14+00:00

This reworks the usb_serial_register_drivers() and
usb_serial_deregister_drivers() to not need a pointer to a struct
usb_driver anymore.  The usb_driver structure is now created dynamically
and registered and unregistered as needed.

This saves lines of code in each usb-serial driver.  All in-kernel users
of these functions were also fixed up at this time.  The pl2303 driver
was tested that everything worked properly.

Thanks for the idea to do this from Alan Stern.

Cc: Adhir Ramjiawan 
Cc: Alan Stern 
Cc: Al Borchers 
Cc: Aleksey Babahin 
Cc: Andrew Morton 
Cc: Andrew Worsley 
Cc: Bart Hartgers 
Cc: Bill Pemberton 
Cc: Dan Carpenter 
Cc: Dan Williams 
Cc: Donald Lee 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Gary Brubaker 
Cc: Jesper Juhl 
Cc: Jiri Kosina 
Cc: Johan Hovold 
Cc: Julia Lawall 
Cc: Kautuk Consul 
Cc: Kuninori Morimoto 
Cc: Lonnie Mendez 
Cc: Matthias Bruestle and Harald Welte 
Cc: Matthias Urlichs 
Cc: Mauro Carvalho Chehab 
Cc: Michal Sroczynski 
Cc: "Michał Wróbel" 
Cc: Oliver Neukum 
Cc: Paul Gortmaker 
Cc: Peter Berger 
Cc: Preston Fick 
Cc: "Rafael J. Wysocki" 
Cc: Rigbert Hamisch 
Cc: Rusty Russell 
Cc: Simon Arlott 
Cc: Support Department 
Cc: Thomas Tuttle 
Cc: Uwe Bonnes 
Cc: Wang YanQing 
Cc: William Greathouse 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove bizarre generic_serial probe function

2012-05-07T21:46:48+00:00

I can't remember why I wrote it like this many many years ago, but it's
not needed at all, let's rely on the usb-serial core for this function,
especially as it is being overridden by it anyway.

This lets us make usb_serial_probe() a static function, which it should
be.

Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove usb_serial_disconnect call in all drivers

2012-05-07T21:02:13+00:00

This is now set by the usb-serial core, no need for the driver to
individually set it.

Thanks to Alan Stern for the idea to get rid of it.

Cc: William Greathouse 
Cc: Matthias Bruestle and Harald Welte 
Cc: Lonnie Mendez 
Cc: Peter Berger 
Cc: Al Borchers 
Cc: Gary Brubaker 
Cc: Oliver Neukum 
Cc: Matthias Urlichs 
Cc: Support Department 
Cc: Rusty Russell 
Cc: Alan Stern 
Cc: Mauro Carvalho Chehab 
Cc: Kautuk Consul 
Cc: Bill Pemberton 
Cc: Paul Gortmaker 
Cc: Bart Hartgers 
Cc: Johan Hovold 
Cc: Preston Fick 
Cc: Uwe Bonnes 
Cc: Simon Arlott 
Cc: Andrew Worsley 
Cc: "Michał Wróbel" 
Cc: Andrew Morton 
Cc: Eric Dumazet 
Cc: "Eric W. Biederman" 
Cc: Felipe Balbi 
Cc: Aleksey Babahin 
Cc: Dan Carpenter 
Cc: Jiri Kosina 
Cc: Donald Lee 
Cc: Julia Lawall 
Cc: Michal Sroczynski 
Cc: Wang YanQing 
Cc: Dan Williams 
Cc: Thomas Tuttle 
Cc: Rigbert Hamisch 
Cc: "Rafael J. Wysocki" 
Cc: Kuninori Morimoto 
Cc: Jesper Juhl 
Cc: Adhir Ramjiawan 
Signed-off-by: Greg Kroah-Hartman

USB: generic.c: remove dbg() tracing calls

2012-05-03T23:44:12+00:00

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

Signed-off-by: Greg Kroah-Hartman

USB: serial: fix double newlines in debug output

2012-04-25T18:42:17+00:00

Remove trailing newlines from debug messages.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: serial: remove redundant write-urb kill

2012-04-25T18:42:16+00:00

Since commit 1ce7b9349fad ("USB: serial: reuse generic write urb and
bulk-out buffer") the port write_urb is simply a pointer to the first
member of write_urbs so there's no need to kill it twice.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

usb-serial: new API for driver registration

2012-02-24T20:39:17+00:00

This patch (as1522) adds two new routines to the usb-serial core, for
registering and unregistering serial drivers.  Instead of registering
the usb_driver and usb_serial_drivers separately, with error checking
for each one, the drivers can all be registered and unregistered by a
single function call.  This reduces duplicated code.

More importantly, the new core routines change the order in which the
drivers are registered.  Currently the usb-serial drivers are all
registered first and the usb_driver is done last, which leaves a
window for problems.  A udev script may quickly add a new dynamic-ID
for a usb-serial driver, causing the corresponding usb_driver to be
probed.  If the usb_driver hasn't been registered yet then an oops
will occur.

The new routine prevents such problems by registering the usb_driver
first.  To insure that it gets probed properly for already-attached
serial devices, we call driver_attach() after all the usb-serial
drivers have been registered.

Along with adding the new routines, the patch modifies the "generic"
serial driver to use them.  Further patches will similarly modify all
the other in-tree USB serial drivers.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: serial: use dev_err_console in generic write

2012-02-10T18:21:04+00:00

Use dev_err_console in write path so that an error at least gets
reported once.

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman