linux-stable.git/drivers/usb/misc/usbtest.c, branch v3.14

Merge tag 'for-usb-next-2013-12-20' of git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci into usb-next

2013-12-21T23:58:40+00:00

Sarah writes:

xhci: Cleanups, non-urgent fixes for 3.14.

Happy Holidays, Greg!

Here's four patches to be queued to usb-next for 3.14.

One adds a module parameter to the xHCI driver to allow users to enable
xHCI quirks without recompiling their kernel, which you've already said
is fine.  The second patch is a bug fix for new usbtest code that's only
in usb-next.  The third patch is simple cleanup.

The last patch is a non-urgent bug fix for xHCI platform devices.  The
bug has been in the code since 3.9.  You've been asking me to hold off
on non-urgent bug fixes after -rc4/-rc5, so it can go into usb-next, and
be backported to stable once 3.14 is out.

These have all been tested over the past week.  I did run across one
oops, but it turned out to be a bug in 3.12, and therefore not related
to any of these patches.

Please queue these for usb-next and 3.14.

Thanks,
Sarah Sharp

usb: usbtest: Always clear halt else further tests will fail

2013-12-19T00:26:12+00:00

In test_halt() we set an endpoint halt condition and return on halt verification
failure, then the enpoint will remain halted and all further tests related
to that enpoint will fail. This is because we don't tackle endpoint halt error condition
in any of the tests. To avoid that situation, make sure to clear the
halt condition before exiting test_halt().

Signed-off-by: Roger Quadros 
Reviewed-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: Add timetout to simple_io()

2013-12-19T00:26:12+00:00

Without a timetout some tests e.g. test_halt() can remain stuck forever.

Signed-off-by: Roger Quadros 
Reviewed-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usbtest: Fix BOS control test for USB 2.01 devices.

2013-12-17T21:40:29+00:00

Commit c952a8ba7136505cd1ca01735cc748ddc08c7d2f "usb: usbtest: add a
test case to support bos for queue control" will cause USB 2.01 and USB
2.10 devices with a BOS descriptor to fail case 15 of the control test.

The Link PM errata (released in 2007, updated in 2011) says:

"The value of the bcdUSB field in the standard USB 2.0 Device Descriptor
is used to indicate that the device supports the request to read the BOS
Descriptor (i.e.  GetDescriptor(BOS)). Devices that support the BOS
descriptor must have a bcdUSB value of 0201H or larger."

The current code says that non-SuperSpeed devices *must* return -EPIPE,
as this comment shows:

                /* sign of this variable means:
                 *  -: tested code must return this (negative) error code
                 *  +: tested code may return this (negative too) error code
                 */
                int                     expected = 0;

This means the test will fail with USB 2.01 and USB 2.10 devices that
provide a BOS descriptor.  Change it to only require a stall response if
the USB device bcdUSB is less than 2.01.

Signed-off-by: Sarah Sharp 
Acked-by: Huang Rui

usb: usbtest: update bos test coverage to usb 2.1 device

2013-12-09T01:42:45+00:00

The commit "usb: usbtest: support bos descriptor test for usb 3.0"
introduced a test for bos descriptor. And USB 2.1 device also can be
checked. So this patch extends the test coverage to support USB 2.1 device.

Reported-by: Sarah Sharp 
Signed-off-by: Huang Rui 
Acked-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: fix the bit mask of usb 2.0 extension descriptor

2013-12-09T01:42:45+00:00

USB 2.1 Link PM adds to use bits[1:15] according to USB 2.0 ECN Errata for
Link Power Management spec.

Bit	Encoding
0	Reserved
1	LPM
2	BESL & Altemate HIRD definitions supported
3	Recommended Baseline BESL valid
4	Recommended Deep BESL valid
11:8	Recommended Baseline BESL value
15:12	Recommended Deep BESL value
31:16	Reserved

So fix the bit mask from 0x1e to 0xfffe.

Reported-by: Sarah Sharp 
Signed-off-by: Huang Rui 
Acked-by: Felipe Balbi 
Acked-by: Sarah Sharp 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: add a test case to support bos for queue control

2013-12-09T01:42:45+00:00

In Test 10 of usbtest module, it queues multiple control messages and
thereby tests control message queuing, protocol stalls, short reads, and
fault handling. And this patch add a test case to support queue BOS control
request for USB 3.0 SPEC.

Signed-off-by: Huang Rui 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: support container id descriptor test

2013-10-30T17:15:41+00:00

In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.

Container ID descriptor is one of the generic device-level capbility
descriptors which added in section 9.6.2.3 of USB 3.0 spec.

This patch adds to support getting Container ID descriptor test scenario
for USB 3.0.

Signed-off-by: Huang Rui 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: support superspeed device capbility descriptor test

2013-10-30T16:57:21+00:00

In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.

SuperSpeed USB Device Capability descriptor is one of the generic
device-level capbility descriptors which added in section 9.6.2.2 of USB
3.0 spec.

This patch adds to support getting SuperSpeed USB Device Capability
descriptor test scenario for USB 3.0.

Signed-off-by: Huang Rui 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: support usb2 extension descriptor test

2013-10-30T16:52:14+00:00

In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.

USB2.0 Extension descriptor is one of the generic device-level capbility
descriptors which added in section 9.6.2.1 of USB 3.0 spec.

This patch adds to support getting usb2.0 extension descriptor test
scenario for USB 3.0.

Signed-off-by: Huang Rui 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman