linux-stable.git/drivers/usb/misc/usbtest.c, branch v3.10

USB: altsetting overrides for usbtest

2013-01-31T09:09:19+00:00

The usbtest driver includes some rather simple-minded logic for
selecting an altsetting to test.  It doesn't work well for the g_zero
gadget, because it selects altsetting 0 (which doesn't have
isochronous endpoints) rather than altsetting 1 (which does have them,
if the gadget's hardware supports them).  This prevents usbtest's
isochronous tests (15, 16, 22, and 23) from working with g_zero.

Since g_zero is one of the most common gadget drivers used for USB
testing, usbtest should do a better job of supporting it.  But since
some programs may rely on the current scheme for selecting
altsettings, I didn't want to change it.

Instead, this patch (as1655) adds a module parameter to usbtest, which
can be used to override the default altsetting.  Since usbtest is
never used by normal users (most distributions probably don't even
build it), the new module parameter won't inconvenience anybody.  In
any case, it is entirely optional -- leaving it unset preserves the
existing behavior.

The patch also fixes a related bug in usbtest: After selecting an
altsetting, the driver neglects to store its selection.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: usbtest: fix test number in log message

2013-01-07T18:34:20+00:00

This patch (as1639) fixes a minor bug in the usbtest driver.  Due to
concurrent changes, a test originally written as number 17 got changed
to number 24, but the corresponding change was not made in the log
message.  This updates the log message.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: usbtest: prevent a divide by zero bug

2012-11-21T21:32:26+00:00

If param->length is zero, then this could lead to a divide by zero bug
later in the function when we do: size %= max;

Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

usb: misc: usbtest: send ISO packets for g_zero

2012-11-14T20:15:49+00:00

since commit b4036cc (usb: gadget: add
isochronous support to gadget zero), g_zero
has learned about isochronous transfers, which
allows us to use usbtest.ko to exercise
isochronous pipes.

All we need to do to enable that functionality
on usbtest.ko, is set the "iso" to 1 on
struct usbtest_info

Signed-off-by: Boyan Nedeltchev 
Signed-off-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: two super speed fixes for usbtest

2012-05-01T17:38:27+00:00

bMaxPacketSize0 field for super speed is a power of 2, not a count.
The size itself is always 512.

Max packet size for a super speed bulk endpoint is 1024, so
allocate the urb size in halt_simple() accordingly.

Signed-off-by: Paul Zimmerman 
Acked-by: Felipe Balbi 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

drivers/usb/misc/usbtest.c: add kfrees

2012-04-18T21:13:52+00:00

Free the two previously allocated buffers before exiting the function in an
error case.

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: avoid integer overflow in alloc_sglist()

2012-04-17T22:54:57+00:00

A large `nents' from userspace could overflow the allocation size,
leading to memory corruption.

| alloc_sglist()
| usbtest_ioctl()

Use kmalloc_array() to avoid the overflow.

Signed-off-by: Xi Wang 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: avoid integer overflow in test_ctrl_queue()

2012-04-17T22:54:57+00:00

Avoid overflowing context.count = param->sglen * param->iterations,
where both `sglen' and `iterations' are from userspace.

| test_ctrl_queue()
| usbtest_ioctl()

Keep -EOPNOTSUPP for error code.

Signed-off-by: Xi Wang 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: remove BKL comments

2011-11-27T03:58:46+00:00

The BKL is a gonner.

Signed-off-by: Davidlohr Bueso 
Signed-off-by: Greg Kroah-Hartman

usb: Provide usb_speed_string() function

2011-09-18T08:29:04+00:00

In a few places in the kernel, the code prints
a human-readable USB device speed (eg. "high speed").
This involves a switch statement sometimes wrapped
around in ({ ... }) block leading to code repetition.

To mitigate this issue, this commit introduces
usb_speed_string() function, which returns
a human-readable name of provided speed.

It also changes a few places switch was used to use
this new function.  This changes a bit the way the
speed is printed in few instances at the same time
standardising it.

Signed-off-by: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman