linux-stable.git/drivers/usb/misc/usbtest.c, branch linux-4.5.y

usb: misc: usbtest: fix pattern tests for scatterlists.

2016-06-01T19:17:00+00:00

commit cdc77c82a8286b1181b81b6e5ef60c8e83ded7bc upstream.

The current implemenentation restart the sent pattern for each entry in
the sg list. The receiving end expects a continuous pattern, and test
will fail unless scatterilst entries happen to be aligned with the
pattern

Fix this by calculating the pattern byte based on total sent size
instead of just the current sg entry.

Signed-off-by: Mathias Nyman 
Fixes: 8b5249019352 ("[PATCH] USB: usbtest: scatterlist OUT data pattern testing")
Acked-by: Felipe Balbi 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: misc: usbtest: Remove timeval usage

2015-12-01T22:52:58+00:00

timeval is deprecated and not y2038 safe.  Its size also changes according
to 32 bit/ 64 bit compilation.  Replace it with 32 and 64 bit versions of
its individual fields, giving two ioctls with different code values.
The two ioctls are necessary to maintain the 32 bit and 64 bit userspace
compatibility with a 64/32 bit kernel.

Change unsigned to __u32 types for a definitive userspace interface.
This is in accordance with the psABI that the unsigned type is always
32 bits.

Also use motonic timer instead of real time to ensure positive delta
values.

Refactor usbtest_ioctl for readability to isolate the handling of the
testing timing measurement.

The official testusb userspace tool can be changed in a separate patch
to reflect the __u32 changes as well. It can use the usbtest_param_32
struct, since 32 bit seconds is long enough for test durations.

Signed-off-by: Deepa Dinamani 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

usb: misc: usbtest: improve the description for error message

2015-12-01T22:36:29+00:00

Now the function of complicated_callback is not only used for iso
transfer, improve the error message to reflect it.

Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: misc: usbtest: add bulk queue test

2015-10-13T18:19:49+00:00

The bulk queue tests are used to show 'best performance' for bulk
transfer, we are often asked this question by users. The implementation
is the same with iso test, that is queue request at interrupt completion,
so we reuse the iso structures, and rename them as common one.

It's result should be very close to IC simulation, in order
to get that, the device side should also need to prepare enough
queue.

We have got the 'best performance' (IN: 41MB, OUT: 39MB) at i.mx platform
(USB2, ARM Cortex A9, stream mode need to enable) with below command:

Host side:
modprobe usbtest
./testusb -a -t 27 -g 64 -s 16384
./testusb -a -t 28 -g 64 -s 16384
Gadget side:
modprobe g_zero loopdefault=1 qlen=64 buflen=16384

Signed-off-by: Peter Chen 
Cc: Greg KH 
Cc: Alan Stern 
Signed-off-by: Felipe Balbi

usb: misc: usbtest: format the data pattern according to max packet size

2015-09-27T15:54:31+00:00

With this change, the host and gadget doesn't need to agree with transfer
length for comparing the data, since they doesn't know each other's
transfer size, but know max packet size.

Signed-off-by: Peter Chen 
Acked-by: Michal Nazarewicz 
(Fixed the 'line over 80 characters warning' by Peter Chen)
Tested-by: Peter Chen 
Signed-off-by: Alan Stern 
Signed-off-by: Felipe Balbi

usb: misc: usbtest: using the same data format among write/compare/output

2015-09-27T15:54:31+00:00

Using the same data format "buf[j] = (u8)(i + j)" among
write, compare buf, and console output stage.

Acked-by: Michal Nazarewicz 
Signed-off-by: Peter Chen 
Signed-off-by: Felipe Balbi

usb: misc: usbtest: delete useless memset for urbs array

2015-09-27T15:54:31+00:00

The element of urbs array will be initialized at below code
at once.

	for (i = 0; i < param->sglen; i++) {
		urbs[i] = iso_alloc_urb(udev, pipe, desc,
					param->length, offset);

Acked-by: Michal Nazarewicz 
Signed-off-by: Peter Chen 
Signed-off-by: Felipe Balbi

usb: misc: usbtest: allocate size of urb array according to user parameter

2015-09-27T15:54:31+00:00

Allocate the size of urb pointer array according to testusb's
parameter sglen, and limits the length of sglen as MAX_SGLEN
(128 currently).

Acked-by: Michal Nazarewicz 
Signed-off-by: Peter Chen 
Signed-off-by: Felipe Balbi

usb: misc: usbtest: format max packet size for iso transfer

2015-08-18T17:05:23+00:00

The current code prints all wMaxPacketSize content at endpoint
descriptor, if there is a high speed, high bandwidth endpoint,
it may confuse the users, eg, if there are 3 transactions during
microframe, it will print "wMaxPacket 1400" for packet content.
This commit splits wMaxpacketSize and transaction numbers for
output messages.

Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: hub: rename khubd to hub_wq in documentation and comments

2014-09-24T05:33:19+00:00

USB hub has started to use a workqueue instead of kthread. Let's update
the documentation and comments here and there.

This patch mostly just replaces "khubd" with "hub_wq". There are only few
exceptions where the whole sentence was updated. These more complicated
changes can be found in the following files:

	   Documentation/usb/hotplug.txt
	   drivers/net/usb/usbnet.c
	   drivers/usb/core/hcd.c
	   drivers/usb/host/ohci-hcd.c
	   drivers/usb/host/xhci.c

Signed-off-by: Petr Mladek 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman