linux-stable.git/drivers/usb/misc/usbtest.c, branch linux-3.4.y

usb: usbtest: Add timetout to simple_io()

2014-07-01T03:01:33+00:00

commit e5e4746510d140261918aecce2e5e3aa4456f7e9 upstream.

Without a timetout some tests e.g. test_halt() can remain stuck forever.

Signed-off-by: Roger Quadros 
Reviewed-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

USB: usbtest: add a timeout for scatter-gather tests

2014-07-01T03:01:30+00:00

commit 32b36eeae6a859670d2939a7d6136cb5e9ed64f8 upstream.

In usbtest, tests 5 - 8 use the scatter-gather library in usbcore
without any sort of timeout.  If there's a problem in the gadget or
host controller being tested, the test can hang.

This patch adds a 10-second timeout to the tests, so that they will
fail gracefully with an ETIMEDOUT error instead of hanging.

Signed-off-by: Alan Stern 
Reported-by: Huang Rui 
Tested-by: Huang Rui 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: fix unlink write error with pattern 1

2014-07-01T03:01:30+00:00

commit e4d58f5dcb7d7be45df8def31881ebfae99c75da upstream.

TEST 12 and TEST 24 unlinks the URB write request for N times. When
host and gadget both initialize pattern 1 (mod 63) data series to
transfer, the gadget side will complain the wrong data which is not
expected.  Because in host side, usbtest doesn't fill the data buffer
as mod 63 and this patch fixed it.

[20285.488974] dwc3 dwc3.0.auto: ep1out-bulk: Transfer Not Ready
[20285.489181] dwc3 dwc3.0.auto: ep1out-bulk: reason Transfer Not Active
[20285.489423] dwc3 dwc3.0.auto: ep1out-bulk: req ffff8800aa6cb480 dma aeb50800 length 512 last
[20285.489727] dwc3 dwc3.0.auto: ep1out-bulk: cmd 'Start Transfer' params 00000000 a9eaf000 00000000
[20285.490055] dwc3 dwc3.0.auto: Command Complete --> 0
[20285.490281] dwc3 dwc3.0.auto: ep1out-bulk: Transfer Not Ready
[20285.490492] dwc3 dwc3.0.auto: ep1out-bulk: reason Transfer Active
[20285.490713] dwc3 dwc3.0.auto: ep1out-bulk: endpoint busy
[20285.490909] dwc3 dwc3.0.auto: ep1out-bulk: Transfer Complete
[20285.491117] dwc3 dwc3.0.auto: request ffff8800aa6cb480 from ep1out-bulk completed 512/512 ===> 0
[20285.491431] zero gadget: bad OUT byte, buf[1] = 0
[20285.491605] dwc3 dwc3.0.auto: ep1out-bulk: cmd 'Set Stall' params 00000000 00000000 00000000
[20285.491915] dwc3 dwc3.0.auto: Command Complete --> 0
[20285.492099] dwc3 dwc3.0.auto: queing request ffff8800aa6cb480 to ep1out-bulk length 512
[20285.492387] dwc3 dwc3.0.auto: ep1out-bulk: Transfer Not Ready
[20285.492595] dwc3 dwc3.0.auto: ep1out-bulk: reason Transfer Not Active
[20285.492830] dwc3 dwc3.0.auto: ep1out-bulk: req ffff8800aa6cb480 dma aeb51000 length 512 last
[20285.493135] dwc3 dwc3.0.auto: ep1out-bulk: cmd 'Start Transfer' params 00000000 a9eaf000 00000000
[20285.493465] dwc3 dwc3.0.auto: Command Complete --> 0

Signed-off-by: Huang Rui 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: two super speed fixes for usbtest

2012-06-01T07:18:21+00:00

commit 6a23ccd216b6a8ba2c67a9f9d8969b4431ad2920 upstream.

bMaxPacketSize0 field for super speed is a power of 2, not a count.
The size itself is always 512.

Max packet size for a super speed bulk endpoint is 1024, so
allocate the urb size in halt_simple() accordingly.

Signed-off-by: Paul Zimmerman 
Acked-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

drivers/usb/misc/usbtest.c: add kfrees

2012-04-18T21:13:52+00:00

Free the two previously allocated buffers before exiting the function in an
error case.

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: avoid integer overflow in alloc_sglist()

2012-04-17T22:54:57+00:00

A large `nents' from userspace could overflow the allocation size,
leading to memory corruption.

| alloc_sglist()
| usbtest_ioctl()

Use kmalloc_array() to avoid the overflow.

Signed-off-by: Xi Wang 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

usb: usbtest: avoid integer overflow in test_ctrl_queue()

2012-04-17T22:54:57+00:00

Avoid overflowing context.count = param->sglen * param->iterations,
where both `sglen' and `iterations' are from userspace.

| test_ctrl_queue()
| usbtest_ioctl()

Keep -EOPNOTSUPP for error code.

Signed-off-by: Xi Wang 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: remove BKL comments

2011-11-27T03:58:46+00:00

The BKL is a gonner.

Signed-off-by: Davidlohr Bueso 
Signed-off-by: Greg Kroah-Hartman

usb: Provide usb_speed_string() function

2011-09-18T08:29:04+00:00

In a few places in the kernel, the code prints
a human-readable USB device speed (eg. "high speed").
This involves a switch statement sometimes wrapped
around in ({ ... }) block leading to code repetition.

To mitigate this issue, this commit introduces
usb_speed_string() function, which returns
a human-readable name of provided speed.

It also changes a few places switch was used to use
this new function.  This changes a bit the way the
speed is printed in few instances at the same time
standardising it.

Signed-off-by: Michal Nazarewicz 
Signed-off-by: Greg Kroah-Hartman

USB: use usb_endpoint_maxp() instead of le16_to_cpu()

2011-08-23T16:47:40+00:00

Now ${LINUX}/drivers/usb/* can use usb_endpoint_maxp(desc) to get maximum packet size
instead of le16_to_cpu(desc->wMaxPacketSize).
This patch fix it up

Cc: Armin Fuerst 
Cc: Pavel Machek 
Cc: Johannes Erdfelt 
Cc: Vojtech Pavlik 
Cc: Oliver Neukum 
Cc: David Kubicek 
Cc: Johan Hovold 
Cc: Brad Hards 
Acked-by: Felipe Balbi 
Cc: Sebastian Andrzej Siewior 
Cc: Thomas Dahlmann 
Cc: David Brownell 
Cc: David Lopo 
Cc: Alan Stern 
Cc: Michal Nazarewicz 
Cc: Xie Xiaobo 
Cc: Li Yang 
Cc: Jiang Bo 
Cc: Yuan-hsin Chen 
Cc: Darius Augulis 
Cc: Xiaochen Shen 
Cc: Yoshihiro Shimoda 
Cc: OKI SEMICONDUCTOR, 
Cc: Robert Jarzmik 
Cc: Ben Dooks 
Cc: Thomas Abraham 
Cc: Herbert Pötzl 
Cc: Arnaud Patard 
Cc: Roman Weissgaerber 
Acked-by: Sarah Sharp 
Cc: Tony Olech 
Cc: Florian Floe Echtler 
Cc: Christian Lucht 
Cc: Juergen Stuber 
Cc: Georges Toth 
Cc: Bill Ryder 
Cc: Kuba Ober 
Cc: Inaky Perez-Gonzalez 
Signed-off-by: Kuninori Morimoto 
Signed-off-by: Greg Kroah-Hartman