linux-stable.git/drivers/usb/misc/usbled.c, branch linux-3.2.y

usb: misc: usbled: fixed coding style issues

2011-08-22T22:21:16+00:00

Fixed multiple coding style issues

Signed-off-by: Zack Parsons 
Signed-off-by: Greg Kroah-Hartman

USB: DL100B webmail notifier: initialize return value

2011-01-23T02:32:54+00:00

If case of an unknown usb_device_id->driver_info (which could only
occur if the info got corrupted somewhere outside the usbled driver),
a debug message depended on an uninitialized value. This was harmless,
but ugly, and gets fixed with this patch.

Signed-off-by: Melchior FRANZ 
Signed-off-by: Greg Kroah-Hartman

USB: add support for Dream Cheeky DL100B Webmail Notifier (1d34:0004)

2010-12-22T04:48:21+00:00

So far the USBLED driver only supports Delcom's "USB Visual Signal
Indicator" (http://www.delcomproducts.com/products_USBLMP.asp). The
driver generates virtual files "red", "green", and "blue" under the
device's /sys/ directory, where color values can be read from and
written to.

This patch adds support for Dream Cheeky's "DL100B Webmail Notifier"
(http://www.dreamcheeky.com/webmail-notifier -- available from several
shops, such as http://www.conrad.at/ce/de/product/777048/USB-WEBMAIL).
This device isn't as pretty as Delcom's, but it's *far* cheaper, and
its 3 LEDs can be set in 32 brightness steps each. The grey envelope
contour can easily be removed, leaving a rather neutral white box (with
a few small holes), which is useful for generic signalling purposes.
Of course, the small circuit board can easily be put into a prettier
case.

The DL100B device pretends to be a HID, but the HID descriptor shows
that it's not overly useful as such (see below). The patch therefore
removes the "HID-ness" (hid-core.c, hid-ids.h), and adds the necessary
commands to usbled.c. The protocol info comes from the developer's
manual that Dream Cheeky kindly provided (815DeveloperManual.pdf).

HID descriptor:

  0: 05 01   Usage Page 'Generic Desktop Controls'
  2: 09 10   Usage 'Reserved'
  4: a1 01   Collection 'Application (mouse, keyboard)'
  6: 05 00           Usage Page 'Undefined'
  8: 19 10           Usage Minimum = 16
 10: 29 11           Usage Maximum = 17
 12: 15 00           Logical Minimum = 0
 14: 25 0f           Logical Maximum = 15
 16: 75 08           Report Size = 8
 18: 95 08           Report Count = 8
 20: 91 02           Output data *var abs lin pref-state null-pos non-vol bit-field
 22: 19 10           Usage Minimum = 16
 24: 29 11           Usage Maximum = 17
 26: 15 00           Logical Minimum = 0
 28: 25 0f           Logical Maximum = 15
 30: 75 08           Report Size = 8
 32: 95 08           Report Count = 8
 34: 81 00           Input data array abs lin pref-state null-pos non-vol bit-field
 36: c0      End Collection

Signed-off-by: Melchior FRANZ 
Signed-off-by: Greg Kroah-Hartman

USB: misc: usbled: fix up some sysfs attribute permissions

2010-11-15T22:04:15+00:00

They should not be writable by any user.

Reported-by: Linus Torvalds 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB misc: make USB device id constant

2010-03-02T22:54:17+00:00

The id_table field of the struct usb_device_id is constant in 
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// 
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// 

Signed-off-by: Németh Márton 
Cc: Julia Lawall 
Cc: cocci@diku.dk
Signed-off-by: Greg Kroah-Hartman

USB: fix usbled disconnect read race #2

2007-11-28T21:58:33+00:00

usbled has a race where show methods for attributes in sysfs can
follow a NULL pointer during disconnect. The correct ordering fixes
it.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: fix __must_check warnings in drivers/usb/misc/

2006-09-27T18:58:58+00:00

Signed-off-by: Greg Kroah-Hartman

Remove obsolete #include

2006-06-30T17:25:36+00:00

Signed-off-by: Jörn Engel 
Signed-off-by: Adrian Bunk

[PATCH] USB: kzalloc in usbled

2006-03-20T22:49:54+00:00

another one for kzalloc.

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: remove .owner field from struct usb_driver

2006-01-04T21:48:34+00:00

It is no longer needed, so let's remove it, saving a bit of memory.

Signed-off-by: Greg Kroah-Hartman