linux-stable.git/drivers/usb/gadget/zero.c, branch linux-3.12.y

usb: gadget: zero: Fix SuperSpeed enumeration for alternate setting 1

2014-05-15T07:55:22+00:00

commit 9c1b70361e0b38e4acb8e62b54da66538cb77ff2 upstream.

It was impossible to enumerate on a SuperSpeed (XHCI) host
with alternate setting = 1 due to the wrongly set 'bMaxBurst'
field in the SuperSpeed Endpoint Companion descriptor.

Testcase:
 modprobe -r usbtest; modprobe usbtest alt=1
 modprobe g_zero
plug device to SuperSpeed port on the host.

Without this patch the host always complains like so
"usb 12-2: Not enough bandwidth for new device state.
 usb 12-2: Not enough bandwidth for altsetting 1"

Bug was introduced by commit cf9a08ae in v3.9

Fixes: cf9a08ae5aec (usb: gadget: convert source sink and loopback to
new function interface)

Reviewed-by: Felipe Balbi 
Acked-by: Sebastian Andrzej Siewior 
Signed-off-by: Roger Quadros 
Signed-off-by: Felipe Balbi 
Signed-off-by: Jiri Slaby

usb: gadget: zero: fix error return code in zero_bind()

2013-05-15T14:15:57+00:00

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Introduced by commit cf9a08ae5aece88987bbeee8eb0dd0ebb5015815
(usb: gadget: convert source sink and loopback to new function interface)

Acked-by: Michal Nazarewicz 
Signed-off-by: Wei Yongjun 
Signed-off-by: Felipe Balbi

usb: gadget: zero: put function instances on unbind

2013-04-23T11:12:21+00:00

If function instances are not put on gadget's unbind, their implementation
module's refcount is nonzero and it is impossible to unload them.

Signed-off-by: Andrzej Pietrasiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Felipe Balbi

usb: gadget: fix two sparse warnings

2013-01-21T18:52:49+00:00

drivers/usb/gadget/u_serial.c:1291:5: sparse: symbol \
	'userial_init' was not declared. Should it be static?
drivers/usb/gadget/zero.c:66:25: sparse: symbol \
	'gzero_options' was not declared. Should it be static?

Reported-by: Fengguang Wu 
Signed-off-by: Felipe Balbi

usb: gadget: convert source sink and loopback to new function interface

2013-01-21T18:52:40+00:00

This patch converts the f_sourcesink and f_loopback file to the USB-function
module. Both functions shares a few common utility functions which are
currently implemented in g_zero.c itself. This patch moves the common
code into the sourcesink file and creates one module out of the the two
functions (source sink and loop back).
The g_zero gadget is function specific to source sink and loop back to
set a few options. This Symbol dependency enforces a modul load right
now.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: move loopback's config descriptor out of f_loopback

2013-01-21T18:52:39+00:00

f_loopback should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: move source sink's config descriptor out of f_sourcesink

2013-01-21T18:52:38+00:00

f_sourcesink should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: remove usb_gadget_controller_number()

2012-09-10T13:43:24+00:00

The bcdDevice field is defined as
|Device release number in binary-coded decimal
in the USB 2.0 specification. We use this field to distinguish the UDCs
from each other. In theory this could be used on the host side to apply
certain quirks if the "special" UDC in combination with this gadget is
used. This hasn't been done as far as I am aware. In practice it would
be better to fix the UDC driver before shipping since a later release
might not need this quirk anymore.

There are some driver in tree (on the host side) which use the bcdDevice
field to figure out special workarounds for a given firmware revision.
This seems to make sense. Therefore this patch converts all gadgets
(except a few) to use the kernel version instead a random 2 or 3 plus
the UDC number. The few that don't report kernel's version are:
- webcam
  This one reports always a version 0x10 so allow it to do so in future.
- nokia
  This one reports always 0x211. The comment says that this gadget works
  only if the UDC supports altsettings so I added a check for this.
- serial
  This one reports 0x2400 + UDC number. Since the gadget version is 2.4
  this could make sense. Therefore bcdDevice is 0x2400 here.

I also remove various gadget_is_ macros which are unused. The
remaining few macros should be moved to feature / bug bitfield.

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: libcomposite: move composite.c into libcomposite

2012-09-10T13:13:03+00:00

This moves composite.c into libcomposite and updates all gadgets.
Finally!

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi

usb: gadget: Provide a default implementation of default manufacturer string

2012-09-10T13:13:02+00:00

Some gadgets provide custom entry here. Some may override it with an
etntry that is also created by composite if there was no value sumbitted
at all.
This patch removes all "custom manufacturer" strings which are the same
as these which are created by composite. Then it moves the creation of
the default manufacturer string to usb_composite_overwrite_options() in
case no command line argument has been used and the entry is still an
empty string.
By doing this we get rid of the global variable "composite_manufacturer"
in composite.

Acked-by: Michal Nazarewicz 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Felipe Balbi