linux-stable.git/drivers/usb/gadget/function/f_uvc.c, branch linux-3.18.y

usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed

2017-12-25T13:20:06+00:00

[ Upstream commit 16bb05d98c904a4f6c5ce7e2d992299f794acbf2 ]

As per USB3.0 Specification "Table 9-20. Standard Endpoint Descriptor",
for interrupt and isochronous endpoints, wMaxPacketSize must be set to
1024 if the endpoint defines bMaxBurst to be greater than zero.

Reviewed-by: Laurent Pinchart 
Signed-off-by: Roger Quadros 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval

2017-04-18T05:55:53+00:00

commit 09424c50b7dff40cb30011c09114404a4656e023 upstream.

The streaming_maxburst module parameter is 0 offset (0..15)
so we must add 1 while using it for wBytesPerInterval
calculation for the SuperSpeed companion descriptor.

Without this host uvcvideo driver will always see the wrong
wBytesPerInterval for SuperSpeed uvc gadget and may not find
a suitable video interface endpoint.
e.g. for streaming_maxburst = 0 case it will always
fail as wBytePerInterval was evaluating to 0.

Reviewed-by: Laurent Pinchart 
Signed-off-by: Roger Quadros 
Signed-off-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: gadget: function: uvc: disable endpoints on ->disable()

2014-10-20T20:58:48+00:00

when our ->disable() method is called, we must
make sure to teardown all our resources, including
endpoints.

Signed-off-by: Felipe Balbi

usb: gadget: function: uvc: manage our video control endpoint

2014-10-20T20:58:48+00:00

just like any other endpoint, we must enable/disable
our video control endpoint based on calls to our
->set_alt() method.

Signed-off-by: Felipe Balbi

usb: gadget: function: uvc: return correct alt-setting

2014-10-20T20:58:48+00:00

If our alternate setting has been selected, we must
return that on a subsequent Get Interface request
even if we're not streaming.

Signed-off-by: Felipe Balbi

usb: gadget: function: uvc: make sure to balance ep enable/disable

2014-10-20T20:58:48+00:00

If a set_alt() to the same alternate setting that's
already selected is received, functions are required
to reset the interface state, this means we must disable
all endpoints and reenable them again.

This is also documented on our kdoc for struct usb_function

* @set_alt: (REQUIRED) Reconfigures altsettings; function drivers may
*	initialize usb_ep.driver data at this time (when it is used).
*	Note that setting an interface to its current altsetting resets
*	interface state, and that all interfaces have a disabled state.

Signed-off-by: Felipe Balbi

usb: gadget: uvc: Fix endianness mismatches

2014-09-16T14:59:47+00:00

The struct usb_endpoint_descriptor wMaxPacketSize field the struct
usb_ss_ep_comp_descriptor wBytesPerInterval field are stored in
little-endian format. Convert the values from CPU order to little endian
before storing the values.

Signed-off-by: Laurent Pinchart 
Signed-off-by: Felipe Balbi

usb: gadget: uvc: uvc_alloc() can be static

2014-09-16T14:58:52+00:00

The function isn't called from outside of its compilation unit, make it
static.

Signed-off-by: Fengguang Wu 
Acked-by: Andrzej Pietrasiewicz 
Signed-off-by: Laurent Pinchart 
Signed-off-by: Felipe Balbi

usb: gadget: f_uvc: use usb_gstrings_attach

2014-09-09T14:49:44+00:00

Attach strings to gadget with usb_strings_attach.
It is required for correct instantiation of functions more than once:
instead of modifying the local uvc_en_us_strings a function instance
specific copy is created with usb_gstrings_attach.

Signed-off-by: Andrzej Pietrasiewicz 
Tested-by: Michael Grzeschik 
Signed-off-by: Laurent Pinchart 
Signed-off-by: Felipe Balbi

usb: gadget: f_uvc: remove compatibility layer

2014-09-09T14:49:41+00:00

There are no users of the old interface left. Remove it.

Signed-off-by: Andrzej Pietrasiewicz 
Tested-by: Michael Grzeschik 
Signed-off-by: Laurent Pinchart 
Signed-off-by: Felipe Balbi