linux-stable.git/drivers/usb/dwc3, branch linux-5.0.y

usb: dwc3: move synchronize_irq() out of the spinlock protected block

2019-05-31T13:44:54+00:00

[ Upstream commit 41a91c606e7d2b74358a944525267cc451c271e8 ]

dwc3_gadget_suspend() is called under dwc->lock spinlock. In such context
calling synchronize_irq() is not allowed. Move the problematic call out
of the protected block to fix the following kernel BUG during system
suspend:

BUG: sleeping function called from invalid context at kernel/irq/manage.c:112
in_atomic(): 1, irqs_disabled(): 128, pid: 1601, name: rtcwake
6 locks held by rtcwake/1601:
 #0: f70ac2a2 (sb_writers#7){.+.+}, at: vfs_write+0x130/0x16c
 #1: b5fe1270 (&of->mutex){+.+.}, at: kernfs_fop_write+0xc0/0x1e4
 #2: 7e597705 (kn->count#60){.+.+}, at: kernfs_fop_write+0xc8/0x1e4
 #3: 8b3527d0 (system_transition_mutex){+.+.}, at: pm_suspend+0xc4/0xc04
 #4: fc7f1c42 (&dev->mutex){....}, at: __device_suspend+0xd8/0x74c
 #5: 4b36507e (&(&dwc->lock)->rlock){....}, at: dwc3_gadget_suspend+0x24/0x3c
irq event stamp: 11252
hardirqs last  enabled at (11251): [] _raw_spin_unlock_irqrestore+0x6c/0x74
hardirqs last disabled at (11252): [] _raw_spin_lock_irqsave+0x1c/0x5c
softirqs last  enabled at (9744): [] __do_softirq+0x3a4/0x66c
softirqs last disabled at (9737): [] irq_exit+0x140/0x168
Preemption disabled at:
[<00000000>]   (null)
CPU: 7 PID: 1601 Comm: rtcwake Not tainted
5.0.0-rc3-next-20190122-00039-ga3f4ee4f8a52 #5252
Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0x90/0xc8)
[] (dump_stack) from [] (___might_sleep+0x22c/0x2c8)
[] (___might_sleep) from [] (synchronize_irq+0x28/0x84)
[] (synchronize_irq) from [] (dwc3_gadget_suspend+0x34/0x3c)
[] (dwc3_gadget_suspend) from [] (dwc3_suspend_common+0x154/0x410)
[] (dwc3_suspend_common) from [] (dwc3_suspend+0x14/0x2c)
[] (dwc3_suspend) from [] (platform_pm_suspend+0x2c/0x54)
[] (platform_pm_suspend) from [] (dpm_run_callback+0xa4/0x3dc)
[] (dpm_run_callback) from [] (__device_suspend+0x134/0x74c)
[] (__device_suspend) from [] (dpm_suspend+0x174/0x588)
[] (dpm_suspend) from [] (suspend_devices_and_enter+0xc0/0xe74)
[] (suspend_devices_and_enter) from [] (pm_suspend+0x770/0xc04)
[] (pm_suspend) from [] (state_store+0x6c/0xcc)
[] (state_store) from [] (kobj_attr_store+0x14/0x20)
[] (kobj_attr_store) from [] (sysfs_kf_write+0x4c/0x50)
[] (sysfs_kf_write) from [] (kernfs_fop_write+0xfc/0x1e4)
[] (kernfs_fop_write) from [] (__vfs_write+0x2c/0x160)
[] (__vfs_write) from [] (vfs_write+0xa4/0x16c)
[] (vfs_write) from [] (ksys_write+0x40/0x8c)
[] (ksys_write) from [] (ret_fast_syscall+0x0/0x28)
Exception stack(0xed55ffa8 to 0xed55fff0)
...

Fixes: 01c10880d242 ("usb: dwc3: gadget: synchronize_irq dwc irq in suspend")
Signed-off-by: Marek Szyprowski 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: Fix default lpm_nyet_threshold value

2019-05-10T16:36:12+00:00

commit 8d791929b2fbdf7734c1596d808e55cb457f4562 upstream.

The max possible value for DCTL.LPM_NYET_THRES is 15 and not 255. Change
the default value to 15.

Cc: stable@vger.kernel.org
Fixes: 80caf7d21adc ("usb: dwc3: add lpm erratum support")
Signed-off-by: Thinh Nguyen 
Signed-off-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: dwc3: Allow building USB_DWC3_QCOM without EXTCON

2019-05-10T16:36:12+00:00

commit 77a4946516fe488b6a33390de6d749f934a243ba upstream.

Keep EXTCON support optional, as some platforms do not need it.

Do the same for USB_DWC3_OMAP while we're at it.

Fixes: 3def4031b3e3f ("usb: dwc3: add EXTCON dependency for qcom")
Signed-off-by: Marc Gonzalez 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

usb: dwc3: Reset num_trbs after skipping

2019-05-08T05:22:55+00:00

commit c7152763f02e05567da27462b2277a554e507c89 upstream.

Currently req->num_trbs is not reset after the TRBs are skipped and
processed from the cancelled list. The gadget driver may reuse the
request with an invalid req->num_trbs, and DWC3 will incorrectly skip
trbs. To fix this, simply reset req->num_trbs to 0 after skipping
through all of them.

Fixes: c3acd5901414 ("usb: dwc3: gadget: use num_trbs when skipping TRBs on ->dequeue()")
Signed-off-by: Thinh Nguyen 
Signed-off-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: dwc3: pci: add support for Comet Lake PCH ID

2019-05-04T07:21:15+00:00

[ Upstream commit 7ae622c978db6b2e28b4fced6ecd2a174492059d ]

This patch simply adds a new PCI Device ID

Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin (Microsoft)

usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded

2019-04-05T20:34:47+00:00

[ Upstream commit 169e3b68cadb5775daca009ced4faf01ffd97dcf ]

On v3.10a in dual-role mode, if port is in device mode
and gadget driver isn't loaded, the OTG event interrupts don't
come through.

It seems that if the core is configured to be OTG2.0 only,
then we can't leave the DCFG.DEVSPD at Super-speed (default)
if we expect OTG to work properly. It must be set to High-speed.

Fix this issue by configuring DCFG.DEVSPD to the supported
maximum speed at gadget init. Device tree still needs to provide
correct supported maximum speed for this to work.

This issue wasn't present on v2.40a but is seen on v3.10a.
It doesn't cause any side effects on v2.40a.

Signed-off-by: Roger Quadros 
Signed-off-by: Sekhar Nori 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: exynos: Fix error handling of clk_prepare_enable

2019-01-28T13:31:11+00:00

If clk_prepare_enable() fails in dwc3_exynos_probe() or in
dwc3_exynos_resume(), exynos->clks[0] is left undisabled
because of usage preincrement in while condition.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 9f2168367a0a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants")
Acked-by: Marek Szyprowski 
Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: Handle 0 xfer length for OUT EP

2019-01-28T13:27:07+00:00

For OUT endpoints, zero-length transfers require MaxPacketSize buffer as
per the DWC_usb3 programming guide 3.30a section 4.2.3.3.

This patch fixes this by explicitly checking zero length
transfer to correctly pad up to MaxPacketSize.

Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: stable@vger.kernel.org

Signed-off-by: Tejas Joglekar 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: Fix the uninitialized link_state when udc starts

2019-01-14T08:29:55+00:00

Currently the link_state is uninitialized and the default value is 0(U0)
before the first time we start the udc, and after we start the udc then
 stop the udc, the link_state will be undefined.
We may have the following warnings if we start the udc again with
an undefined link_state:

WARNING: CPU: 0 PID: 327 at drivers/usb/dwc3/gadget.c:294 dwc3_send_gadget_ep_cmd+0x304/0x308
dwc3 100e0000.hidwc3_0: wakeup failed --> -22
[...]
Call Trace:
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0x84/0x98)
[] (dump_stack) from [] (__warn+0xe8/0x100)
[] (__warn) from [](warn_slowpath_fmt+0x38/0x48)
[] (warn_slowpath_fmt) from [](dwc3_send_gadget_ep_cmd+0x304/0x308)
[] (dwc3_send_gadget_ep_cmd) from [](dwc3_ep0_start_trans+0x48/0xf4)
[] (dwc3_ep0_start_trans) from [](dwc3_ep0_out_start+0x64/0x80)
[] (dwc3_ep0_out_start) from [](__dwc3_gadget_start+0x1e0/0x278)
[] (__dwc3_gadget_start) from [](dwc3_gadget_start+0x88/0x10c)
[] (dwc3_gadget_start) from [](udc_bind_to_driver+0x88/0xbc)
[] (udc_bind_to_driver) from [](usb_gadget_probe_driver+0xf8/0x140)
[] (usb_gadget_probe_driver) from [](gadget_dev_desc_UDC_store+0xac/0xc4 [libcomposite])
[] (gadget_dev_desc_UDC_store [libcomposite]) from[] (configfs_write_file+0xd4/0x160)
[] (configfs_write_file) from [] (__vfs_write+0x1c/0x114)
[] (__vfs_write) from [] (vfs_write+0xa4/0x168)
[] (vfs_write) from [] (SyS_write+0x3c/0x90)
[] (SyS_write) from [] (ret_fast_syscall+0x0/0x3c)

Signed-off-by: Zeng Tao 
Signed-off-by: Felipe Balbi

usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup

2019-01-14T08:29:55+00:00

OUT endpoint requests may somtimes have this flag set when
preparing to be submitted to HW indicating that there is an
additional TRB chained to the request for alignment purposes.
If that request is removed before the controller can execute the
transfer (e.g. ep_dequeue/ep_disable), the request will not go
through the dwc3_gadget_ep_cleanup_completed_request() handler
and will not have its needs_extra_trb flag cleared when
dwc3_gadget_giveback() is called.  This same request could be
later requeued for a new transfer that does not require an
extra TRB and if it is successfully completed, the cleanup
and TRB reclamation will incorrectly process the additional TRB
which belongs to the next request, and incorrectly advances the
TRB dequeue pointer, thereby messing up calculation of the next
requeust's actual/remaining count when it completes.

The right thing to do here is to ensure that the flag is cleared
before it is given back to the function driver.  A good place
to do that is in dwc3_gadget_del_and_unmap_request().

Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize")
Cc: stable@vger.kernel.org
Signed-off-by: Jack Pham 
Signed-off-by: Felipe Balbi