linux-stable.git/drivers/usb/dwc3, branch linux-4.1.y

usb: dwc3: pci: Properly cleanup resource

2018-05-23T01:36:32+00:00

[ Upstream commit cabdf83dadfb3d83eec31e0f0638a92dbd716435 ]

Platform device is allocated before adding resources. Make sure to
properly cleanup on error case.

Cc: 
Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()")
Signed-off-by: Thinh Nguyen 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: keystone: check return value

2018-05-23T01:36:24+00:00

[ Upstream commit 018047a1dba7636e1f7fdae2cc290a528991d648 ]

Function devm_clk_get() returns an ERR_PTR when it fails. However, in
function kdwc3_probe(), its return value is not checked, which may
result in a bad memory access bug. This patch fixes the bug.

Signed-off-by: Pan Bian 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: gadget: Set maxpacket size for ep0 IN

2018-03-04T15:28:34+00:00

[ Upstream commit 6180026341e852a250e1f97ebdcf71684a3c81b9 ]

There are 2 control endpoint structures for DWC3. However, the driver
only updates the OUT direction control endpoint structure during
ConnectDone event. DWC3 driver needs to update the endpoint max packet
size for control IN endpoint as well. If the max packet size is not
properly set, then the driver will incorrectly calculate the data
transfer size and fail to send ZLP for HS/FS 3-stage control read
transfer.

The fix is simply to update the max packet size for the ep0 IN direction
during ConnectDone event.

Cc: stable@vger.kernel.org
Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver")
Signed-off-by: Thinh Nguyen 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: replace %p with %pK

2017-07-31T17:37:52+00:00

[ Upstream commit 04fb365c453e14ff9e8a28f1c46050d920a27a4a ]

%p will leak kernel pointers, so let's not expose the information on
dmesg and instead use %pK. %pK will only show the actual addresses if
explicitly enabled under /proc/sys/kernel/kptr_restrict.

Cc: 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: exynos fix axius clock error path to do cleanup

2017-06-26T02:02:22+00:00

[ Upstream commit 8ae584d1951f241efd45499f8774fd7066f22823 ]

Axius clock error path returns without disabling clock and suspend clock.
Fix it to disable them before returning error.

Reviewed-by: Javier Martinez Canillas 
Signed-off-by: Shuah Khan 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: gadget: delay unmap of bounced requests

2017-06-13T13:29:16+00:00

[ Upstream commit de288e36fe33f7e06fa272bc8e2f85aa386d99aa ]

In the case of bounced ep0 requests, we must delay DMA operation until
after ->complete() otherwise we might overwrite contents of req->buf.

This caused problems with RNDIS gadget.

Signed-off-by: Janusz Dziedzic 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: make dwc3_debugfs_init return value be void

2017-06-08T10:12:19+00:00

[ Upstream commit 4e9f311833a946e984c82086b21b128918f4a6a4 ]

Debugfs init failure is not so important. We can continue our job on
this failure. Also no break need for debugfs_create_file call failure.

Signed-off-by: Du, Changbin 

[felipe.balbi@linux.intel.com :
	- remove out-of-memory message, we get that from OOM.
	- switch dev_err() to dev_dbg() ]

Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: gadget: make Set Endpoint Configuration macros safe

2017-05-17T19:07:00+00:00

[ Upstream commit 7369090a9fb57c3fc705ce355d2e4523a5a24716 ]

Some gadget drivers are bad, bad boys. We notice
that ADB was passing bad Burst Size which caused top
bits of param0 to be overwritten which confused DWC3
when running this command.

In order to avoid future issues, we're going to make
sure values passed by macros are always safe for the
controller. Note that ADB still needs a fix to *not*
pass bad values.

Cc:  # v3.2+
Reported-by: Mohamed Abbas 
Sugested-by: Adam Andruszak 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin

usb: dwc3: gadget: always unmap EP0 requests

2017-03-03T02:51:40+00:00

[ Upstream commit d62145929992f331fdde924d5963ab49588ccc7d ]

commit 0416e494ce7d ("usb: dwc3: ep0: correct cache
sync issue in case of ep0_bounced") introduced a bug
where we would leak DMA resources which would cause
us to starve the system of them resulting in failing
DMA transfers.

Fix the bug by making sure that we always unmap EP0
requests since those are *always* mapped.

Fixes: 0416e494ce7d ("usb: dwc3: ep0: correct cache
	sync issue in case of ep0_bounced")
Cc: 
Tested-by: Tomasz Medrek 
Reported-by: Janusz Dziedzic 
Signed-off-by: Felipe Balbi 

Signed-off-by: Sasha Levin

usb: dwc3: pci: add Intel Kabylake PCI ID

2016-08-31T23:21:09+00:00

[ Upstream commit 4491ed5042f0419b22a4b08331adb54af31e2caa ]

Intel Kabylake PCH has the same DWC3 than Intel
Sunrisepoint. Add the new ID to the supported devices.

Cc: 
Signed-off-by: Heikki Krogerus 
Signed-off-by: Felipe Balbi 
Signed-off-by: Sasha Levin