linux-stable.git/drivers/usb/dwc2, branch v4.5

usb: dwc2: USB_DWC2 should depend on HAS_DMA

2016-02-17T08:32:18+00:00

If NO_DMA=y:

    ERROR: "usb_gadget_map_request" [drivers/usb/dwc2/dwc2.ko] undefined!
    ERROR: "usb_gadget_unmap_request" [drivers/usb/dwc2/dwc2.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/usb/dwc2/dwc2.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven 
Acked-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: host: fix the data toggle error in full speed descriptor dma

2016-02-17T08:32:09+00:00

There will be data toggle error happen for full speed buld-out transfer.
The data toggle bit is saved in qh for non-control transfers, it is wrong
to  check the qtd for that case.

Also fix one static analysis tool issue after fix the data toggle error.

John Youn:
* Added WARN() to warn on improper usage of the
  dwc2_hcd_save_data_toggle() function.

Signed-off-by: Dyson Lee 
Signed-off-by: Tang, Jianqiang 
Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: host: fix logical omissions in dwc2_process_non_isoc_desc

2016-02-17T08:32:01+00:00

Fixes memory manipulation issues and makes Host DDMA bulk transfers
work.

dwc2_process_non_isoc_desc() must return non zero value ONLY when
failure happens in one of the queued descriptors. After receiving
non zero value the caller must stop processing of remaining
QTDs and their descriptors from chain.

Commit 26a19ea699060fde ("usb: dwc2: host: fix use of qtd after
free in desc dma mode") breaks non_isoc transaction completion logic
in Host DDMA mode. There were bugs before that, but after this patch
dwc2_process_non_isoc_desc() returns fail status even if descriptor
was processed normally. This causes break from loop which is processing
remaining descriptors assigned to QTD, which is not correct for QTDs
containing more than one descriptor.

Current dwc2 driver gathers queued BULK URBs until receiving URB
without URB_NO_INTERRUPT flag. Once getting it, SW creates
descriptor chain, stores it in qh structure and passes start
address to HW. Multiple URB data is contained in that chain.
Hence on getting error on descriptor after its processing by HW,
SW should go out of both loops(qh->qtd, qtd->descs) and report
the failure.

Fixes: 26a19ea699060fde ("usb: dwc2: host: fix use of qtd after free in desc dma mode")
Cc: Gregory Herrero 
Signed-off-by: Vardan Mikayelyan 
Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: Add extra delay when forcing dr_mode

2016-02-17T08:31:42+00:00

Fixes an issue found on rockchip rk3036 and rk3188 SOC platforms. For
some reason, the existing msleep(25) is not enough after the force mode.
The following patch was reported to fix the issue.

This does increase the probe delay again slightly, but not up to the
level it was before the original series of patches that this fixes. It
does not cause any other issues when tested on Synopsys HAPS and Altera
socfpga platforms.

Need to revisit this series next release to see if we can address these
issues without having an unconditional delay.

Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear force mode")
Reported-by: Caesar Wang 
Reported-by: Michael Niewoehner 
Tested-by: Heiko Stuebner 
Tested-by: Caesar Wang 
Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: Fix probe problem on bcm2835

2016-02-03T18:15:49+00:00

Fixes an issue found on Raspberry PI platform that prevents probe. Don't
skip setting the force mode if it's already set.

Fixes: 09c96980dc72 ("usb: dwc2: Add functions to set and clear force mode")
Tested-by: Heiko Stuebner 
Tested-by: Douglas Anderson 
Signed-off-by: John Youn 
Reported-by: Stefan Wahren 
Reported-by: Remi Pommarel 
Tested-by: Stefan Wahren 
Tested-by: Remi Pommarel 
Signed-off-by: Felipe Balbi

Revert "usb: dwc2: Move reset into dwc2_get_hwparams()"

2016-02-03T18:15:19+00:00

This reverts commit 263b7fb557f7 ("usb: dwc2: Move reset into
dwc2_get_hwparams()") due to regression found on bcm2835 platform. USB
ethernet fails, due to being unable to pick up proper parameters when
performing a plain reset before reading hw params.

Below shows the results of the gnptxfsiz and hptxfsiz with and before
and after reverting this (from Stefan Wahren):

So here is the probe result before Patch 1 is applied:

[    1.283148] dwc2 20980000.usb: Configuration mismatch. dr_mode forced to host
[    1.313894] dwc2 20980000.usb: gnptxfsiz=00201000
[    1.314104] dwc2 20980000.usb: hptxfsiz=00000000
[    1.353908] dwc2 20980000.usb: 256 invalid for host_nperio_tx_fifo_size. Check HW configuration.
[    1.354262] dwc2 20980000.usb: 512 invalid for host_perio_tx_fifo_size. Check HW configuration.
[    1.394249] dwc2 20980000.usb: DWC OTG Controller
[    1.394561] dwc2 20980000.usb: new USB bus registered, assigned bus number 1
[    1.394917] dwc2 20980000.usb: irq 33, io mem 0x00000000

And here is the probe result after Patch 1 is applied:

[    1.280107] dwc2 20980000.usb: Configuration mismatch. dr_mode forced to host
[    1.353949] dwc2 20980000.usb: gnptxfsiz=01001000
[    1.354166] dwc2 20980000.usb: hptxfsiz=02002000
[    1.434301] dwc2 20980000.usb: DWC OTG Controller
[    1.434616] dwc2 20980000.usb: new USB bus registered, assigned bus number 1
[    1.434973] dwc2 20980000.usb: irq 33, io mem 0x00000000

Tested-by: Heiko Stuebner 
Tested-by: Douglas Anderson 
Signed-off-by: John Youn 
Reported-by: Stefan Wahren 
Reported-by: Remi Pommarel 
Tested-by: Stefan Wahren 
Tested-by: Remi Pommarel 
Signed-off-by: Felipe Balbi

usb: dwc2: add shutdown callback to platform variant

2015-12-22T18:12:51+00:00

In specific conditions (involving usb hubs) dwc2 devices can create a
lot of interrupts, even to the point of overwhelming devices running
at low frequencies. Some devices need to do special clock handling
at shutdown-time which may bring the system clock below the threshold
of being able to handle the dwc2 interrupts. Disabling dwc2-irqs
in a shutdown callbacks prevents reboots/poweroffs from getting stuck
in such cases.

The hsotg struct already contains an unused irq element, so we can
just use it to store the irq number for the shutdown callback.

Reviewed-by: Douglas Anderson 
Acked-by: John Youn 
Signed-off-by: Heiko Stuebner 
Signed-off-by: Felipe Balbi

usb: dwc2: gadget: Repair DSTS register decoding

2015-12-22T18:03:05+00:00

The "enumspd" field is located in register DSTS[2:1], but the code
which checks the bitfield does not shift the value accordingly. This
in turn causes incorrect detection of gadget link partner speed in
dwc2_hsotg_irq_enumdone() .

Shift the value accordingly to fix the problem with speed detection.

Acked-by: John Youn 
Signed-off-by: Marek Vasut 
Cc: Felipe Balbi 
Cc: Greg Kroah-Hartman 
Cc: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: gadget: Remove call to dwc2_hsotg_init()

2015-12-22T18:02:44+00:00

Remove call to dwc2_hsotg_init() from dwc2_gadget_init(). The
gadget_init function should not access any device registers because the
mode isn't guaranteed here.

Also, this is already called elsewhere before anything starts on the
gadget so it is not necessary here.

Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi

usb: dwc2: Remove redundant reset in probe

2015-12-22T18:02:34+00:00

Reset already happens before this so just force the dr_mode.

Signed-off-by: John Youn 
Signed-off-by: Felipe Balbi