linux-stable.git/drivers/usb/core/devio.c, branch linux-2.6.34.y

usbdevfs: Correct amount of data copied to user in processcompl_compat

2014-02-10T21:11:24+00:00

commit 2102e06a5f2e414694921f23591f072a5ba7db9f upstream.

iso data buffers may have holes in them if some packets were short, so for
iso urbs we should always copy the entire buffer, just like the regular
processcompl does.

Signed-off-by: Hans de Goede 
Acked-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Paul Gortmaker

USB: pid_ns: ensure pid is not freed during kill_pid_info_as_uid

2012-08-17T19:35:29+00:00

commit aec01c5895051849ed842dc5b8794017a7751f28 upstream.

Alan Stern points out that after spin_unlock(&ps->lock) there is no
guarantee that ps->pid won't be freed.  Since kill_pid_info_as_uid() is
called after the spin_unlock(), the pid passed to it must be pinned.

Reported-by: Alan Stern 
Signed-off-by: Serge Hallyn 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Paul Gortmaker

usb: core: fix information leak to userland

2011-04-17T20:15:48+00:00

commit 886ccd4520064408ce5876cfe00554ce52ecf4a7 upstream.

Structure usbdevfs_connectinfo is copied to userland with padding byted
after "slow" field uninitialized.  It leads to leaking of contents of
kernel stack memory.

Signed-off-by: Vasiliy Kulikov 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Paul Gortmaker

USB: fix usbfs regression

2010-03-19T14:24:02+00:00

This patch (as1352) fixes a bug in the way isochronous input data is
returned to userspace for usbfs transfers.  The entire buffer must be
copied, not just the first actual_length bytes, because the individual
packets will be discontiguous if any of them are short.

Reported-by: Markus Rechberger 
Signed-off-by: Alan Stern 
CC: stable 
Signed-off-by: Greg Kroah-Hartman

USB: usbfs_snoop: add data logging back in

2010-03-02T22:54:37+00:00

Uses the new snoop function from commit 4c6e8971cbe0148085,
but includes the buffer data where appropriate, as before.

Signed-off-by: Chris Frey 
Signed-off-by: Greg Kroah-Hartman

USB: BKL removal from ioctl path of usbfs

2010-03-02T22:54:32+00:00

Total removal from the ioctl code path except for the outcall
to external modules. Locking is ensured by the normal locks
of usbfs.

Signed-off-by: Oliver Neukum 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: Reduce scope of BKL in usb ioctl handling

2010-03-02T22:54:24+00:00

This pushes BKL down in ioctl handling and drops it
for some important ioctls

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: Remove BKL from lseek implementations

2010-03-02T22:54:23+00:00

Replace it by
mutex_lock(&file->f_dentry->d_inode->i_mutex);
following the example of the generic method

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: Remove BKL from usbdev_open()

2010-03-02T22:54:22+00:00

Locking had long been changed making BKL redundant.
Simply remove it.

Signed-off-by: Oliver Neukum 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

USB: change locking for device-level autosuspend

2010-03-02T22:54:08+00:00

This patch (as1323) changes the locking requirements for
usb_autosuspend_device(), usb_autoresume_device(), and
usb_try_autosuspend_device().  This isn't a very important change;
mainly it's meant to make the locking more uniform.

The most tricky part of the patch involves changes to usbdev_open().
To avoid an ABBA locking problem, it was necessary to reduce the
region protected by usbfs_mutex.  Since that mutex now protects only
against simultaneous open and remove, this posed no difficulty -- its
scope was larger than necessary.

And it turns out that usbfs_mutex is no longer needed in
usbdev_release() at all.  The list of usbfs "ps" structures is now
protected by the device lock instead of by usbfs_mutex.

Signed-off-by: Alan Stern 
Signed-off-by: Greg Kroah-Hartman