linux-stable.git/drivers/usb/core/devices.c, branch linux-3.2.y

USB: Fix race condition when removing host controllers

2012-10-10T02:31:07+00:00

commit 0d00dc2611abbe6ad244d50569c2ee82ce42846c upstream.

This patch (as1607) fixes a race that can occur if a USB host
controller is removed while a process is reading the
/sys/kernel/debug/usb/devices file.

The usb_device_read() routine uses the bus->root_hub pointer to
determine whether or not the root hub is registered.  The is not a
valid test, because the pointer is set before the root hub gets
registered and remains set even after the root hub is unregistered and
deallocated.  As a result, usb_device_read() or usb_device_dump() can
access freed memory, causing an oops.

The patch changes the test to use the hcd->rh_registered flag, which
does get set and cleared at the appropriate times.  It also makes sure
to hold the usb_bus_list_lock mutex while setting the flag, so that
usb_device_read() will become aware of new root hubs as soon as they
are registered.

Signed-off-by: Alan Stern 
Reported-by: Don Zickus 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

USB: use usb_endpoint_maxp() instead of le16_to_cpu()

2011-08-23T16:47:40+00:00

Now ${LINUX}/drivers/usb/* can use usb_endpoint_maxp(desc) to get maximum packet size
instead of le16_to_cpu(desc->wMaxPacketSize).
This patch fix it up

Cc: Armin Fuerst 
Cc: Pavel Machek 
Cc: Johannes Erdfelt 
Cc: Vojtech Pavlik 
Cc: Oliver Neukum 
Cc: David Kubicek 
Cc: Johan Hovold 
Cc: Brad Hards 
Acked-by: Felipe Balbi 
Cc: Sebastian Andrzej Siewior 
Cc: Thomas Dahlmann 
Cc: David Brownell 
Cc: David Lopo 
Cc: Alan Stern 
Cc: Michal Nazarewicz 
Cc: Xie Xiaobo 
Cc: Li Yang 
Cc: Jiang Bo 
Cc: Yuan-hsin Chen 
Cc: Darius Augulis 
Cc: Xiaochen Shen 
Cc: Yoshihiro Shimoda 
Cc: OKI SEMICONDUCTOR, 
Cc: Robert Jarzmik 
Cc: Ben Dooks 
Cc: Thomas Abraham 
Cc: Herbert Pötzl 
Cc: Arnaud Patard 
Cc: Roman Weissgaerber 
Acked-by: Sarah Sharp 
Cc: Tony Olech 
Cc: Florian Floe Echtler 
Cc: Christian Lucht 
Cc: Juergen Stuber 
Cc: Georges Toth 
Cc: Bill Ryder 
Cc: Kuba Ober 
Cc: Inaky Perez-Gonzalez 
Signed-off-by: Kuninori Morimoto 
Signed-off-by: Greg Kroah-Hartman

Merge 2.6.39-rc4 into usb-next

2011-04-19T12:50:38+00:00

This is needed to help resolve some xhci issues and other minor
differences.

Signed-off-by: Greg Kroah-Hartman

USB: change the way we initialize format strings

2011-04-13T23:18:25+00:00

Changing initialization from

	static const char *string = "blah";

to

	static const char string[] = "blah";

saves us one pointer per each string.

Signed-off-by: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman

USB: fix formatting of SuperSpeed endpoints in /proc/bus/usb/devices

2011-04-13T23:13:46+00:00

Isochronous and interrupt SuperSpeed endpoints use the same mechanisms
for decoding bInterval values as HighSpeed ones so adjust the code
accordingly.

Also bandwidth reservation for SuperSpeed matches highspeed, not
low/full speed.

Signed-off-by: Dmitry Torokhov 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

BKL: remove extraneous #include

2010-11-17T16:59:32+00:00

The big kernel lock has been removed from all these files at some point,
leaving only the #include.

Remove this too as a cleanup.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Linus Torvalds

USB: teach "devices" file about Wireless and SuperSpeed USB

2010-10-22T17:21:40+00:00

The /sys/kernel/debug/usb/devices file doesn't know about Wireless or
SuperSpeed USB.  This patch (as1416b) teaches it, and updates the
Documentation/usb/proc_sub_info.txt file accordingly.

Signed-off-by: Alan Stern 
CC: David Vrabel 
CC: Sarah Sharp 
Signed-off-by: Greg Kroah-Hartman

USB: devices: fix Coding Styles

2010-05-20T20:21:38+00:00

Fixed coding styles in the config usb driver.

Signed-off-by: Carlos Sánchez Acosta 
Signed-off-by: Alejandro Sánchez Acosta 
Signed-off-by: Greg Kroah-Hartman

USB: make hcd.h public (drivers dependency)

2010-05-20T20:21:30+00:00

The usbcore headers: hcd.h and hub.h are shared between usbcore,
HCDs and a couple of other drivers (e.g. USBIP modules).
So, it makes sense to move them into a more public location and
to cleanup dependency of those modules on kernel internal headers.
This patch moves hcd.h from drivers/usb/core into include/linux/usb/

Signed-of-by: Eric Lescouet 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30T13:02:32+00:00

percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files.  percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.

percpu.h -> slab.h dependency is about to be removed.  Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability.  As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.

  http://userweb.kernel.org/~tj/misc/slabh-sweep.py

The script does the followings.

* Scan files for gfp and slab usages and update includes such that
  only the necessary includes are there.  ie. if only gfp is used,
  gfp.h, if slab is used, slab.h.

* When the script inserts a new include, it looks at the include
  blocks and try to put the new include such that its order conforms
  to its surrounding.  It's put in the include block which contains
  core kernel includes, in the same order that the rest are ordered -
  alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
  doesn't seem to be any matching order.

* If the script can't find a place to put a new include (mostly
  because the file doesn't have fitting include block), it prints out
  an error message indicating which .h file needs to be added to the
  file.

The conversion was done in the following steps.

1. The initial automatic conversion of all .c files updated slightly
   over 4000 files, deleting around 700 includes and adding ~480 gfp.h
   and ~3000 slab.h inclusions.  The script emitted errors for ~400
   files.

2. Each error was manually checked.  Some didn't need the inclusion,
   some needed manual addition while adding it to implementation .h or
   embedding .c file was more appropriate for others.  This step added
   inclusions to around 150 files.

3. The script was run again and the output was compared to the edits
   from #2 to make sure no file was left behind.

4. Several build tests were done and a couple of problems were fixed.
   e.g. lib/decompress_*.c used malloc/free() wrappers around slab
   APIs requiring slab.h to be added manually.

5. The script was run on all .h files but without automatically
   editing them as sprinkling gfp.h and slab.h inclusions around .h
   files could easily lead to inclusion dependency hell.  Most gfp.h
   inclusion directives were ignored as stuff from gfp.h was usually
   wildly available and often used in preprocessor macros.  Each
   slab.h inclusion directive was examined and added manually as
   necessary.

6. percpu.h was updated not to include slab.h.

7. Build test were done on the following configurations and failures
   were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
   distributed build env didn't work with gcov compiles) and a few
   more options had to be turned off depending on archs to make things
   build (like ipr on powerpc/64 which failed due to missing writeq).

   * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
   * powerpc and powerpc64 SMP allmodconfig
   * sparc and sparc64 SMP allmodconfig
   * ia64 SMP allmodconfig
   * s390 SMP allmodconfig
   * alpha SMP allmodconfig
   * um on x86_64 SMP allmodconfig

8. percpu.h modifications were reverted so that it could be applied as
   a separate patch and serve as bisection point.

Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.

Signed-off-by: Tejun Heo 
Guess-its-ok-by: Christoph Lameter 
Cc: Ingo Molnar 
Cc: Lee Schermerhorn