linux-stable.git/drivers/usb/class, branch v4.10.8

USB: usbtmc: fix probe error path

2017-03-30T07:44:05+00:00

commit 2e47c53503eb9faff42b3cfa144a833344dd1f89 upstream.

Make sure to initialise the return value to avoid having allocation
failures going unnoticed when allocating interrupt-endpoint resources.

This prevents use-after-free or worse when the device is later unbound.

Fixes: dbf3e7f654c0 ("Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.")
Cc: Dave Penkler 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: usbtmc: add missing endpoint sanity check

2017-03-30T07:44:05+00:00

commit 687e0687f71ec00e0132a21fef802dee88c2f1ad upstream.

USBTMC devices are required to have a bulk-in and a bulk-out endpoint,
but the driver failed to verify this, something which could lead to the
endpoint addresses being taken from uninitialised memory.

Make sure to zero all private data as part of allocation, and add the
missing endpoint sanity check.

Note that this also addresses a more recently introduced issue, where
the interrupt-in-presence flag would also be uninitialised whenever the
optional interrupt-in endpoint is not present. This in turn could lead
to an interrupt urb being allocated, initialised and submitted based on
uninitialised values.

Fixes: dbf3e7f654c0 ("Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.")
Fixes: 5b775f672cc9 ("USB: add USB test and measurement class driver")
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: add device id for GW Instek AFG-125

2016-12-05T15:32:51+00:00

Add device-id entry for GW Instek AFG-125, which has a byte swapped
bInterfaceSubClass (0x20).

Signed-off-by: Nathaniel Quillin 
Acked-by: Oliver Neukum 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

cdc-acm: handle read pipe errors

2016-11-21T10:36:16+00:00

Read urbs are submitted back only on success, causing read pipe
running out of urbs after few errors. No more characters can
be read from tty device then until it is reopened and no errors
are reported.
Fix that by always submitting urbs back and clearing stall on
-EPIPE.

Signed-off-by: Ladislav Michl 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

cdc-acm: remove is_int_ep from acm structure

2016-11-21T10:36:15+00:00

is_int_ep is used only in acm_probe, no need to store it in device data.

Signed-off-by: Ladislav Michl 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

cdc-acm: store in and out pipes in acm structure

2016-11-21T10:36:15+00:00

Clearing stall needs pipe descriptor, store it in acm structure.

Signed-off-by: Ladislav Michl 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

cdc-acm: refactor killing urbs

2016-11-21T10:36:15+00:00

Move urb killing code into separate function and use it
instead of copying that code pattern over.

Signed-off-by: Ladislav Michl 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

cdc-acm: avoid interface_to_usbdev call

2016-11-21T10:36:15+00:00

Pointer to usb_device is already stored in acm structure.

Signed-off-by: Ladislav Michl 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

cdc-acm: reindent log messages

2016-11-21T10:36:15+00:00

Use only one tab to indent dev_{(v)dbg,err} parameters.

Signed-off-by: Ladislav Michl 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

Merge 4.9-rc5 into usb-next

2016-11-14T07:11:29+00:00

We want/need the USB fixes in here as well, for testing and merge
issues.

Signed-off-by: Greg Kroah-Hartman