linux-stable.git/drivers/usb/class, branch linux-3.13.y

usb: cdc-wdm: resp_count can be 0 even if WDM_READ is set

2014-02-06T19:33:52+00:00

commit f563926fed982f26b391ca42493f55f2447f1b0a upstream.

Do not decrement resp_count if it's already 0.

We set resp_count to 0 when the device is closed.  The next open and
read will try to clear the WDM_READ flag if there was leftover data
in the read buffer. This fix is necessary to prevent resubmitting
the read URB in a tight loop because resp_count becomes negative.

The bug can easily be triggered from userspace by not reading all
data in the read buffer, and then closing and reopening the chardev.

Fixes: 8dd5cd5395b9 ("usb: cdc-wdm: avoid hanging on zero length reads")
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-wdm: avoid hanging on zero length reads

2014-02-06T19:33:52+00:00

commit 8dd5cd5395b90070d98149d0a94e5981a74cd2ec upstream.

commit 73e06865ead1 ("USB: cdc-wdm: support back-to-back
USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications") implemented
queued response handling. This added a new requirement: The read
urb must be resubmitted every time we clear the WDM_READ flag if
the response counter indicates that the device is waiting for a
read.

Fix by factoring out the code handling the WMD_READ clearing and
possible urb submission, calling it everywhere we clear the flag.

Without this fix, the driver ends up in a state where the read urb
is inactive, but the response counter is positive after a zero
length read.  This prevents the read urb from ever being submitted
again and the driver appears to be hanging.

Fixes: 73e06865ead1 ("USB: cdc-wdm: support back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications")
Cc: Greg Suarez 
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-wdm: manage_power should always set needs_remote_wakeup

2013-12-09T21:14:11+00:00

Cc: stable 
Reported-by: Oliver Neukum 
Signed-off-by: Bjørn Mork 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: Added support for the Lenovo RD02-D400 USB Modem

2013-12-05T00:53:03+00:00

Signed-off-by: David Cluytens 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-wdm: ignore speed change notifications

2013-10-30T00:02:41+00:00

The only notification supported by the Device Management class is
Response Available. But this driver is also used as a subdriver of
other CDC classes, allowing notifications like Speed Change and
Network Connection. This results in log messages which are only
confusing to an end user:

 [66255.801874] cdc_mbim 1-3:1.5: unknown notification 42 received: index 5 len 8

These drivers use cdc-wdm as a subdriver to allow access to an
embedded management protocol, and all management is expected to
use this protocol. There is therefore no need to handle any of
these optional CDC notifications. Instead we can let the cdc-wdm
driver recognize them and log a debug level message instead of an
error.

Reported-by: Rob Gardner 
Signed-off-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: support back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications

2013-10-30T00:02:41+00:00

Some MBIM devices send back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications
when sending a message over multiple fragments or when there are unsolicited
messages available.

Count up the number of USB_CDC_NOTIFY_RESPONSE_AVAILABLE notifications received
and decrement the count and submit the urb for the next response each time userspace
completes a read the response.

Signed-off-by: Greg Suarez 
Acked-by: Bjørn Mork 
Signed-off-by: Greg Kroah-Hartman

USB: usbtmc: fix up attribute permissions

2013-08-25T22:12:03+00:00

In auditing the usbtmc sysfs files, a bunch of them were being created
as "read only", yet they have logic to handle writing to.  So fix them
up by setting the permissions properly.

Signed-off-by: Greg Kroah-Hartman

Merge 3.11-rc6 into usb-next

2013-08-19T03:33:01+00:00

We want these USB fixes in this branch as well.

Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: fix race between interrupt handler and tasklet

2013-08-12T22:41:07+00:00

Both could want to submit the same URB. Some checks of the flag
intended to prevent that were missing.

Signed-off-by: Oliver Neukum 
CC: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

USB: usbtmc: fix big-endian probe of Rigol devices

2013-08-12T20:52:35+00:00

Fix probe of Rigol devices on big-endian machines. A quirk for these
devices was introduced by commit c2e314835 ("USB: usbtmc: Set
rigol_quirk if device is listed") but was only enabled on little-endian
machines.

Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman