linux-stable.git/drivers/usb/class, branch linux-3.1.y

usb: cdc-acm: Fix acm_tty_hangup() vs. acm_tty_close() race

2012-01-12T19:33:46+00:00

[Not upstream s it was fixed differently there for 3.3 with a much more
"intrusive" rework of the driver - gregkh]

There is a race condition involving acm_tty_hangup() and acm_tty_close()
where hangup() would attempt to access tty->driver_data without proper
locking and NULL checking after close() has potentially already set it
to NULL.  One possibility to (sporadically) trigger this behavior is to
perform a suspend/resume cycle with a running WWAN data connection.

This patch addresses the issue by introducing a NULL check for
tty->driver_data in acm_tty_hangup() protected by open_mutex and exiting
gracefully when hangup() is invoked on a device that has already been
closed.

Signed-off-by: Thilo-Alexander Ginkel 
Signed-off-by: Greg Kroah-Hartman

drivers/usb/class/cdc-acm.c: clear dangling pointer

2012-01-12T19:33:25+00:00

commit e7c8e8605d0bafc705ff27f9da98a1668427cc0f upstream.

On some failures, the country_code field of an acm structure is freed
without freeing the acm structure itself.  Elsewhere, operations including
memcpy and kfree are performed on the country_code field.  The patch sets
the country_code field to NULL when it is freed, and likewise sets the
country_code_size field to 0.

Signed-off-by: Julia Lawall 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: add IDs for Motorola H24 HSPA USB module.

2011-12-21T20:58:36+00:00

commit 6abff5dc4d5a2c90e597137ce8987e7fd439259b upstream.

Add USB IDs for Motorola H24 HSPA USB module.

Signed-off-by: Krzysztof Hałasa 
Acked-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: Fix disconnect() vs close() race

2011-11-26T17:08:38+00:00

commit 5dc2470c602da8851907ec18942cd876c3b4ecc1 upstream.

There's a race between the USB disconnect handler and the TTY close
handler which may cause the acm object to be freed while it's still
being used. This may lead to things like

http://article.gmane.org/gmane.linux.usb.general/54250

and

https://lkml.org/lkml/2011/5/29/64

This is the simplest fix I could come up with. Holding on to open_mutex
while closing the TTY device prevents acm_disconnect() from freeing the
acm object between acm->port.count drops to 0 and the TTY side of the
cleanups are finalized.

Signed-off-by: Havard Skinnemoen 
Cc: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman

usb: cdc-acm: Owen SI-30 support

2011-11-11T17:42:37+00:00

commit 65e52f41fa944cef2e6d4222b8c54f46cc575214 upstream.

here is the patch to support Owen SI-30 device.
This is a pulse counter controller.
http://www.owen.ru/en/catalog/93788515

usb-drivers output:
T:  Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#=  4 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=02(commc) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=03eb ProdID=0030 Rev=01.01
C:  #Ifs= 2 Cfg#= 1 Atr=c0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=02 Prot=00 Driver=cdc_acm
I:  If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_acm

This patch is installed on my home system which receives data from this
controller connected to cold water counter.

Signed-off-by: Denis Pershin 
Signed-off-by: Greg Kroah-Hartman

USB: assign instead of equal in usbtmc.c

2011-08-08T19:34:45+00:00

Assign operator instead of equality test in the usbtmc_ioctl_abort_bulk_in() function.

Signed-off-by: Maxim A. Nikulin 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

usb/class: use printk_ratelimited() instead of printk_ratelimit()

2011-07-01T21:43:24+00:00

Since printk_ratelimit() shouldn't be used anymore (see comment in
include/linux/printk.h), replace it with printk_ratelimited()

Signed-off-by: Manuel Zerpies 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: Adding second ACM channel support for Nokia E7 and C7

2011-06-06T22:59:41+00:00

This adds the Nokia E7 and C7 to the list of devices in cdc-acm, allowing
the secondary ACM channel on the device to be exposed. Without this patch
the ACM driver won't claim this secondary channel as it's marked as
having a vendor-specific protocol.

Signed-off-by: Toby Gray 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: cdc_acm: Fix oops when Droids MuIn LCD is connected

2011-05-11T22:14:28+00:00

The Droids MuIn LCD operates like a serial remote terminal.
Data received are displayed directly on the LCD. This patch
fixes the kernel null pointer oops when it is plugged in.

Add NO_DATA_INTERFACE quirk to tell the driver that "control"
and "data" interfaces are not separated for this device, which
prevents dereferencing a null pointer in the device probe code.

Signed-off-by: Erik Slagter 
Signed-off-by: Maxin B. John 
Tested-by: Erik Slagter 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-wdm: reset handling according to new requirements

2011-04-30T00:04:40+00:00

This patch
- ensures no IO takes place during resets
- reports resets to user space

Signed-off-by: Oliver Neukum 
Signed-off-by: Greg Kroah-Hartman