linux-stable.git/drivers/usb/chipidea, branch v5.5

usb: chipidea: host: Disable port power only if previously enabled

2019-12-30T19:02:01+00:00

On shutdown, ehci_power_off() is called unconditionally to power off
each port, even if it was never called to power on the port.
For chipidea, this results in a call to ehci_ci_portpower() with a request
to power off ports even if the port was never powered on.
This results in the following warning from the regulator code.

WARNING: CPU: 0 PID: 182 at drivers/regulator/core.c:2596 _regulator_disable+0x1a8/0x210
unbalanced disables for usb_otg2_vbus
Modules linked in:
CPU: 0 PID: 182 Comm: init Not tainted 5.4.6 #1
Hardware name: Freescale i.MX7 Dual (Device Tree)
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0xe0/0x10c)
[] (dump_stack) from [] (__warn+0xf4/0x10c)
[] (__warn) from [] (warn_slowpath_fmt+0x78/0xbc)
[] (warn_slowpath_fmt) from [] (_regulator_disable+0x1a8/0x210)
[] (_regulator_disable) from [] (regulator_disable+0x38/0xe8)
[] (regulator_disable) from [] (ehci_ci_portpower+0x38/0xdc)
[] (ehci_ci_portpower) from [] (ehci_port_power+0x50/0xa4)
[] (ehci_port_power) from [] (ehci_silence_controller+0x5c/0xc4)
[] (ehci_silence_controller) from [] (ehci_stop+0x3c/0xcc)
[] (ehci_stop) from [] (usb_remove_hcd+0xe0/0x19c)
[] (usb_remove_hcd) from [] (host_stop+0x38/0xa8)
[] (host_stop) from [] (ci_hdrc_remove+0x44/0xe4)
...

Keeping track of the power enable state avoids the warning and traceback.

Fixes: c8679a2fb8dec ("usb: chipidea: host: add portpower override")
Cc: Michael Grzeschik 
Cc: Peter Chen 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck 
Acked-by: Peter Chen 
Link: https://lore.kernel.org/r/20191226155754.25451-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: imx: pinctrl for HSIC is optional

2019-11-18T09:40:27+00:00

For imx chipidea controllers, if they use mxs PHY, they need pinctrl
for HSIC. Otherwise, it doesn't need pinctrl and usbmisc control. Like
imx7d and imx8mm.

Reported-by: André Draszik 
Signed-off-by: Peter Chen

usb: chipidea: imx: refine the error handling for hsic

2019-11-18T08:45:30+00:00

- -EPROBE_DEFER is an error, but without need show error message
- If pintrol is not existed, as pintrol is NULL

Signed-off-by: Peter Chen

usb: chipidea: imx: change hsic power regulator as optional

2019-11-18T08:45:30+00:00

Not every platform needs this regulator.

Signed-off-by: Peter Chen

usb: chipidea: imx: check data->usbmisc_data against NULL before access

2019-11-18T08:45:30+00:00

As usbmisc_data is optional, so add the check before access its member,
this fix below static checker warning:
drivers/usb/chipidea/ci_hdrc_imx.c:438 ci_hdrc_imx_probe()
warn: 'data->usbmisc_data' can also be NULL
which is introduced by Patch 15b80f7c3a7f:
"usb: chipidea: imx: enable vbus and id wakeup only for OTG events"

Reported-by: Dan Carpenter 
Signed-off-by: Li Jun 
Signed-off-by: Peter Chen

usb: chipidea: core: change vbus-regulator as optional

2019-11-18T08:45:30+00:00

Vbus regualtor is an optional regulator, for platforms, which
doesn't have this regulator, it will get a dummy regulator and
show warning message.

Signed-off-by: Peter Chen

usb: chipidea: imx: enable vbus and id wakeup only for OTG events

2019-11-18T08:45:30+00:00

If ID or VBUS is from external block, don't enable its wakeup
because it isn't used at all.

Signed-off-by: Li Jun 
Signed-off-by: Peter Chen

usb: chipidea: udc: protect usb interrupt enable

2019-11-18T08:45:30+00:00

We hit the problem with below sequence:
- ci_udc_vbus_session() update vbus_active flag and ci->driver
is valid,
- before calling the ci_hdrc_gadget_connect(),
usb_gadget_udc_stop() is called by application remove gadget
driver,
- ci_udc_vbus_session() will contine do ci_hdrc_gadget_connect() as
gadget_ready is 1, so udc interrupt is enabled, but ci->driver is
NULL.
- USB connection irq generated but ci->driver is NULL.

As udc irq only should be enabled when gadget driver is binded, so
add spinlock to protect the usb irq enable for vbus session handling.

Signed-off-by: Jun Li 
Signed-off-by: Peter Chen

usb: chipidea: udc: add new API ci_hdrc_gadget_connect

2019-11-18T08:45:30+00:00

This API is used enable device function, it is called at below
situations:
- VBUS is connected during boots up
- Hot plug occurs during runtime

Signed-off-by: Peter Chen 
Signed-off-by: Jun Li

usb: chipidea: debug: create debugfs directory under usb root

2019-11-14T03:14:54+00:00

Move it's directory from the root of the debugfs filesystem into
the root of usb

Signed-off-by: Chunfeng Yun 
Link: https://lore.kernel.org/r/1573541519-28488-2-git-send-email-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman