linux-stable.git/drivers/usb/chipidea, branch v4.4.201

usb: chipidea: udc: workaround for endpoint conflict issue

2019-07-10T07:56:31+00:00

commit c19dffc0a9511a7d7493ec21019aefd97e9a111b upstream.

An endpoint conflict occurs when the USB is working in device mode
during an isochronous communication. When the endpointA IN direction
is an isochronous IN endpoint, and the host sends an IN token to
endpointA on another device, then the OUT transaction may be missed
regardless the OUT endpoint number. Generally, this occurs when the
device is connected to the host through a hub and other devices are
connected to the same hub.

The affected OUT endpoint can be either control, bulk, isochronous, or
an interrupt endpoint. After the OUT endpoint is primed, if an IN token
to the same endpoint number on another device is received, then the OUT
endpoint may be unprimed (cannot be detected by software), which causes
this endpoint to no longer respond to the host OUT token, and thus, no
corresponding interrupt occurs.

There is no good workaround for this issue, the only thing the software
could do is numbering isochronous IN from the highest endpoint since we
have observed most of device number endpoint from the lowest.

Cc:  #v3.14+
Cc: Fabio Estevam 
Cc: Greg KH 
Cc: Sergei Shtylyov 
Cc: Jun Li 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-04-27T07:33:49+00:00

[ Upstream commit 68ef236274793066b9ba3154b16c0acc1c891e5c ]

According to the chipidea driver bindings, the USB PHY is specified via
the "phys" phandle node. However, this only takes effect for USB PHYs
that use the common PHY framework. For legacy USB PHYs, a simple lookup
based on the USB PHY type is done instead.

This does not play out well when more than one USB PHY is registered,
since the first registered PHY matching the type will always be
returned regardless of what the driver was bound to.

Fix this by looking up the PHY based on the "phys" phandle node.
Although generic PHYs are rather matched by their "phys-name" and not
the "phys" phandle directly, there is no helper for similar lookup on
legacy PHYs and it's probably not worth the effort to add it.

When no legacy USB PHY is found by phandle, fallback to grabbing any
registered USB2 PHY. This ensures backward compatibility if some users
were actually relying on this mechanism.

Signed-off-by: Paul Kocialkowski 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

usb: chipidea: Prevent unbalanced IRQ disable

2018-11-21T08:27:33+00:00

[ Upstream commit 8b97d73c4d72a2abf58f8e49062a7ee1e5f1334e ]

The ChipIdea IRQ is disabled before scheduling the otg work and
re-enabled on otg work completion. However if the job is already
scheduled we have to undo the effect of disable_irq int order to
balance the IRQ disable-depth value.

Fixes: be6b0c1bd0be ("usb: chipidea: using one inline function to cover queue work operations")
Signed-off-by: Loic Poulain 
Signed-off-by: Peter Chen 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: properly handle host or gadget initialization failure

2018-04-13T17:50:07+00:00

[ Upstream commit c4a0bbbdb7f6e3c37fa6deb3ef28c5ed99da6175 ]

If ci_hdrc_host_init() or ci_hdrc_gadget_init() returns error and the
error != -ENXIO, as Peter pointed out, "it stands for initialization
for host or gadget has failed", so we'd better return failure rather
continue.

And before destroying the otg, i.e ci_hdrc_otg_destroy(ci), we should
also check ci->roles[CI_ROLE_GADGET].

Signed-off-by: Jisheng Zhang 
Signed-off-by: Peter Chen 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: vbus event may exist before starting gadget

2017-10-08T08:14:18+00:00

[ Upstream commit c3b674a04b8ab62a1d35e86714d466af0a0ecc18 ]

At some situations, the vbus may already be there before starting
gadget. So we need to check vbus event after switching to gadget in
order to handle missing vbus event. The typical use cases are plugging
vbus cable before driver load or the vbus has already been there
after stopping host but before starting gadget.

Signed-off-by: Peter Chen 
Tested-by: Stephen Boyd 
Reported-by: Stephen Boyd 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: debug: check before accessing ci_role

2017-06-14T11:16:22+00:00

commit 0340ff83cd4475261e7474033a381bc125b45244 upstream.

ci_role BUGs when the role is >= CI_ROLE_END.

Signed-off-by: Michael Thalmeier 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: fix NULL pointer dereference if udc_start failed

2017-06-14T11:16:22+00:00

commit aa1f058d7d9244423b8c5a75b9484b1115df7f02 upstream.

Fix below NULL pointer dereference. we set ci->roles[CI_ROLE_GADGET]
too early in ci_hdrc_gadget_init(), if udc_start() fails due to some
reason, the ci->roles[CI_ROLE_GADGET] check in  ci_hdrc_gadget_destroy
can't protect us.

We fix this issue by only setting ci->roles[CI_ROLE_GADGET] if
udc_start() succeed.

[    1.398550] Unable to handle kernel NULL pointer dereference at
virtual address 00000000
...
[    1.448600] PC is at dma_pool_free+0xb8/0xf0
[    1.453012] LR is at dma_pool_free+0x28/0xf0
[    2.113369] [] dma_pool_free+0xb8/0xf0
[    2.118857] [] destroy_eps+0x4c/0x68
[    2.124165] [] ci_hdrc_gadget_destroy+0x28/0x50
[    2.130461] [] ci_hdrc_probe+0x588/0x7e8
[    2.136129] [] platform_drv_probe+0x50/0xb8
[    2.142066] [] driver_probe_device+0x1fc/0x2a8
[    2.148270] [] __device_attach_driver+0x9c/0xf8
[    2.154563] [] bus_for_each_drv+0x58/0x98
[    2.160317] [] __device_attach+0xc4/0x138
[    2.166072] [] device_initial_probe+0x10/0x18
[    2.172185] [] bus_probe_device+0x94/0xa0
[    2.177940] [] device_add+0x3f0/0x560
[    2.183337] [] platform_device_add+0x180/0x240
[    2.189541] [] ci_hdrc_add_device+0x440/0x4f8
[    2.195654] [] ci_hdrc_usb2_probe+0x13c/0x2d8
[    2.201769] [] platform_drv_probe+0x50/0xb8
[    2.207705] [] driver_probe_device+0x1fc/0x2a8
[    2.213910] [] __driver_attach+0xac/0xb0
[    2.219575] [] bus_for_each_dev+0x60/0xa0
[    2.225329] [] driver_attach+0x20/0x28
[    2.230816] [] bus_add_driver+0x1d0/0x238
[    2.236571] [] driver_register+0x60/0xf8
[    2.242237] [] __platform_driver_register+0x44/0x50
[    2.248891] [] ci_hdrc_usb2_driver_init+0x18/0x20
[    2.255365] [] do_one_initcall+0x38/0x128
[    2.261121] [] kernel_init_freeable+0x1ac/0x250
[    2.267414] [] kernel_init+0x10/0x100
[    2.272810] [] ret_from_fork+0x10/0x50

Fixes: 3f124d233e97 ("usb: chipidea: add role init and destroy APIs")
Signed-off-by: Jisheng Zhang 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: Handle extcon events properly

2017-05-14T11:32:56+00:00

commit a89b94b53371bbfa582787c2fa3378000ea4263d upstream.

We're currently emulating the vbus and id interrupts in the OTGSC
read API, but we also need to make sure that if we're handling
the events with extcon that we don't enable the interrupts for
those events in the hardware. Therefore, properly emulate this
register if we're using extcon, but don't enable the interrupts.
This allows me to get my cable connect/disconnect working
properly without getting spurious interrupts on my device that
uses an extcon for these two events.

Acked-by: Peter Chen 
Cc: Greg Kroah-Hartman 
Cc: "Ivan T. Ivanov" 
Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect")
Signed-off-by: Stephen Boyd 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: Only read/write OTGSC from one place

2017-05-14T11:32:56+00:00

commit f60f8ccd54e03c1afafb2b20ceb029a0eaf7a134 upstream.

With the id and vbus detection done via extcon we need to make
sure we poll the status of OTGSC properly by considering what the
extcon is saying, and not just what the register is saying. Let's
move this hw_wait_reg() function to the only place it's used and
simplify it for polling the OTGSC register. Then we can make
certain we only use the hw_read_otgsc() API to read OTGSC, which
will make sure we properly handle extcon events.

Acked-by: Peter Chen 
Cc: Greg Kroah-Hartman 
Cc: "Ivan T. Ivanov" 
Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect")
Signed-off-by: Stephen Boyd 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

Revert "usb: chipidea: imx: enable CI_HDRC_SET_NON_ZERO_TTHA"

2017-02-26T10:07:51+00:00

commit 1bc7da87c7410c6990c3251589e3854e64c55af2 upstream.

This reverts commit e765bfb73ff7.

In the most of cases, we only use one transaction per frame and the
frame rate may be high, If the platforms want to support multiple
transactions but less frame rate cases like [1] and [2], it can set
"non-zero-ttctrl-ttha" at dts.

[1] http://www.spinics.net/lists/linux-usb/msg123125.html
[2] http://www.spinics.net/lists/linux-usb/msg118679.html

Signed-off-by: Peter Chen 
Cc: Martin Fuzzey 
Signed-off-by: Greg Kroah-Hartman