linux-stable.git/drivers/usb/chipidea, branch v4.12

usb: chipidea: core: check before accessing ci_role in ci_role_show

2017-05-23T00:36:54+00:00

ci_role BUGs when the role is >= CI_ROLE_END.
This is the case while the role is changing.

Signed-off-by: Michael Thalmeier 
Signed-off-by: Peter Chen

usb: chipidea: debug: check before accessing ci_role

2017-05-23T00:36:46+00:00

ci_role BUGs when the role is >= CI_ROLE_END.

Cc: stable@vger.kernel.org  #v3.10+
Signed-off-by: Michael Thalmeier 
Signed-off-by: Peter Chen

usb: chipidea: udc: fix NULL pointer dereference if udc_start failed

2017-05-18T01:07:14+00:00

Fix below NULL pointer dereference. we set ci->roles[CI_ROLE_GADGET]
too early in ci_hdrc_gadget_init(), if udc_start() fails due to some
reason, the ci->roles[CI_ROLE_GADGET] check in  ci_hdrc_gadget_destroy
can't protect us.

We fix this issue by only setting ci->roles[CI_ROLE_GADGET] if
udc_start() succeed.

[    1.398550] Unable to handle kernel NULL pointer dereference at
virtual address 00000000
...
[    1.448600] PC is at dma_pool_free+0xb8/0xf0
[    1.453012] LR is at dma_pool_free+0x28/0xf0
[    2.113369] [] dma_pool_free+0xb8/0xf0
[    2.118857] [] destroy_eps+0x4c/0x68
[    2.124165] [] ci_hdrc_gadget_destroy+0x28/0x50
[    2.130461] [] ci_hdrc_probe+0x588/0x7e8
[    2.136129] [] platform_drv_probe+0x50/0xb8
[    2.142066] [] driver_probe_device+0x1fc/0x2a8
[    2.148270] [] __device_attach_driver+0x9c/0xf8
[    2.154563] [] bus_for_each_drv+0x58/0x98
[    2.160317] [] __device_attach+0xc4/0x138
[    2.166072] [] device_initial_probe+0x10/0x18
[    2.172185] [] bus_probe_device+0x94/0xa0
[    2.177940] [] device_add+0x3f0/0x560
[    2.183337] [] platform_device_add+0x180/0x240
[    2.189541] [] ci_hdrc_add_device+0x440/0x4f8
[    2.195654] [] ci_hdrc_usb2_probe+0x13c/0x2d8
[    2.201769] [] platform_drv_probe+0x50/0xb8
[    2.207705] [] driver_probe_device+0x1fc/0x2a8
[    2.213910] [] __driver_attach+0xac/0xb0
[    2.219575] [] bus_for_each_dev+0x60/0xa0
[    2.225329] [] driver_attach+0x20/0x28
[    2.230816] [] bus_add_driver+0x1d0/0x238
[    2.236571] [] driver_register+0x60/0xf8
[    2.242237] [] __platform_driver_register+0x44/0x50
[    2.248891] [] ci_hdrc_usb2_driver_init+0x18/0x20
[    2.255365] [] do_one_initcall+0x38/0x128
[    2.261121] [] kernel_init_freeable+0x1ac/0x250
[    2.267414] [] kernel_init+0x10/0x100
[    2.272810] [] ret_from_fork+0x10/0x50

Cc: stable 
Fixes: 3f124d233e97 ("usb: chipidea: add role init and destroy APIs")
Signed-off-by: Jisheng Zhang 
Signed-off-by: Peter Chen

usb: chipidea: imx: Do not access CLKONOFF on i.MX51

2017-05-18T01:06:25+00:00

Unlike i.MX53, i.MX51's USBOH3 register file does not implemenent
registers past offset 0x018, which includes
MX53_USB_CLKONOFF_CTRL_OFFSET and trying to access that register on
said platform results in external abort.

Fix it by enabling CLKONOFF accessing codepath only for i.MX53.

Cc: stable 
Fixes 3be3251db088 ("usb: chipidea: imx: Disable internal 60Mhz
	clock with ULPI PHY")
Cc: cphealy@gmail.com
Cc: Greg Kroah-Hartman 
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov 
Signed-off-by: Peter Chen

Merge tag 'usb-ci-v4.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb into usb-next

2017-04-18T14:52:20+00:00

Peter writes:

Two changes for this v4.12-rc1:
- Add sysfs entry for role switch
- Update gadget state after gadget back from suspend

usb: chipidea: core: add sysfs group

2017-04-14T01:26:37+00:00

Sometimes, the user needs to adjust some properties for controllers, eg
the role for controller, we add sysfs group for them.

The attribute 'role' is used to switch host/gadget role dynamically, the
uewr can read the current role, and write the other role compare to
current one to finish the switch.

Signed-off-by: Peter Chen

usb: chipidea: use bus->sysdev for DMA configuration

2017-03-23T07:20:21+00:00

Set the dma for chipidea from sysdev. This is inherited from its
parent node. Also, do not set dma mask for child as it is not required
now.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Sriram Dash 
Acked-by: Peter Chen 
Signed-off-by: Mathias Nyman 
Signed-off-by: Peter Chen 
Signed-off-by: Greg Kroah-Hartman

usb: add CONFIG_USB_PCI for system have both PCI HW and non-PCI based USB HW

2017-03-17T04:16:56+00:00

a lot of embeded system SOC (e.g. freescale T2080) have both
PCI and USB modules. But USB module is controlled by registers directly,
it have no relationship with PCI module.

when say N here it will not build PCI related code in USB driver.

Signed-off-by: yuan linyu 
Acked-by: Felipe Balbi 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: update gadget state after bus resume

2017-03-15T03:30:43+00:00

Gadget state is set to be suspended when bus suspened, but not updated
after resume, this patch saves the gadget state before suspend and
restores it after resume.

Signed-off-by: Li Jun 
Signed-off-by: Peter Chen

usb: chipidea: msm: Fix return value check in ci_hdrc_msm_probe()

2017-02-03T08:48:47+00:00

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 2fc305be364e ("usb: chipidea: msm: Mux over secondary phy at the
right time")
Signed-off-by: Wei Yongjun 
Reviewed-by: Stephen Boyd 
Signed-off-by: Peter Chen