linux-stable.git/drivers/usb/chipidea, branch v3.6.2

usb: chipidea: udc: don't stall endpoint if request list is empty in isr_tr_complete_low

2012-09-12T17:58:38+00:00

When attaching an imx28 or imx53 in USB gadget mode to a Windows host and
starting a rndis connection we see this message every 4-10 seconds:

    g_ether gadget: high speed config #2: RNDIS

Analysis shows that each time this message is printed, the rndis connection is
re-establish due to a reset because of a stalled endpoint (ep 0, dir 1). The
endpoint is stalled because the reqeust complete bit on that endpoint is set,
but in isr_tr_complete_low() the endpoint request list (mEp->qh.queue) is
empty.

This patch removed this check, because the code doesn't take the following
situation into account:

The loop over all endpoints in isr_tr_complete_handler() will call ep_nuke() on
both ep0/dir0 and ep/dir1 in the first loop. Pending reqeusts will be flushed
and completed here. There seems to be a race condition, the request is nuked,
but the request complete bit will be set, too. The subsequent check (in
ep0/dir1's loop cycle) for endpoint request list (mEp->qh.queue) empty will
fail.

Both other mainline chipidea drivers (mv_udc_core.c and fsl_udc_core.c) don't
have this check.

Cc: stable 
Signed-off-by: Michael Grzeschik 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: cleanup dma_pool if udc_start() fails

2012-09-12T17:58:38+00:00

If udc_start() fails the qh_pool dma-pool cannot be closed because
it's still in use. This patch factors out the dma_pool_free() loop
into destroy_eps() and calls it in the error path of udc_start(),
too.

Cc: stable 
Reviewed-by: Richard Zhao 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: fix error path in udc_start()

2012-09-12T17:58:38+00:00

This patch fixes the error path of udc_start(). Now NULL is used to
unset the peripheral with otg_set_peripheral().

Cc: stable 
Reviewed-by: Richard Zhao 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-12T17:58:38+00:00

Add function to physicaly enable or disable of pullup connection on the USB-D+
line. The uvc gaget will fail, if this function is not implemented.

Cc: stable 
Signed-off-by: Michael Grzeschik 
Acked-by: Felipe Balbi 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: udc: fix setup of endpoint maxpacket size

2012-09-12T17:58:37+00:00

This patch changes the setup of the endpoint maxpacket size. All non control
endpoints are initialized with an undefined ((unsigned short)~0) maxpacket
size. The maxpacket size of Endpoint 0 will be kept at CTRL_PAYLOAD_MAX.

Some gadget drivers check for the maxpacket size before they enable the
endpoint, which leads to a wrong state in these drivers.

Cc: stable 
Signed-off-by: Michael Grzeschik 
Acked-by: Felipe Balbi 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-08-10T18:46:04+00:00

Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines",
the udc part of the chipidea driver needs the generic usb gadget helper
functions. If the chipidea driver with udc support is built into the
kernel and usb gadget is built a module, the linking of the kernel
fails with:

drivers/built-in.o: In function `_hardware_dequeue':
drivers/usb/chipidea/udc.c:527:
    undefined reference to `usb_gadget_unmap_request'
drivers/usb/chipidea/udc.c:1269:
    undefined reference to `usb_gadget_unmap_request'
drivers/usb/chipidea/udc.c:1821:
    undefined reference to `usb_del_gadget_udc'
drivers/usb/chipidea/udc.c:443:
    undefined reference to `usb_gadget_map_request'
drivers/usb/chipidea/udc.c:1774:
    undefined reference to `usb_add_gadget_udc'

This patch changes the dependencies, so that udc support can only be
activated if the linux gadget support (USB_GADGET) is builtin or both
chipidea driver and USB_GADGET are modular. Same dependencies for the
chipidea host support and the linux host side USB support (USB).

While there, fix the indention of chipidea the help text.

Cc: Alexander Shishkin 
Reviewed-by: Felipe Balbi 
Signed-off-by: Marc Kleine-Budde 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: add imx platform driver

2012-07-09T17:01:09+00:00

This patch supports only the host-mode functionality so far.

Signed-off-by: Richard Zhao 
Signed-off-by: Marek Vasut 
Cc: Peter Chen 
Cc: Alexander Shishkin 
Cc: Felipe Balbi 
Tested-by: Subodh Nijsure 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: permit driver bindings pass phy pointer

2012-07-09T16:59:23+00:00

Sometimes, the driver bindings may know what phy they use.
For example, when using device tree, the usb controller may have a
phandler pointing to usb phy.

Signed-off-by: Richard Zhao 
Reviewed-by: Marek Vasut 
Acked-by: Felipe Balbi 
Tested-by: Subodh Nijsure 
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: select USB_EHCI_ROOT_HUB_TT in USB_CHIPIDEA_HOST of Kconfig

2012-07-09T16:55:09+00:00

ci13xxx host needs Root Hub Transaction Translators.

Reported-by: Shawn Guo 
Signed-off-by: Richard Zhao 
Acked-by: Felipe Balbi 
Signed-off-by: Alexander Shishkin 
Acked-by: Marek Vasut 
Signed-off-by: Greg Kroah-Hartman

USB: Chipidea: add ci13xxx device id management

2012-07-09T16:53:44+00:00

We use ida_simple_get and ida_simple_remove to manage the ids.

Signed-off-by: Richard Zhao 
Reviewed-by: Felipe Balbi 
Signed-off-by: Alexander Shishkin 
Signed-off-by: Greg Kroah-Hartman