linux-stable.git/drivers/usb/chipidea/host.c, branch linux-6.2.y

usb: chipidea: host: add suspend/resume support for host controller

2022-10-23T12:34:53+00:00

The controller's power may be powered off during system suspend. This
will add suspend/resume support when the controller suffers power lost.

Signed-off-by: Xu Yang 
Link: https://lore.kernel.org/r/20221013151442.3262951-4-xu.yang_2@nxp.com
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: Add support for VBUS control with PHY

2022-08-31T07:07:52+00:00

Some platforms make use of VBUS control over PHY which means controller
driver has to access PHY registers to turn on/off VBUS line.This patch
adds support for such platforms in chipidea.

Flag 'CI_HDRC_PHY_VBUS_CONTROL' added to support VBus control feature.

Acked-by: Peter Chen 
Signed-off-by: Piyush Mehta 
Signed-off-by: Piyush Mehta 
Link: https://lore.kernel.org/r/20220822054051.2941282-1-piyush.mehta@amd.com
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: host: fix port index underflow and UBSAN complains

2021-08-21T05:15:25+00:00

If wIndex is 0 (and it often is), these calculations underflow and
UBSAN complains, here resolve this by not decrementing the index when
it is equal to 0, this copies the solution from commit 85e3990bea49
("USB: EHCI: avoid undefined pointer arithmetic and placate UBSAN")

Reported-by: Zhipeng Wang 
Signed-off-by: Li Jun 
Link: https://lore.kernel.org/r/1624004938-2399-1-git-send-email-jun.li@nxp.com
Signed-off-by: Peter Chen

usb: chipidea: tegra: fix flexible_array.cocci warnings

2021-03-10T08:37:15+00:00

Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes: fc53d5279094 ("usb: chipidea: tegra: Support host mode")
CC: Peter Geis 
Reported-by: kernel test robot 
Reviewed-by: Dmitry Osipenko 
Signed-off-by: kernel test robot 
Signed-off-by: Julia Lawall 
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2102132108040.2720@hadrien
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: tegra: Support host mode

2021-01-13T10:26:34+00:00

Add USB host mode to the Tegra HDRC driver. This allows us to benefit from
support provided by the generic ChipIdea driver instead of duplicating the
effort in a separate ehci-tegra driver.

Tested-by: Matt Merhar 
Tested-by: Nicolas Chauvet 
Tested-by: Ion Agorria 
Acked-by: Thierry Reding 
Acked-by: Peter Chen 
Signed-off-by: Peter Geis 
Signed-off-by: Dmitry Osipenko 
Link: https://lore.kernel.org/r/20201218120246.7759-6-digetx@gmail.com
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: host: Disable port power only if previously enabled

2019-12-30T19:02:01+00:00

On shutdown, ehci_power_off() is called unconditionally to power off
each port, even if it was never called to power on the port.
For chipidea, this results in a call to ehci_ci_portpower() with a request
to power off ports even if the port was never powered on.
This results in the following warning from the regulator code.

WARNING: CPU: 0 PID: 182 at drivers/regulator/core.c:2596 _regulator_disable+0x1a8/0x210
unbalanced disables for usb_otg2_vbus
Modules linked in:
CPU: 0 PID: 182 Comm: init Not tainted 5.4.6 #1
Hardware name: Freescale i.MX7 Dual (Device Tree)
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0xe0/0x10c)
[] (dump_stack) from [] (__warn+0xf4/0x10c)
[] (__warn) from [] (warn_slowpath_fmt+0x78/0xbc)
[] (warn_slowpath_fmt) from [] (_regulator_disable+0x1a8/0x210)
[] (_regulator_disable) from [] (regulator_disable+0x38/0xe8)
[] (regulator_disable) from [] (ehci_ci_portpower+0x38/0xdc)
[] (ehci_ci_portpower) from [] (ehci_port_power+0x50/0xa4)
[] (ehci_port_power) from [] (ehci_silence_controller+0x5c/0xc4)
[] (ehci_silence_controller) from [] (ehci_stop+0x3c/0xcc)
[] (ehci_stop) from [] (usb_remove_hcd+0xe0/0x19c)
[] (usb_remove_hcd) from [] (host_stop+0x38/0xa8)
[] (host_stop) from [] (ci_hdrc_remove+0x44/0xe4)
...

Keeping track of the power enable state avoids the warning and traceback.

Fixes: c8679a2fb8dec ("usb: chipidea: host: add portpower override")
Cc: Michael Grzeschik 
Cc: Peter Chen 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck 
Acked-by: Peter Chen 
Link: https://lore.kernel.org/r/20191226155754.25451-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman

usb: chipidea: host: override ehci->hub_control

2018-12-11T01:12:30+00:00

The chipidea controller has some special requirements during
suspend/resume, override common ehci->hub_control to implement
it.

Reviewed-by: Frieder Schrempf 
Tested-by: Frieder Schrempf 
Signed-off-by: Peter Chen

usb: chipidea: add flag for imx hsic implementation

2018-12-11T01:12:29+00:00

NXP (Freecale) imx HSIC design has some special requirements, add
some flags at host code to handle them.

Reviewed-by: Frieder Schrempf 
Tested-by: Frieder Schrempf 
Signed-off-by: Peter Chen

usb: chipidea: Add dynamic pinctrl selection

2018-09-20T09:04:21+00:00

Some hardware implementations require to configure pins differently
according to the USB role (host/device), this can be an update of the
pins routing or a simple GPIO value change.

This patch introduces new optional "host" and "device" pinctrls.
If these pinctrls are defined by the device, they are respectively
selected on host/device role start.

If a default pinctrl exist, it is restored on host/device role stop.

Signed-off-by: Loic Poulain 
Signed-off-by: Peter Chen

usb: chipidea: host: fix disconnection detect issue

2018-06-26T01:59:34+00:00

The commit 4e88d4c08301 ("usb: add a flag to skip PHY
initialization to struct usb_hcd") delete the assignment
for hcd->usb_phy, it causes usb_phy_notify_connect{disconnect)
are not called, the USB PHY driver is not notified of hot plug
event, then the disconnection will not be detected by hardware.

Fixes: 4e88d4c08301 ("usb: add a flag to skip PHY initialization
	to struct usb_hcd")
Acked-by: Martin Blumenstingl 
Reported-by: Mats Karrman 
Tested-by: Mats Karrman 
Signed-off-by: Peter Chen