linux-stable.git/drivers/tty, branch v5.0.6

Disable kgdboc failed by echo space to /sys/module/kgdboc/parameters/kgdboc

2019-04-03T04:27:34+00:00

commit 3ec8002951ea173e24b466df1ea98c56b7920e63 upstream.

Echo "" to /sys/module/kgdboc/parameters/kgdboc will fail with "No such
device” error.

This is caused by function "configure_kgdboc" who init err to ENODEV
when the config is empty (legal input) the code go out with ENODEV
returned.

Fixes: 2dd453168643 ("kgdboc: Fix restrict error")
Signed-off-by: Wentao Wang 
Cc: stable 
Acked-by: Daniel Thompson 
Signed-off-by: Greg Kroah-Hartman

serial: sh-sci: Fix setting SCSCR_TIE while transferring data

2019-04-03T04:27:33+00:00

commit 93bcefd4c6bad4c69dbc4edcd3fbf774b24d930d upstream.

We disable transmission interrupt (clear SCSCR_TIE) after all data has been transmitted
(if uart_circ_empty(xmit)). While transmitting, if the data is still in the tty buffer,
re-enable the SCSCR_TIE bit, which was done at sci_start_tx().
This is unnecessary processing, wasting CPU operation if the data transmission length is large.
And further, transmit end, FIFO empty bits disabling have also been performed in the step above.

Signed-off-by: Hoan Nguyen An 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference

2019-04-03T04:27:33+00:00

commit 32f47179833b63de72427131169809065db6745e upstream.

of_match_device on failure to find a matching device can return a NULL
pointer. The patch checks for such a scenrio and passes the error upstream.

Signed-off-by: Aditya Pakki 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

serial: max310x: Fix to avoid potential NULL pointer dereference

2019-04-03T04:27:33+00:00

commit 3a10e3dd52e80b9a97a3346020024d17b2c272d6 upstream.

of_match_device can return a NULL pointer when matching device is not
found. This patch avoids a scenario causing NULL pointer derefernce.

Signed-off-by: Aditya Pakki 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup

2019-04-03T04:27:32+00:00

commit c5cbc78acf693f5605d4a85b1327fa7933daf092 upstream.

When building with -Wsometimes-uninitialized, Clang warns:

drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud'
is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]

It's not wrong; when options is NULL, baud has no default value. Use
9600 as that is a sane default.

Link: https://github.com/ClangBuiltLinux/linux/issues/395
Suggested-by: Greg Kroah-Hartman 
Signed-off-by: Nathan Chancellor 
Reviewed-by: Nick Desaulniers 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty: atmel_serial: fix a potential NULL pointer dereference

2019-04-03T04:27:32+00:00

commit c85be041065c0be8bc48eda4c45e0319caf1d0e5 upstream.

In case dmaengine_prep_dma_cyclic fails, the fix returns a proper
error code to avoid NULL pointer dereference.

Signed-off-by: Kangjie Lu 
Fixes: 34df42f59a60 ("serial: at91: add rx dma support")
Acked-by: Richard Genoud 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty: mxs-auart: fix a potential NULL pointer dereference

2019-04-03T04:27:32+00:00

commit 6734330654dac550f12e932996b868c6d0dcb421 upstream.

In case ioremap fails, the fix returns -ENOMEM to avoid NULL
pointer dereferences.
Multiple places use port.membase.

Signed-off-by: Kangjie Lu 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

2019-04-03T04:27:31+00:00

commit 69646d7a3689fbe1a65ae90397d22ac3f1b8d40f upstream.

In half-duplex operation, RX should be started after TX completes.

If DMA is used, there is a case when the DMA transfer completes but the
TX FIFO is not emptied, so the RX cannot be restarted just yet.

Use a boolean variable to store this state and rearm TX interrupt mask
to be signaled again that the transfer finished. In interrupt transmit
handler this variable is used to start RX. A warning message is generated
if RX is activated before TX fifo is cleared.

Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable
RX after TX is done")
Signed-off-by: Razvan Stefanescu 
Acked-by: Richard Genoud 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty/serial: atmel: Add is_half_duplex helper

2019-04-03T04:27:31+00:00

commit f3040983132bf3477acd45d2452a906e67c2fec9 upstream.

Use a helper function to check that a port needs to use half duplex
communication, replacing several occurrences of multi-line bit checking.

Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable RX after TX is done")
Cc: stable 
Signed-off-by: Razvan Stefanescu 
Acked-by: Richard Genoud 
Signed-off-by: Greg Kroah-Hartman

vt: perform safe console erase in the right order

2019-03-23T19:11:37+00:00

commit a6dbe442755999960ca54a9b8ecfd9606be0ea75 upstream.

Commit 4b4ecd9cb853 ("vt: Perform safe console erase only once") removed
what appeared to be an extra call to scr_memsetw(). This missed the fact
that set_origin() must be called before clearing the screen otherwise
old screen content gets restored on the screen when using vgacon. Let's
fix that by moving all the scrollback handling to flush_scrollback()
where it logically belongs, and invoking it before the actual screen
clearing in csi_J(), making the code simpler in the end.

Reported-by: Matthew Whitehead 
Signed-off-by: Nicolas Pitre 
Tested-by: Matthew Whitehead 
Fixes: 4b4ecd9cb853 ("vt: Perform safe console erase only once")
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman