linux-stable.git/drivers/tty, branch v4.12.7

serial: sh-sci: Uninitialized variables in sysfs files

2017-07-27T22:10:16+00:00

commit 4ab3c51e0540ba8464fe34d84cc35821bb77ae92 upstream.

The kstrtol() function returns -ERANGE as well as -EINVAL so these tests
are not enough.  It's not a super serious bug, but my static checker
correctly complains that the "r" variable might be used uninitialized.

Fixes: 5d23188a473d ("serial: sh-sci: make RX FIFO parameters tunable via sysfs")
Signed-off-by: Dan Carpenter 
Signed-off-by: Greg Kroah-Hartman

serial: st-asc: Potential error pointer dereference

2017-07-27T22:10:15+00:00

commit 2b01bfaeb41e1563322448d9b392ac924cbf22ef upstream.

It looks like we intended to return an error code here, because we
dereference "ascport->pinctrl" on the next lines.

Fixes: 6929cb00a501 ("serial: st-asc: Read in all Pinctrl states")
Signed-off-by: Dan Carpenter 
Acked-by: Lee Jones 
Signed-off-by: Greg Kroah-Hartman

vt: fix unchecked __put_user() in tioclinux ioctls

2017-07-21T04:59:10+00:00

commit 6987dc8a70976561d22450b5858fc9767788cc1c upstream.

Only read access is checked before this call.

Actually, at the moment this is not an issue, as every in-tree arch does
the same manual checks for VERIFY_READ vs VERIFY_WRITE, relying on the MMU
to tell them apart, but this wasn't the case in the past and may happen
again on some odd arch in the future.

If anyone cares about 3.7 and earlier, this is a security hole (untested)
on real 80386 CPUs.

Signed-off-by: Adam Borowski 
Signed-off-by: Greg Kroah-Hartman

imx-serial: RX DMA startup latency

2017-07-15T11:09:04+00:00

commit 4dec2f119e86f9c91e60cdd8f0cc057452e331a9 upstream.

18a4208 introduced a change to reduce the RX DMA latency on the first reception
when the serial port was opened for reading. However it was claiming a hardirq
unsafe lock after a hardirq safe lock which is not allowed and causes lockdep
to complain verbosely.

This patch changes the code to always start RX DMA earlier, instead of
relying on the flags used to open the serial port removing the code that
was looking for the serial file flags.

Signed-off-by: Peter Senna Tschudin 
Tested-by: Sascha Hauer 
Signed-off-by: Fabio Estevam 
Signed-off-by: Greg Kroah-Hartman

Revert "tty: fix port buffer locking"

2017-06-04T08:23:25+00:00

This reverts commit 925bb1ce47f429f69aad35876df7ecd8c53deb7e.

It causes lots of warnings and problems so for now, let's just revert
it.

Reported-by: 
Reported-by: Russell King 
Reported-by: Sergey Senozhatsky 
Reported-by: Geert Uytterhoeven 
Reported-by: Jiri Slaby 
Reported-by: Andrey Konovalov 
Acked-by: Vegard Nossum 
Signed-off-by: Greg Kroah-Hartman

serial: altera_uart: call iounmap() at driver remove

2017-05-25T12:36:37+00:00

The driver calls ioremap() in the probe function but doesn't call
iounmap() in the remove function correspondingly. Do so now.

Follow commit 5c9d6abed9e0 ("serial: altera_jtaguart: adding iounmap()")

Cc: Alexey Khoroshilov 
Signed-off-by: Tobias Klauser 
Signed-off-by: Greg Kroah-Hartman

serial: imx: ensure UCR3 and UFCR are setup correctly

2017-05-25T12:35:53+00:00

Commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and
RI irqs to be off") has a flaw: While UCR3 and UFCR were modified using
read-modify-write before it switched to write register values
independent of the previous state. That's a good idea in principle (and
that's why I did it) but needs more care.

This patch reinstates read-modify-write for UFCR and for UCR3 ensures
that RXDMUXSEL and ADNIMP are set for post imx1.

Fixes: e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
Signed-off-by: Uwe Kleine-König 
Acked-by: Mika Penttilä 
Tested-by: Mika Penttilä 
Acked-by: Steve Twiss 
Tested-by: Steve Twiss 
Signed-off-by: Greg Kroah-Hartman

serial: enable serdev support

2017-05-18T15:38:25+00:00

Enable serdev support by using the new device-registration helpers.

Reviewed-by: Rob Herring 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

tty/serdev: add serdev registration interface

2017-05-18T15:38:24+00:00

Add a new interface for registering a serdev controller and clients, and
a helper function to deregister serdev devices (or a tty device) that
were previously registered using the new interface.

Once every driver currently using the tty_port_register_device() helpers
have been vetted and converted to use the new serdev registration
interface (at least for deregistration), we can move serdev registration
to the current helpers and get rid of the serdev-specific functions.

Reviewed-by: Rob Herring 
Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

serdev: Restore serdev_device_write_buf for atomic context

2017-05-18T14:45:53+00:00

Starting with commit 6fe729c4bdae ("serdev: Add serdev_device_write
subroutine") the function serdev_device_write_buf cannot be used in
atomic context anymore (mutex_lock is sleeping). So restore the old
behavior.

Signed-off-by: Stefan Wahren 
Fixes: 6fe729c4bdae ("serdev: Add serdev_device_write subroutine")
Acked-by: Rob Herring 
Reviewed-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman