linux-stable.git/drivers/tty/vt/consolemap.c, branch linux-4.9.y

vt/consolemap: do font sum unsigned

2021-03-07T10:25:57+00:00

[ Upstream commit 9777f8e60e718f7b022a94f2524f967d8def1931 ]

The constant 20 makes the font sum computation signed which can lead to
sign extensions and signed wraps. It's not much of a problem as we build
with -fno-strict-overflow. But if we ever decide not to, be ready, so
switch the constant to unsigned.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210105120239.28031-7-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

tty: vt, ignore PIO_UNIMAPCLR param

2016-06-25T16:04:48+00:00

We do not do hashtables for unicode fonts since 1995 (1.3.28). So it
is time to remove the second parameter of con_clear_unimap and ignore
the advice from userspace completely.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: consolemap.c: move assignment out of if () block

2015-05-10T17:04:16+00:00

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Jiri Slaby 
CC: Takashi Iwai 
CC: Imre Deak 
Signed-off-by: Greg Kroah-Hartman

tty/vt: don't set font mappings on vc not supporting this

2014-11-06T04:12:02+00:00

We can call this function for a dummy console that doesn't support
setting the font mapping, which will result in a null ptr BUG. So check
for this case and return error for consoles w/o font mapping support.

Reference: https://bugzilla.kernel.org/show_bug.cgi?id=59321
Signed-off-by: Imre Deak 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

console: Remove superfluous readonly check

2014-05-28T20:37:21+00:00

uni_pagedir.readonly is never set.  Let's get rid of superfluous check
codes.

Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

console: Use explicit pointer type for vc_uni_pagedir* fields

2014-05-28T20:37:21+00:00

The vc_data.vc_uni_pagedir filed is currently long int, supposedly to
be served generically.  This, however, leads to lots of cast to
pointer, and rather it worsens the readability significantly.

Actually, we have now only a single uni_pagedir map implementation,
and this won't change likely.  So, it'd be much more simple and
error-prone to just use the exact pointer for struct uni_pagedir
instead of long.

Ditto for vc_uni_pagedir_loc.  It's a pointer to the uni_pagedir, thus
it can be changed similarly to the exact type.

Signed-off-by: Takashi Iwai 
Signed-off-by: Greg Kroah-Hartman

driver: tty: vt: remove cast for kmalloc return value

2013-03-19T00:09:37+00:00

remove cast for kmalloc return value.

Signed-off-by: Zhang Yanfei 
Cc: Jiri Slaby 
Cc: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

tty: vt: Remove redundant null check before kfree.

2012-11-26T23:36:38+00:00

kfree on a NULL pointer is a no-op.

Signed-off-by: Sachin Kamat 
Signed-off-by: Greg Kroah-Hartman

vt: push the tty_lock down into the map handling

2012-04-24T23:14:14+00:00

When we do this it becomes clear the lock we should be holding is the vc
lock, and in fact many of our other helpers are properly invoked this way.

We don't at this point guarantee not to race the keyboard code but the results
of that appear harmless and that was true before we started as well.

We now have no users of tty_lock in the console driver...

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: Wrong unicode value copied in con_set_unimap()

2012-03-15T20:28:52+00:00

Bugzilla 40012: PIO_UNIMAP bug: error updating Unicode-to-font map
https://bugzilla.kernel.org/show_bug.cgi?id=40012

The unicode font map for the virtual console is a 32x32x64 table which
allocates rows dynamically as entries are added.  The unicode value
increases sequentially and should count all entries even in empty
rows.  The defect is when copying the unicode font map in con_set_unimap(),
the unicode value is not incremented properly.  The wrong unicode value
is entered in the new font map.

Signed-off-by: Liz Clark 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman