linux-stable.git/drivers/tty/vcc.c, branch v5.13.2

tty: make everyone's write_room return >= 0

2021-03-10T08:34:09+00:00

The tty line disciplines don't expect tty_operations::write_room to
return negative values. Fix the five drivers which violate this.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-44-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: make everyone's chars_in_buffer return >= 0

2021-03-10T08:34:09+00:00

The tty line disciplines don't expect tty_operations::chars_in_buffer to
return negative values. Fix the two drivers which violate this.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-43-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: vcc, remove useless tty checks

2021-03-10T08:34:08+00:00

All these functions are called with a valid tty pointer, no need to
check that.

Cc: "David S. Miller" 
Cc: sparclinux@vger.kernel.org
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-28-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: vcc, use name strings directly

2021-03-10T08:34:08+00:00

Do not define global variables for driver/device names, use the strings
directly.

Cc: "David S. Miller" 
Cc: sparclinux@vger.kernel.org
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-27-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: vcc, drop version dump

2021-03-10T08:34:08+00:00

The version number is artificial, no need to dump it to logs during
initialization.

Cc: "David S. Miller" 
Cc: 
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-26-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: vcc, make globals static

2021-03-10T08:34:08+00:00

These are used only in this unit, so make them static.

Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20210302062214.29627-25-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: vcc: Drop impossible to hit WARN_ON

2021-01-15T09:21:42+00:00

vcc_get() returns the port that has provided port->index. As the port that
is about to be removed isn't removed yet this trivially will find this
port. So simplify the call to not assign an identical value to the port
pointer and drop the warning that is never hit.

Reviewed-by: Jiri Slaby 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20210114175718.137483-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

tty: vcc: Drop unnecessary if block

2021-01-15T09:21:42+00:00

If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.

Reviewed-by: Jiri Slaby 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20210114175718.137483-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

sparc64: vcc: Fix error return code in vcc_probe()

2020-04-28T12:38:54+00:00

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
Link: https://lore.kernel.org/r/20200427122415.47416-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman

tty: fix up a few remaining files without SPDX identifiers

2019-04-04T16:48:43+00:00

There were a few straggling files under drivers/tty/ that did not have
any SPDX identifier either because they entered the tree recently, or
they somehow missed the mass-tagging of commit b24413180f56 ("License
cleanup: add SPDX GPL-2.0 license identifier to files with no license")

This commit follows the same rule as b24413180f56 ("License cleanup: add
SPDX GPL-2.0 license identifier to files with no license") where files
without any specified license in them fall under GPL-2.0 as the correct
license for the individual file.  Add that identifier to these remaining
files so that we don't have to guess at the license of them in the
future.

Cc: Jiri Slaby 
Cc: "David S. Miller" 
Reviewed-by: Mukesh Ojha 
Signed-off-by: Greg Kroah-Hartman