linux-stable.git/drivers/tty/vcc.c, branch v5.12.2

tty: vcc: Drop impossible to hit WARN_ON

2021-01-15T09:21:42+00:00

vcc_get() returns the port that has provided port->index. As the port that
is about to be removed isn't removed yet this trivially will find this
port. So simplify the call to not assign an identical value to the port
pointer and drop the warning that is never hit.

Reviewed-by: Jiri Slaby 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20210114175718.137483-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

tty: vcc: Drop unnecessary if block

2021-01-15T09:21:42+00:00

If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.

Reviewed-by: Jiri Slaby 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20210114175718.137483-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

sparc64: vcc: Fix error return code in vcc_probe()

2020-04-28T12:38:54+00:00

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
Link: https://lore.kernel.org/r/20200427122415.47416-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman

tty: fix up a few remaining files without SPDX identifiers

2019-04-04T16:48:43+00:00

There were a few straggling files under drivers/tty/ that did not have
any SPDX identifier either because they entered the tree recently, or
they somehow missed the mass-tagging of commit b24413180f56 ("License
cleanup: add SPDX GPL-2.0 license identifier to files with no license")

This commit follows the same rule as b24413180f56 ("License cleanup: add
SPDX GPL-2.0 license identifier to files with no license") where files
without any specified license in them fall under GPL-2.0 as the correct
license for the individual file.  Add that identifier to these remaining
files so that we don't have to guess at the license of them in the
future.

Cc: Jiri Slaby 
Cc: "David S. Miller" 
Reviewed-by: Mukesh Ojha 
Signed-off-by: Greg Kroah-Hartman

tty: vcc: Convert timers to use timer_setup()

2017-11-04T11:01:54+00:00

In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.

Cc: "David S. Miller" 
Cc: Jiri Slaby 
Cc: sparclinux@vger.kernel.org
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

drivers: tty: vcc: use setup_timer() helper.

2017-10-03T18:28:36+00:00

    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais 
Signed-off-by: Greg Kroah-Hartman

sparc64: vcc: make ktermios const

2017-08-29T22:10:44+00:00

Make this const as it is not modified anywhere.

Signed-off-by: Bhumika Goyal 
Signed-off-by: David S. Miller

sparc64: vcc: Check for IS_ERR() instead of NULL

2017-08-28T22:39:55+00:00

The tty_alloc_driver() function never returns NULL, it returns error
pointers on error.

Fixes: ce808b746325 ("sparc64: vcc: TTY driver initialization and cleanup")
Signed-off-by: Dan Carpenter 
Signed-off-by: David S. Miller

sparc64: vcc: Add install & cleanup TTY operations

2017-08-16T04:33:54+00:00

Add handlers to support TTY install & cleanup operations

Signed-off-by: Jagannathan Raman 
Reviewed-by: Liam Merwick 
Reviewed-by: Shannon Nelson 
Signed-off-by: David S. Miller

sparc64: vcc: Add break_ctl TTY operation

2017-08-16T04:33:54+00:00

Add handler to support TTY break_ctl operation

Signed-off-by: Jagannathan Raman 
Reviewed-by: Liam Merwick 
Reviewed-by: Shannon Nelson 
Signed-off-by: David S. Miller