linux-stable.git/drivers/tty/serial, branch v4.19.37

serial: sh-sci: Fix HSCIF RX sampling point calculation

2019-04-27T07:36:36+00:00

commit ace965696da2611af759f0284e26342b7b6cec89 upstream.

There are several issues with the formula used for calculating the
deviation from the intended rate:
  1. While min_err and last_stop are signed, srr and baud are unsigned.
     Hence the signed values are promoted to unsigned, which will lead
     to a bogus value of deviation if min_err is negative,
  2. Srr is the register field value, which is one less than the actual
     sampling rate factor,
  3. The divisions do not use rounding.

Fix this by casting unsigned variables to int, adding one to srr, and
using a single DIV_ROUND_CLOSEST().

Fixes: 63ba1e00f178a448 ("serial: sh-sci: Support for HSCIF RX sampling point adjustment")
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Mukesh Ojha 
Cc: stable 
Reviewed-by: Ulrich Hecht 
Signed-off-by: Greg Kroah-Hartman

serial: sh-sci: Fix HSCIF RX sampling point adjustment

2019-04-27T07:36:36+00:00

commit 6b87784b53592a90d21576be8eff688b56d93cce upstream.

The calculation of the sampling point has min() and max() exchanged.
Fix this by using the clamp() helper instead.

Fixes: 63ba1e00f178a448 ("serial: sh-sci: Support for HSCIF RX sampling point adjustment")
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Ulrich Hecht 
Reviewed-by: Wolfram Sang 
Acked-by: Dirk Behme 
Cc: stable 
Reviewed-by: Simon Horman 
Signed-off-by: Greg Kroah-Hartman

serial: uartps: console_setup() can't be placed to init section

2019-04-20T07:16:01+00:00

[ Upstream commit 4bb1ce2350a598502b23088b169e16b43d4bc639 ]

When console device is rebinded, console_setup() is called again.
But marking it as __init means that function will be clear after boot is
complete. If console device is binded again console_setup() is not found
and error "Unable to handle kernel paging request at virtual address"
is reported.

Signed-off-by: Michal Simek 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

serial: 8250_pxa: honor the port number from devicetree

2019-04-05T20:33:01+00:00

[ Upstream commit fe9ed6d2483fda55465f32924fb15bce0fac3fac ]

Like the other OF-enabled drivers, use the port number from the firmware if
the devicetree specifies an alias:

  aliases {
      ...
      serial2 = &uart2; /* Should be ttyS2 */
  }

This is how the deprecated pxa.c driver behaved, switching to 8250_pxa
messes up the numbering.

Signed-off-by: Lubomir Rintel 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

2019-04-05T20:32:55+00:00

commit 69646d7a3689fbe1a65ae90397d22ac3f1b8d40f upstream.

In half-duplex operation, RX should be started after TX completes.

If DMA is used, there is a case when the DMA transfer completes but the
TX FIFO is not emptied, so the RX cannot be restarted just yet.

Use a boolean variable to store this state and rearm TX interrupt mask
to be signaled again that the transfer finished. In interrupt transmit
handler this variable is used to start RX. A warning message is generated
if RX is activated before TX fifo is cleared.

Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable
RX after TX is done")
Signed-off-by: Razvan Stefanescu 
Acked-by: Richard Genoud 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

tty/serial: atmel: Add is_half_duplex helper

2019-04-05T20:32:55+00:00

commit f3040983132bf3477acd45d2452a906e67c2fec9 upstream.

Use a helper function to check that a port needs to use half duplex
communication, replacing several occurrences of multi-line bit checking.

Fixes: b389f173aaa1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable RX after TX is done")
Cc: stable 
Signed-off-by: Razvan Stefanescu 
Acked-by: Richard Genoud 
Signed-off-by: Greg Kroah-Hartman

Disable kgdboc failed by echo space to /sys/module/kgdboc/parameters/kgdboc

2019-04-03T04:26:26+00:00

commit 3ec8002951ea173e24b466df1ea98c56b7920e63 upstream.

Echo "" to /sys/module/kgdboc/parameters/kgdboc will fail with "No such
device” error.

This is caused by function "configure_kgdboc" who init err to ENODEV
when the config is empty (legal input) the code go out with ENODEV
returned.

Fixes: 2dd453168643 ("kgdboc: Fix restrict error")
Signed-off-by: Wentao Wang 
Cc: stable 
Acked-by: Daniel Thompson 
Signed-off-by: Greg Kroah-Hartman

serial: sh-sci: Fix setting SCSCR_TIE while transferring data

2019-04-03T04:26:25+00:00

commit 93bcefd4c6bad4c69dbc4edcd3fbf774b24d930d upstream.

We disable transmission interrupt (clear SCSCR_TIE) after all data has been transmitted
(if uart_circ_empty(xmit)). While transmitting, if the data is still in the tty buffer,
re-enable the SCSCR_TIE bit, which was done at sci_start_tx().
This is unnecessary processing, wasting CPU operation if the data transmission length is large.
And further, transmit end, FIFO empty bits disabling have also been performed in the step above.

Signed-off-by: Hoan Nguyen An 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference

2019-04-03T04:26:25+00:00

commit 32f47179833b63de72427131169809065db6745e upstream.

of_match_device on failure to find a matching device can return a NULL
pointer. The patch checks for such a scenrio and passes the error upstream.

Signed-off-by: Aditya Pakki 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

serial: max310x: Fix to avoid potential NULL pointer dereference

2019-04-03T04:26:25+00:00

commit 3a10e3dd52e80b9a97a3346020024d17b2c272d6 upstream.

of_match_device can return a NULL pointer when matching device is not
found. This patch avoids a scenario causing NULL pointer derefernce.

Signed-off-by: Aditya Pakki 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman