linux-stable.git/drivers/tty/serial/ucc_uart.c, branch v5.7

Merge tag 'armsoc-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc

2020-02-08T22:04:19+00:00

Pull ARM SoC-related driver updates from Olof Johansson:
 "Various driver updates for platforms:

   - Nvidia: Fuse support for Tegra194, continued memory controller
     pieces for Tegra30

   - NXP/FSL: Refactorings of QuickEngine drivers to support
     ARM/ARM64/PPC

   - NXP/FSL: i.MX8MP SoC driver pieces

   - TI Keystone: ring accelerator driver

   - Qualcomm: SCM driver cleanup/refactoring + support for new SoCs.

   - Xilinx ZynqMP: feature checking interface for firmware. Mailbox
     communication for power management

   - Overall support patch set for cpuidle on more complex hierarchies
     (PSCI-based)

  and misc cleanups, refactorings of Marvell, TI, other platforms"

* tag 'armsoc-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (166 commits)
  drivers: soc: xilinx: Use mailbox IPI callback
  dt-bindings: power: reset: xilinx: Add bindings for ipi mailbox
  drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists
  MAINTAINERS: Add brcmstb PCIe controller entry
  soc/tegra: fuse: Unmap registers once they are not needed anymore
  soc/tegra: fuse: Correct straps' address for older Tegra124 device trees
  soc/tegra: fuse: Warn if straps are not ready
  soc/tegra: fuse: Cache values of straps and Chip ID registers
  memory: tegra30-emc: Correct error message for timed out auto calibration
  memory: tegra30-emc: Firm up hardware programming sequence
  memory: tegra30-emc: Firm up suspend/resume sequence
  soc/tegra: regulators: Do nothing if voltage is unchanged
  memory: tegra: Correct reset value of xusb_hostr
  soc/tegra: fuse: Add APB DMA dependency for Tegra20
  bus: tegra-aconnect: Remove PM_CLK dependency
  dt-bindings: mediatek: add MT6765 power dt-bindings
  soc: mediatek: cmdq: delete not used define
  memory: tegra: Add support for the Tegra194 memory controller
  memory: tegra: Only include support for enabled SoCs
  memory: tegra: Support DVFS on Tegra186 and later
  ...

serial: ucc_uart: remove redundant assignment to pointer bdp

2020-01-06T19:22:32+00:00

The variable bdp is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
Acked-by: Timur Tabi 
Link: https://lore.kernel.org/r/20191220001000.39859-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman

tty/serial: ucc_uart: Remove ifdef SUPPORT_SYSRQ

2019-12-18T14:05:08+00:00

ucc_uart doesn't seem to support console over itself, so maybe it can
be deleted with uart_handle_sysrq_char() from the file.

Cc: Timur Tabi 
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Dmitry Safonov 
Link: https://lore.kernel.org/r/20191213000657.931618-50-dima@arista.com
Signed-off-by: Greg Kroah-Hartman

serial: ucc_uart: access __be32 field using be32_to_cpu

2019-12-09T19:54:35+00:00

The buf member of struct qe_bd is a __be32, so to make this work on
little-endian hosts, use be32_to_cpu when reading it.

Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang

serial: ucc_uart: limit brg-frequency workaround to PPC32

2019-12-09T19:54:35+00:00

According to Timur Tabi

    This bug in older U-Boots is definitely PowerPC-specific

So before allowing this driver to be built for platforms other than
PPC32, make sure that we don't accept malformed device trees on those
other platforms.

Suggested-by: Timur Tabi 
Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang

serial: ucc_uart: use of_property_read_u32() in ucc_uart_probe()

2019-12-09T19:54:35+00:00

For this to work correctly on little-endian hosts, don't access the
device-tree properties directly in native endianness, but use the
of_property_read_u32() helper.

Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang

serial: ucc_uart: stub out soft_uart_init for !CONFIG_PPC32

2019-12-09T19:54:35+00:00

The Soft UART hack is only needed for some PPC-based SOCs. To allow
building this driver for non-PPC, guard soft_uart_init() and its
helpers by CONFIG_PPC32, and use a no-op soft_uart_init() otherwise.

Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang

serial: ucc_uart: factor out soft_uart initialization

2019-12-09T19:54:34+00:00

The "soft uart" mechanism is a workaround for a silicon bug which (as
far as I know) only affects some PPC-based SOCs.

The code that determines which microcode blob to request relies on
some powerpc-specific bits (e.g. the mfspr(SPRN_SVR) and hence also
the asm/reg.h header). This makes it a little awkward to allow this
driver to be built for non-PPC based SOCs with a QE, even if they are
not affected by that silicon bug and thus don't need any of the Soft
UART logic.

There's no way around guarding those bits with some ifdeffery, so to
keep that isolated, factor out the
do-we-need-soft-uart-and-if-so-handle-the-firmware to a separate
function, which we can then easily stub out for non-PPC.

Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang

serial: ucc_uart: replace ppc-specific IO accessors

2019-12-09T19:54:34+00:00

Some ARM-based SOCs (e.g. LS1021A) also have a QUICC engine. As
preparation for allowing this driver to build on ARM, replace the
ppc-specific in_be16() etc. by the qe_io* helpers. Done via
coccinelle.

Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang

serial: ucc_uart: explicitly include soc/fsl/cpm.h

2019-12-09T19:54:34+00:00

This driver uses #defines from soc/fsl/cpm.h, so instead of relying on
some other header pulling that in, do that explicitly. This is
preparation for allowing this driver to build on ARM.

Reviewed-by: Timur Tabi 
Acked-by: Timur Tabi 
Signed-off-by: Rasmus Villemoes 
Signed-off-by: Li Yang