linux-stable.git/drivers/tty/serial/altera_uart.c, branch linux-3.13.y

Merge tag 'dt-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

2013-09-06T20:26:27+00:00

Pull ARM SoC DT updates from Olof Johansson:
"Device tree and bindings updates for 3.12.

General additions of various on-chip and on-board peripherals on
various platforms as support gets added. Some of the bigger changes
are:

- Addition of (new) PCI-e support on Tegra.
- More Tegra4 support, including PMC configuration for Dalmore.
- Addition of a new board for Exynos4 (trats2) and more bindings for
4x12 IP.
- Addition of Allwinner A20 and A31 SoC and board files.
- Move of the ST Ericsson device tree files to now use ste-* prefix.
- More move of hardware description of shmobile platforms to DT.
- Two new board dts files for Freescale MXs"

* tag 'dt-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (177 commits)
dts: Rename DW APB timer compatible strings
dts: Deprecate ALTR as a vendor prefix
of: add vendor prefix for Altera Corp.
ARM: at91/dt: sam9x5ek: add sound configuration
ARM: at91/dt: sam9x5ek: enable SSC
ARM: at91/dt: sam9x5ek: add WM8731 codec
ARM: at91/dt: sam9x5: add SSC DMA parameters
ARM: at91/dt: add at91rm9200 PQFP package version
ARM: at91: at91rm9200: set default mmc0 pinctrl-names
ARM: at91: at91sam9n12: correct pin number of gpio-key
ARM: at91: at91sam9n12: add qt1070 support
ARM: at91: at91sam9n12: add pinctrl of TWI
ARM: at91: Add PMU support for sama5d3
ARM: at91: at91sam9260: add missing pinctrl-names on mmc
ARM: tegra: configure power off for Dalmore
ARM: DT: binding fixup to align with vendor-prefixes.txt (DT)
ARM: dts: add sdio blocks to bcm28155-ap board
ARM: dts: align sdio numbers to HW definition
ARM: sun7i: Add Olimex A20-Olinuxino-Micro support
ARM: sun7i: Add Allwinner A20 DTSI
...

dts: Deprecate ALTR as a vendor prefix

2013-08-29T19:58:55+00:00

Because most of the vendor prefixes are lower case, deprecate
the vendor prefix "ALTR" in place of "altr" for Altera Corp..

Signed-off-by: Dinh Nguyen 
Acked-by: Stephen Warren 
Cc: Rob Herring 
Cc: Pawel Moll 
Cc: Mark Rutland 
Cc: Stephen Warren 
Cc: Ian Campbell 
Cc: devicetree@vger.kernel.org
Signed-off-by: Olof Johansson

tty: serial: altera: drop uart_port->lock before calling tty_flip_buffer_push()

2013-08-27T23:17:33+00:00

The current driver triggers a lockdep warning for if tty_flip_buffer_push() is
called with uart_port->lock locked. This never shows up on UP kernels and comes
up only on SMP kernels.

Crash looks like this (produced with samsung.c driver):

-----
[] (unwind_backtrace+0x0/0xf8) from [] (show_stack+0x10/0x14)
[] (show_stack+0x10/0x14) from [] (dump_stack+0x6c/0xac)
[] (dump_stack+0x6c/0xac) from [] (do_raw_spin_unlock+0xc4/0xd8)
[] (do_raw_spin_unlock+0xc4/0xd8) from [] (_raw_spin_unlock_irqrestore+0xc/0)
[] (_raw_spin_unlock_irqrestore+0xc/0x38) from [] (s3c24xx_serial_rx_chars+0)
[] (s3c24xx_serial_rx_chars+0x12c/0x260) from [] (s3c64xx_serial_handle_irq+)
[] (s3c64xx_serial_handle_irq+0x48/0x60) from [] (handle_irq_event_percpu+0x)
[] (handle_irq_event_percpu+0x50/0x194) from [] (handle_irq_event+0x3c/0x5c)
[] (handle_irq_event+0x3c/0x5c) from [] (handle_fasteoi_irq+0x80/0x13c)
[] (handle_fasteoi_irq+0x80/0x13c) from [] (generic_handle_irq+0x20/0x30)
[] (generic_handle_irq+0x20/0x30) from [] (handle_IRQ+0x38/0x94)
[] (handle_IRQ+0x38/0x94) from [] (gic_handle_irq+0x34/0x68)
[] (gic_handle_irq+0x34/0x68) from [] (__irq_svc+0x40/0x70)
Exception stack(0xc04cdf70 to 0xc04cdfb8)
df60:                                     00000000 00000000 0000166e 00000000
df80: c04cc000 c050278f c050278f 00000001 c04d444c 410fc0f4 c03649b0 00000000
dfa0: 00000001 c04cdfb8 c000f758 c000f75c 60070013 ffffffff
[] (__irq_svc+0x40/0x70) from [] (arch_cpu_idle+0x28/0x30)
[] (arch_cpu_idle+0x28/0x30) from [] (cpu_startup_entry+0x5c/0x148)
[] (cpu_startup_entry+0x5c/0x148) from [] (start_kernel+0x334/0x38c)
BUG: spinlock lockup suspected on CPU#0, kworker/0:1/360
 lock: s3c24xx_serial_ports+0x1d8/0x370, .magic: dead4ead, .owner: /-1, .owner_cpu: -1
CPU: 0 PID: 360 Comm: kworker/0:1 Not tainted 3.11.0-rc6-next-20130819-00003-g75485f1 #2
Workqueue: events flush_to_ldisc
[] (unwind_backtrace+0x0/0xf8) from [] (show_stack+0x10/0x14)
[] (show_stack+0x10/0x14) from [] (dump_stack+0x6c/0xac)
[] (dump_stack+0x6c/0xac) from [] (do_raw_spin_lock+0x100/0x17c)
[] (do_raw_spin_lock+0x100/0x17c) from [] (_raw_spin_lock_irqsave+0x20/0x28)
[] (_raw_spin_lock_irqsave+0x20/0x28) from [] (uart_start+0x18/0x34)
[] (uart_start+0x18/0x34) from [] (__receive_buf+0x4b4/0x738)
[] (__receive_buf+0x4b4/0x738) from [] (n_tty_receive_buf2+0x30/0x98)
[] (n_tty_receive_buf2+0x30/0x98) from [] (flush_to_ldisc+0xec/0x138)
[] (flush_to_ldisc+0xec/0x138) from [] (process_one_work+0xfc/0x348)
[] (process_one_work+0xfc/0x348) from [] (worker_thread+0x138/0x37c)
[] (worker_thread+0x138/0x37c) from [] (kthread+0xa4/0xb0)
[] (kthread+0xa4/0xb0) from [] (ret_from_fork+0x14/0x3c)
-----

Release the port lock before calling tty_flip_buffer_push() and reacquire it
after the call.

Similar stuff was already done for few other drivers in the past, like:

commit 2389b272168ceec056ca1d8a870a97fa9c26e11a
Author: Thomas Gleixner 
Date:   Tue May 29 21:53:50 2007 +0100

    [ARM] 4417/1: Serial: Fix AMBA drivers locking

Cc: Tobias Klauser 
Signed-off-by: Viresh Kumar 
Signed-off-by: Greg Kroah-Hartman

serial: use dev_get_platdata()

2013-08-01T00:56:15+00:00

Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.

Signed-off-by: Jingoo Han 
Signed-off-by: Greg Kroah-Hartman

serial: altera: remove unnecessary platform_set_drvdata()

2013-05-20T18:53:46+00:00

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han 
Acked-by: Tobias Klauser 
Signed-off-by: Greg Kroah-Hartman

tty: serial: altera_uart: Simplify altera_uart_init()

2013-02-05T19:13:50+00:00

No need for two separate return statements, consolidate them.

Signed-off-by: Tobias Klauser 
Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_flip_buffer_push

2013-01-16T06:30:15+00:00

Now, we start converting tty buffer functions to actually use
tty_port. This will allow us to get rid of the need of tty in many
call sites. Only tty_port will needed and hence no more
tty_port_tty_get in those paths.

Now, the one where most of tty_port_tty_get gets removed:
tty_flip_buffer_push.

IOW we also closed all the races in drivers not using tty_port_tty_get
at all yet.

Also we move tty_flip_buffer_push declaration from include/linux/tty.h
to include/linux/tty_flip.h to all others while we are changing it
anyway.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: remove use of __devexit

2012-11-21T23:27:46+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Jiri Slaby 
Cc: Alan Cox 
Acked-by: Tobias Klauser 
Cc: Lucas Tavares 
Cc: Daniel Walker 
Cc: Bryan Huntsman 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Tony Prisk 
Acked-by: David Brown 
Signed-off-by: Greg Kroah-Hartman

tty: remove use of __devinit

2012-11-21T23:22:52+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Jiri Slaby 
Cc: Alan Cox 
Cc: Lucas Tavares 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Tony Prisk 
Acked-by: Tobias Klauser 
Acked-by: Nicolas Ferre 
Signed-off-by: Greg Kroah-Hartman

tty: serial: remove use of __devexit_p

2012-11-21T23:19:52+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Alan Cox 
Cc: Lucas Tavares 
Cc: "David S. Miller" 
Cc: Peter Korsgaard 
Cc: Tony Prisk 
Acked-by: Tobias Klauser 
Acked-by: Nicolas Ferre 
Signed-off-by: Greg Kroah-Hartman