linux-stable.git/drivers/tty/n_tty.c, branch linux-3.8.y

tty: add missing newlines to WARN_RATELIMIT

2012-10-25T18:30:27+00:00

WARN_RATELIMIT() expects the warning to end with a newline if one
is needed.

Not doing so results in odd looking warnings such as:

[ 1339.454272] tty is NULLPid: 7147, comm: kworker/4:0 Tainted: G        W    3.7.0-rc2-next-20121025-sasha-00001-g673f98e-dirty #75

Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

TTY: move tty buffers to tty_port

2012-10-22T23:58:28+00:00

So this is it. The big step why we did all the work over the past
kernel releases. Now everything is prepared, so nothing protects us
from doing that big step.

           |  |            \  \ nnnn/^l      |  |
           |  |             \  /     /       |  |
           |  '-,.__   =>    \/   ,-`    =>  |  '-,.__
           | O __.´´)        (  .`           | O __.´´)
            ~~~   ~~          ``              ~~~   ~~
The buffers are now in the tty_port structure and we can start
teaching the buffer helpers (insert char/string, flip etc.) to use
tty_port instead of tty_struct all around.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: n_tty, propagate n_tty_data

2012-10-22T23:53:01+00:00

In some funtions we need only n_tty_data, so pass it down directly in
case tty is not needed there.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: move ldisc data from tty_struct: locks

2012-10-22T23:53:01+00:00

atomic_write_lock is not n_tty specific, so move it up in the
tty_struct.

And since these are the last ones to move, remove also the comment
saying there are some ldisc' members. There are none now.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: move ldisc data from tty_struct: read_* and echo_* and canon_* stuff

2012-10-22T23:53:01+00:00

All the ring-buffers...

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: move ldisc data from tty_struct: bitmaps

2012-10-22T23:53:00+00:00

Here we move bitmaps and use DECLARE_BITMAP to declare them in the new
structure. And instead of memset, we use bitmap_zero as it is more
appropriate.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: move ldisc data from tty_struct: simple members

2012-10-22T23:53:00+00:00

Here we start moving all the n_tty related bits from tty_struct to
the newly defined n_tty_data struct in n_tty proper.

In this patch primitive members and bits are moved. The rest will be
done per-partes in the next patches.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: n_tty, add ldisc data to n_tty

2012-10-22T23:50:54+00:00

All n_tty related members from tty_struct will be moved here.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: audit, stop accessing tty->icount

2012-10-22T23:50:54+00:00

This is a private member of n_tty. Stop accessing it. Instead, take is
as an argument.

This is needed to allow clean switch of the private members to a
separate private structure of n_tty.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

TTY: n_tty, remove bogus checks

2012-10-22T23:50:53+00:00

* BUG_ON(!tty) in n_tty_set_termios -- it cannot be called with tty ==
  NULL. It is called from two call sites. First, from n_tty_open where
  we have a valid tty. Second, as ld->ops->set_termios from
  tty_set_termios. But there we have a valid tty too.
* if (!tty) in n_tty_open -- why would the TTY layer call ldisc's
  open with an invalid TTY? No it indeed does not. All call sites have
  a tty and dereference that.
* BUG_ON(!tty->read_buf) in n_tty_read -- this used to be a valid
  check. The ldisc handling was broken some time ago when I added the
  check to ensure everything is OK. It still can catch the case, but
  no later than we move the buffer to ldisc data. Then there will be
  no read_buf in tty_struct, i.e. nothing to check for.
* if (!tty->read_buf) in n_tty_receive_buf -- this should never
  happen. All callers of ldisc->ops->receive_ops should hold a
  reference to an ldisc and close (which frees read_buf) cannot be
  called until the reference is dropped.
* if (WARN_ON(!tty->read_buf)) in n_tty_read -- the same as in the
  previous case.

Signed-off-by: Jiri Slaby 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman