linux-stable.git/drivers/tty/mxser.c, branch linux-4.9.y

mxser: fix xmit_buf leak in activate when LSR == 0xff

2022-04-20T07:06:36+00:00

[ Upstream commit cd3a4907ee334b40d7aa880c7ab310b154fd5cd4 ]

When LSR is 0xff in ->activate() (rather unlike), we return an error.
Provided ->shutdown() is not called when ->activate() fails, nothing
actually frees the buffer in this case.

Fix this by properly freeing the buffer in a designated label. We jump
there also from the "!info->type" if now too.

Fixes: 6769140d3047 ("tty: mxser: use the tty_port_open method")
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20220124071430.14907-6-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

tty: cyclades+mxser, do not initialize to zero

2016-06-25T15:56:30+00:00

Do not initialize members of initialized structures to zero. They are
zeroed automatically.

Part of hub6 cleanup series.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: mxser: Remove unused ASYNC_SHARE_IRQ flag

2016-04-30T16:26:55+00:00

ASYNC*_SHARE_IRQ is no longer used; remove.

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: Replace ASYNC_INITIALIZED bit and update atomically

2016-04-30T16:26:55+00:00

Replace ASYNC_INITIALIZED bit in the tty_port::flags field with
TTY_PORT_INITIALIZED bit in the tty_port::iflags field. Introduce helpers
tty_port_set_initialized() and tty_port_initialized() to abstract
atomic bit ops.

Note: the transforms for test_and_set_bit() and test_and_clear_bit()
are unnecessary as the state transitions are already mutually exclusive;
the tty lock prevents concurrent open/close/hangup.

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: Replace ASYNC_CHECK_CD and update atomically

2016-04-30T16:26:55+00:00

Replace ASYNC_CHECK_CD bit in the tty_port::flags field with
TTY_PORT_CHECK_CD bit in the tty_port::iflags field. Introduce helpers
tty_port_set_check_carrier() and tty_port_check_carrier() to abstract
the atomic bit ops.

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: Replace ASYNC_CTS_FLOW bit and update atomically

2016-04-30T16:26:55+00:00

Replace ASYNC_CTS_FLOW bit in the tty_port::flags field with
TTY_PORT_CTS_FLOW bit in the tty_port::iflags field. Add
tty_port_set_cts_flow() helper to abstract the atomic bit ops.

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: Replace TTY_IO_ERROR bit tests with tty_io_error()

2016-04-30T16:26:55+00:00

Abstract TTY_IO_ERROR status test treewide with tty_io_error().
NB: tty->flags uses atomic bit ops; replace non-atomic bit test
with test_bit().

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: constify tty_port_operations structs

2016-02-07T07:31:08+00:00

Constifies tty_port_operations structures in
the tty driver since they are not modified
after their initialization.

Detected and found using Coccinelle.

Suggested-by: Julia Lawall 
Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

tty: mxser: Remove ASYNC_CLOSING

2016-01-28T22:19:12+00:00

The tty core no longer provides ASYNC_CLOSING. Use private flag for
same purpose, which is to clear the fifos at each and every interrupt
during driver close(). The driver uses this sledgehammer approach because
its close/shutdown sequence is hopelessly borked.

Signed-off-by: Peter Hurley 
Signed-off-by: Greg Kroah-Hartman

tty: Use termios c_*flag macros

2016-01-28T22:13:44+00:00

Expressions of the form "tty->termios.c_*flag & FLAG"
are more clearly expressed with the termios flags macros,
I_FLAG(), C_FLAG(), O_FLAG(), and L_FLAG().

Convert treewide.

Signed-off-by: Peter Hurley 
Acked-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman