linux-stable.git/drivers/tty/moxa.c, branch linux-3.2.y

tty: moxa: fix bit test in moxa_start()

2012-04-02T16:52:31+00:00

commit 58112dfbfe02d803566a2c6c8bd97b5fa3c62cdc upstream.

This is supposed to be doing a shift before the comparison instead of
just doing a bitwise AND directly.  The current code means the start()
just returns without doing anything.

Signed-off-by: Dan Carpenter 
Acked-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

drivers/tty: use printk_ratelimited() instead of printk_ratelimit()

2011-07-01T22:35:45+00:00

Since the printk_ratelimit() shouldn't be used anymore (see comment in
include/linux/printk.h), replace it with printk_ratelimited().

Signed-off-by: Manuel Zerpies 
Signed-off-by: Greg Kroah-Hartman

drivers/tty/moxa.c: Put correct tty value

2011-04-29T21:17:45+00:00

The tty value that should be put is the one that was just gotten by
tty_port_tty_get, not the one that is the argument to the enclosing
function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@exists@
local idexpression struct tty_struct *x;
expression ra,rr;
statement S1,S2;
@@

x = tty_port_tty_get(...)
... when != x = rr
    when any
    when != tty_kref_put(x,...)
    when != if (...) { ... tty_kref_put(x,...) ...}
(
if(<+...x...+>) S1 else S2
|
if(...) { ... when != x = ra
     when forall
     when != tty_kref_put(x,...)
*return...;
}
)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Greg Kroah-Hartman

Char: moxa, fix locking in moxa_write

2011-04-25T21:19:11+00:00

moxa_write can be called from atomic context with irqs disabled (from
ppp_async_push). Don't enable interrupts by spin_unlock_bh as this
might cause deadlocks in the ppp layer.

Instead, use irqsave/irqrestore spin_lock functions.

Signed-off-by: Jiri Slaby 
Cc: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

Char: moxa, do not touch NORMAL_ACTIVE bit

2011-04-19T23:32:19+00:00

The bit is set in tty_port_block_til_ready (via moxa_open) and unset
in tty_port_close (via moxa_close). No need to pin it in the driver.

Signed-off-by: Jiri Slaby 
Cc: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

Char: moxa, remove unused variables

2011-04-19T21:41:48+00:00

drivers/tty/moxa.c:1287:2: warning: Value stored to 'port' is never read
        port = tty->index;
        ^      ~~~~~~~~~~
drivers/tty/moxa.c:1763:2: warning: Value stored to 'cflag' is never read
        cflag = termio->c_cflag;        /* termio->c_cflag */
        ^       ~~~~~~~~~~~~~~~

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

tty: move a number of tty drivers from drivers/char/ to drivers/tty/

2011-02-23T00:14:56+00:00

As planned by Arnd Bergmann, this moves the following drivers from
drivers/char/ to drivers/tty/ as that's where they really belong:
	amiserial
	nozomi
	synclink
	rocket
	cyclades
	moxa
	mxser
	isicom
	bfin_jtag_comm

Cc: Arnd Bergmann 
Cc: Alan Cox 
Cc: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman