linux-stable.git/drivers/tty/goldfish.c, branch linux-4.9.y

tty: drivers/tty/, stop using tty_schedule_flip()

2022-07-29T15:05:47+00:00

commit 5f6a85158ccacc3f09744b3aafe8b11ab3b6c6f6 upstream.

Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,
tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). We are
going to remove the latter (as it is used less), so call the former in
drivers/tty/.

Cc: Vladimir Zapolskiy 
Reviewed-by: Johan Hovold 
Signed-off-by: Jiri Slaby 
Link: https://lore.kernel.org/r/20211122111648.30379-2-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: goldfish: Fix a parameter of a call to free_irq

2017-10-08T08:26:05+00:00

[ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ]

'request_irq()' and 'free_irq()' should be called with the same dev_id.

Signed-off-by: Christophe JAILLET 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

tty: goldfish: support platform_device with id -1

2016-03-08T00:11:14+00:00

When the platform bus sets the platform_device id to -1 (PLATFORM_DEVID_NONE),
use an incrementing counter for the TTY index instead

Signed-off-by: Greg Hackmann 
Signed-off-by: Jin Qian 
Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

drivers: tty: goldfish: Add device tree bindings

2016-03-08T00:11:14+00:00

Enable support for registering this device using the device tree.
Device tree node example for registering Goldfish TTY device :

goldfish_tty@1f004000 {
    interrupts = <0xc>;
    reg = <0x1f004000 0x1000>;
    compatible = "google,goldfish-tty";
};

Signed-off-by: Miodrag Dinic 
Signed-off-by: Jin Qian 
Signed-off-by: Alan 
Signed-off-by: Greg Kroah-Hartman

tty: constify tty_port_operations structs

2016-02-07T07:31:08+00:00

Constifies tty_port_operations structures in
the tty driver since they are not modified
after their initialization.

Detected and found using Coccinelle.

Suggested-by: Julia Lawall 
Signed-off-by: Aya Mahfouz 
Signed-off-by: Greg Kroah-Hartman

staging: goldfish: Fix pointer cast for 32 bits

2015-05-31T02:40:14+00:00

As the first argument of gf_write64() was of type unsigned long, and as
some calls to gf_write64() were casting the first argument from void *
to u64 the compiler and/or sparse were printing warnings for casts of
wrong sizes when compiling for i386.

This patch changes the type of the first argument of gf_write64() to
const void *, and update calls to the function. This change fixed the
warnings and allowed to remove casts from 3 calls to gf_write64().

In addition gf_write64() was renamed to gf_write_ptr() as the name was
misleading because it only writes 32 bits on 32 bit systems.

gf_write_dma_addr() was added to handle dma_addr_t values which is
used at drivers/staging/goldfish/goldfish_audio.c.

Signed-off-by: Dan Carpenter 
Signed-off-by: Peter Senna Tschudin 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2015-04-14T16:50:27+00:00

Pull trivial tree from Jiri Kosina:
 "Usual trivial tree updates.  Nothing outstanding -- mostly printk()
  and comment fixes and unused identifier removals"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial:
  goldfish: goldfish_tty_probe() is not using 'i' any more
  powerpc: Fix comment in smu.h
  qla2xxx: Fix printks in ql_log message
  lib: correct link to the original source for div64_u64
  si2168, tda10071, m88ds3103: Fix firmware wording
  usb: storage: Fix printk in isd200_log_config()
  qla2xxx: Fix printk in qla25xx_setup_mode
  init/main: fix reset_device comment
  ipwireless: missing assignment
  goldfish: remove unreachable line of code
  coredump: Fix do_coredump() comment
  stacktrace.h: remove duplicate declaration task_struct
  smpboot.h: Remove unused function prototype
  treewide: Fix typo in printk messages
  treewide: Fix typo in printk messages
  mod_devicetable: fix comment for match_flags

goldfish: goldfish_tty_probe() is not using 'i' any more

2015-03-10T09:45:30+00:00

The only place where 'i' has been used was a dead code that
got removed by 2a2483685a9de ("goldfish: remove unreachable line
of code"). Remove the last reference to the variable as well.

Fixes: 2a2483685a9de ("goldfish: remove unreachable line of code")
Reported-by: Stephen Rothwell 
Signed-off-by: Jiri Kosina

goldfish: remove unreachable line of code

2015-03-06T22:11:32+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Jiri Kosina

goldfish: off by one in goldfish_tty_console_setup()

2014-11-06T00:12:45+00:00

The goldfish_ttys[] array has "goldfish_tty_line_count" number of
elements.  It's allocated in goldfish_tty_create_driver().  This test
should be >= instead of >.

Signed-off-by: Dan Carpenter 
Acked-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman