linux-stable.git/drivers/thunderbolt/switch.c, branch linux-5.14.y

thunderbolt: Fix port linking by checking all adapters

2021-09-18T11:43:48+00:00

[ Upstream commit 42716425ad7e1b6529ec61c260c11176841f4b5f ]

In tb_switch_default_link_ports(), while linking of ports,
only odd-numbered ports (1,3,5..) are considered and even-numbered
ports are not considered.

AMD host router has lane adapters at 2 and 3 and link ports at adapter 2
is not considered due to which lane bonding gets disabled.

Hence added a fix such that all ports are considered during
linking of ports.

Signed-off-by: Basavaraj Natikar 
Signed-off-by: Sanjay R Mehta 
Signed-off-by: Mika Westerberg 
Signed-off-by: Sasha Levin

Revert "thunderbolt: Hide authorized attribute if router does not support PCIe tunnels"

2021-07-27T16:14:25+00:00

This reverts commit 6f3badead6a078cf3c71f381f9d84ac922984a00.

It turns out bolt depends on having authorized attribute visible under
each device. Hiding it makes bolt crash as several people have reported
on various bug trackers. For this reason revert the commit.

Link: https://gitlab.freedesktop.org/bolt/bolt/-/issues/174
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1979765
Link: https://bugs.archlinux.org/task/71569
Cc: stable@vger.kernel.org
Cc: Christian Kellner 
Fixes: 6f3badead6a0 ("thunderbolt: Hide authorized attribute if router does not support PCIe tunnels")
Signed-off-by: Mika Westerberg 
Link: https://lore.kernel.org/r/20210727142501.27476-1-mika.westerberg@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

thunderbolt: Allow router NVM authenticate separately

2021-06-01T07:53:32+00:00

It may be useful if the actual NVM authentication can be delayed to be
run later, for instance when the user logs out. For this reason add a
new NVM operation (AUHENTICATE_ONLY) that just triggers the authentication
procedure over whatever was written to the NVM storage.

This is not supported with Thunderbolt 1-3 devices, though.

Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman

thunderbolt: Move nvm_write_ops to tb.h

2021-06-01T07:53:32+00:00

Currently these write ops are used for updating router firmware images
only. Moving to tb.h helps the retimers also to use the same ops.

Also add tb_ prefix to the enum while there.

Signed-off-by: Rajmohan Mani 
Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman

thunderbolt: Add support for retimer NVM upgrade when there is no link

2021-06-01T07:53:31+00:00

With help from platform firmware (ACPI) it is possible to power on
retimers even when there is no USB4 link (e.g nothing is connected to
the USB4 ports). This allows us to bring the USB4 sideband up so that we
can access retimers and upgrade their NVM firmware.

If the platform has support for this, we expose two additional
attributes under USB4 ports: offline and rescan. These can be used to
bring the port offline, rescan for the retimers and put the port online
again. The retimer NVM upgrade itself works the same way than with cable
connected.

Signed-off-by: Rajmohan Mani 
Co-developed-by: Mika Westerberg 
Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman

thunderbolt: Add USB4 port devices

2021-06-01T07:53:31+00:00

Create devices for each USB4 port. This is needed when we add retimer
access when there is no device connected but may be useful for other
purposes too following what USB subsystem does. This exports a single
attribute "link" that shows the type of the USB4 link (or "none" if
there is no cable connected).

Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman

thunderbolt: Update port credits after bonding is enabled/disabled

2021-06-01T07:48:59+00:00

Once lane bonding has been enabled (or disabled) both lane adapters may
update their total credits accordingly. For this reason re-read the port
credits after lane bonding has been enabled or disabled.

Signed-off-by: Mika Westerberg

thunderbolt: Read router preferred credit allocation information

2021-06-01T07:48:59+00:00

USB4 routers must expose their preferred credit (buffer) allocation
information through router operation. This information tells the
connection manager how the router prefers its buffers to be allocated to
get the expected bandwidth for the supported protocols.

Read this information and store it as part of struct tb_switch for each
USB4 router.

Signed-off-by: Mika Westerberg

thunderbolt: Wait for the lanes to actually bond

2021-06-01T07:48:59+00:00

It may take some time until the two lanes enter bonded state so poll for
the link width to match what is expected before going forward. This ensures
the link is in expected state before we start establishing paths through
it.

Signed-off-by: Mika Westerberg

thunderbolt: Make tb_port_type() take const parameter

2021-06-01T07:48:59+00:00

The function does not modify the object in any way so make the parameter
const to reflect this.

No functional changes intended.

Signed-off-by: Mika Westerberg