linux-stable.git/drivers/thunderbolt/retimer.c, branch v6.2

thunderbolt: Do not call PM runtime functions in tb_retimer_scan()

2023-01-09T08:43:51+00:00

We cannot call PM runtime functions in tb_retimer_scan() because it will
also be called when retimers are scanned from userspace (happens when
there is no device connected on ChromeOS for instance) and at the same
USB4 port runtime resume hook. This leads to hang because neither can
proceed.

Fix this by runtime resuming USB4 ports in tb_scan_port() instead. This
makes sure the ports are runtime PM active when retimers are added under
it while avoiding the reported hang as well.

Reported-by: Utkarsh Patel 
Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned")
Cc: stable@vger.kernel.org
Acked-by: Yehezkel Bernat 
Signed-off-by: Mika Westerberg

thunderbolt: Do not report errors if on-board retimers are found

2022-12-27T08:39:52+00:00

Currently we return an error even if on-board retimers are found and
that's not expected. Fix this to return an error only if there was one
and 0 otherwise.

Fixes: 1e56c88adecc ("thunderbolt: Runtime resume USB4 port when retimers are scanned")
Cc: stable@vger.kernel.org
Signed-off-by: Utkarsh Patel 
Signed-off-by: Mika Westerberg

thunderbolt: Convert to use sysfs_emit()/sysfs_emit_at() APIs

2022-09-24T06:22:01+00:00

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.

While at it, use Elvis operator in some cases.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Mika Westerberg

thunderbolt: Move vendor specific NVM handling into nvm.c

2022-09-07T06:06:51+00:00

As there will be more USB4 devices that support NVM firmware upgrade from
various vendors, it makes sense to split out the Intel specific NVM
image handling from the generic code. This moves the Intel specific NVM
handling into a new structure that will be matched by the device type
and the vendor ID. Do this for both routers and retimers.

This makes it easier to extend the NVM support to cover new vendors and
NVM image formats in the future.

Signed-off-by: Szuying Chen 
Signed-off-by: Mika Westerberg

thunderbolt: Provide tb_retimer_nvm_read() analogous to tb_switch_nvm_read()

2022-09-07T06:06:51+00:00

As we are moving the NVM vendor specifics into nvm.c we need to deal
witht he retimer NVM formats too. For this reason provide retimer
specific function that can be used to read the contents of the NVM and
rename the internal ones accordingly analogous to what we do with
routers.

Signed-off-by: Mika Westerberg

thunderbolt: Extend NVM version fields to 32-bits

2022-09-07T06:06:50+00:00

In order to support non-Intel NVM image formats extend the NVM major and
minor version to 32-bits to better accommondate different versioning
schemes.

No functional impact.

Signed-off-by: Szuying Chen 
Signed-off-by: Mika Westerberg

thunderbolt: Runtime resume USB4 port when retimers are scanned

2021-12-07T12:18:33+00:00

Sometimes when plugging in a USB4 device we might see following error:

  thunderbolt 1-0:3.1: runtime PM trying to activate child device 1-0:3.1 but parent (usb4_port3) is not active

This happens because the parent USB4 port was still runtime suspended.
Fix this by runtime resuming the USB4 port before scanning the retimers
below it.

Signed-off-by: Mika Westerberg

thunderbolt: Check for NVM authentication status after the operation started

2021-06-01T07:53:32+00:00

If the NVM authentication fails immediately, like if the firmware
detects that the image is not valid for some reason, better to read the
status once and if set to non-zero fail the operation accordingly.

Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman

thunderbolt: Add WRITE_ONLY and AUTHENTICATE_ONLY NVM operations for retimers

2021-06-01T07:53:32+00:00

The same way we support these two operations for USB4 routers we can
extend the retimer NVM operations to support retimers also.

Signed-off-by: Rajmohan Mani 
Co-developed-by: Mika Westerberg 
Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman

thunderbolt: Add support for retimer NVM upgrade when there is no link

2021-06-01T07:53:31+00:00

With help from platform firmware (ACPI) it is possible to power on
retimers even when there is no USB4 link (e.g nothing is connected to
the USB4 ports). This allows us to bring the USB4 sideband up so that we
can access retimers and upgrade their NVM firmware.

If the platform has support for this, we expose two additional
attributes under USB4 ports: offline and rescan. These can be used to
bring the port offline, rescan for the retimers and put the port online
again. The retimer NVM upgrade itself works the same way than with cable
connected.

Signed-off-by: Rajmohan Mani 
Co-developed-by: Mika Westerberg 
Signed-off-by: Mika Westerberg 
Reviewed-by: Greg Kroah-Hartman