linux-stable.git/drivers/thermal/broadcom, branch v6.4.2

thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister

2023-04-07T16:36:28+00:00

The driver is using the devm_thermal_of_zone_device_register().

In the error path of the function calling
devm_thermal_of_zone_device_register(), the function
devm_thermal_of_zone_unregister() should be called instead of
thermal_of_zone_unregister(), otherwise this one will be called twice
when the device is freed.

The same happens for the remove function where the devm_ guarantee the
thermal_of_zone_unregister() will be called, so adding this call in
the remove function will lead to a double free also.

Use devm_ variant in the error path of the probe function.

Remove thermal_of_zone_unregister() in the remove function.

Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20230404075138.2914680-1-daniel.lezcano@linaro.org

thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs()

2023-03-03T19:45:02+00:00

The thermal->tzp->no_hwmon parameter is only used when calling
thermal_zone_device_register().

Setting it to 'false' before calling thermal_add_hwmon_sysfs() has no
effect.

Remove the call and again prevent the drivers to access the thermal
internals.

Reviewed-by: Niklas Söderlund  #R-Car
Signed-off-by: Daniel Lezcano 
Acked-by: Florian Fainelli  #Broadcom
Acked-by: Heiko Stuebner  #rockchip
Signed-off-by: Rafael J. Wysocki

thermal: Remove debug or error messages in get_temp() ops

2023-03-03T19:45:02+00:00

Some get_temp() ops implementation are showing an error or a debug
message if the reading of the sensor fails.

The debug message is already displayed from the call site of this
ops. So we can remove it.

On the other side, the error should not be displayed because in
production that can raise tons of messages.

Finally, some drivers are showing a debug message with the
temperature, this is also accessible through the trace from the core
code in the temperature_update() function.

Another benefit is the dev_* messages are accessing the thermal zone
device field from the structure, so we encapsulate even more the code
by preventing these accesses.

Remove those messages.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Miquel Raynal  #Armada
Acked-by: Florian Fainelli  #brcmstb_thermal.c
Acked-by: Heiko Stuebner  #rockchip
Signed-off-by: Rafael J. Wysocki

thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers

2023-03-03T19:45:02+00:00

The thermal zone device structure is exposed to the different drivers
and obviously they access the internals while that should be
restricted to the core thermal code.

In order to self-encapsulate the thermal core code, we need to prevent
the drivers accessing directly the thermal zone structure and provide
accessor functions to deal with.

Use the devdata accessor introduced in the previous patch.

No functional changes intended.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Niklas Söderlund  #R-Car
Acked-by: Mark Brown 
Reviewed-by: AngeloGioacchino Del Regno  #MediaTek auxadc and lvts
Reviewed-by: Balsam CHIHI  #Mediatek lvts
Reviewed-by: Adam Ward  #da9062
Reviewed-by: Baolin Wang   #spread
Acked-by: Jernej Skrabec  #sun8i_thermal
Acked-by: Rafael J. Wysocki 
Acked-by: Florian Fainelli  #Broadcom
Reviewed-by: Dhruva Gole  # K3 bandgap
Acked-by: Linus Walleij 
Acked-by: Heiko Stuebner  #rockchip
Reviewed-by: Kunihiko Hayashi  #uniphier
Signed-off-by: Rafael J. Wysocki

thermal: Remove core header inclusion from drivers

2023-02-15T16:29:48+00:00

As the name states "thermal_core.h" is the header file for the core
components of the thermal framework.

Too many drivers are including it. Hopefully the recent cleanups
helped to self encapsulate the code a bit more and prevented the
drivers to need this header.

Remove this inclusion in every place where it is possible.

Some other drivers did a confusion with the core header and the one
exported in linux/thermal.h. They include the former instead of the
latter. The changes also fix this.

The tegra/soctherm driver still remains as it uses an internal
function which need to be replaced.

The Intel HFI driver uses the netlink internal framework core and
should be changed to prevent to deal with the internals.

No functional changes intended.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Miquel Raynal  # armada_thermal.c
Reviewed-by: Kunihiko Hayashi  # uniphier_thermal.c
Reviewed-by: Niklas Söderlund  # rcar_gen3_thermal.c
Reviewed-by: Neil Armstrong  # amlogic_thermal.c
Acked-by: Florian Fainelli  # bcm2835_thermal.c
Acked-by: Thierry Reding  # tegra30-tsensor.c
Link: https://lore.kernel.org/r/20230206153432.1017282-1-daniel.lezcano@linaro.org
Signed-off-by: Rafael J. Wysocki

thermal/drivers/bcm2835: Use devm_platform_get_and_ioremap_resource()

2023-01-18T21:14:11+00:00

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: ye xingchen 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/202301181636223863583@zte.com.cn
Signed-off-by: Daniel Lezcano

thermal/drivers/brcmstb_thermal: Use devm_platform_get_and_ioremap_resource()

2023-01-18T21:12:56+00:00

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: ye xingchen 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/202301181631362083446@zte.com.cn
Signed-off-by: Daniel Lezcano

thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function

2023-01-06T13:14:48+00:00

The thermal framework gives the possibility to register the trip
points with the thermal zone. When that is done, no get_trip_* ops are
needed and they can be removed.

Convert ops content logic into generic trip points and register them with the
thermal zone.

Signed-off-by: Daniel Lezcano 
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20221003092602.1323944-24-daniel.lezcano@linaro.org

thermal/drivers/broadcom: Switch to new of API

2022-08-17T12:09:38+00:00

The thermal OF code has a new API allowing to migrate the OF
initialization to a simpler approach. The ops are no longer device
tree specific and are the generic ones provided by the core code.

Convert the ops to the thermal_zone_device_ops format and use the new
API to register the thermal zone with these generic ops.

Signed-off-by: Daniel Lezcano 
Tested-by: Florian Fainelli 
Reviewed-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20220804224349.1926752-11-daniel.lezcano@linexp.org
Signed-off-by: Daniel Lezcano

thermal/drivers/broadcom: Fix potential NULL dereference in sr_thermal_probe

2022-05-19T10:11:52+00:00

platform_get_resource() may return NULL, add proper check to
avoid potential NULL dereferencing.

Fixes: 250e211057c72 ("thermal: broadcom: Add Stingray thermal driver")
Signed-off-by: Zheng Yongjun 
Link: https://lore.kernel.org/r/20220425092929.90412-1-zhengyongjun3@huawei.com
Signed-off-by: Daniel Lezcano