linux-stable.git/drivers/thermal/broadcom, branch v6.11

thermal/drivers/broadcom: Simplify with dev_err_probe()

2024-07-15T11:31:40+00:00

Error handling in probe() can be a bit simpler with dev_err_probe().

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-3-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano

thermal/drivers/broadcom: Simplify probe() with local dev variable

2024-07-15T11:31:40+00:00

Simplify the probe() function by using local 'dev' instead of
&pdev->dev.

Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-2-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano

thermal/drivers/broadcom: Fix race between removal and clock disable

2024-07-15T11:31:40+00:00

During the probe, driver enables clocks necessary to access registers
(in get_temp()) and then registers thermal zone with managed-resources
(devm) interface.  Removal of device is not done in reversed order,
because:
1. Clock will be disabled in driver remove() callback - thermal zone is
   still registered and accessible to users,
2. devm interface will unregister thermal zone.

This leaves short window between (1) and (2) for accessing the
get_temp() callback with disabled clock.

Fix this by enabling clock also via devm-interface, so entire cleanup
path will be in proper, reversed order.

Fixes: 8454c8c09c77 ("thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister")
Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-1-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano

thermal: ns: Convert to platform remove callback returning void

2023-09-29T10:34:16+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Acked-by: Daniel Lezcano 
Signed-off-by: Rafael J. Wysocki

thermal: bcm2835: Convert to platform remove callback returning void

2023-09-29T10:34:16+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Acked-by: Daniel Lezcano 
Signed-off-by: Rafael J. Wysocki

thermal/drivers/broadcom/brcstb_thermal: Removed unneeded platform_set_drvdata()

2023-08-16T10:22:28+00:00

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Signed-off-by: Andrei Coardos 
Reviewed-by: Alexandru Ardelean 
Reviewed-by: Florian Fainelli 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20230809154813.16033-1-aboutphysycs@gmail.com

thermal/drivers/broadcom/sr-thermal: Removed call to platform_set_drvdata()

2023-08-16T10:17:19+00:00

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Signed-off-by: Andrei Coardos 
Reviewed-by: Alexandru Ardelean 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20230810111330.3248-1-aboutphysycs@gmail.com

thermal: Explicitly include correct DT includes

2023-07-31T18:03:42+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Reviewed-by: Alim Akhtar 
Signed-off-by: Rafael J. Wysocki

thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister

2023-04-07T16:36:28+00:00

The driver is using the devm_thermal_of_zone_device_register().

In the error path of the function calling
devm_thermal_of_zone_device_register(), the function
devm_thermal_of_zone_unregister() should be called instead of
thermal_of_zone_unregister(), otherwise this one will be called twice
when the device is freed.

The same happens for the remove function where the devm_ guarantee the
thermal_of_zone_unregister() will be called, so adding this call in
the remove function will lead to a double free also.

Use devm_ variant in the error path of the probe function.

Remove thermal_of_zone_unregister() in the remove function.

Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20230404075138.2914680-1-daniel.lezcano@linaro.org

thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs()

2023-03-03T19:45:02+00:00

The thermal->tzp->no_hwmon parameter is only used when calling
thermal_zone_device_register().

Setting it to 'false' before calling thermal_add_hwmon_sysfs() has no
effect.

Remove the call and again prevent the drivers to access the thermal
internals.

Reviewed-by: Niklas Söderlund  #R-Car
Signed-off-by: Daniel Lezcano 
Acked-by: Florian Fainelli  #Broadcom
Acked-by: Heiko Stuebner  #rockchip
Signed-off-by: Rafael J. Wysocki